From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Rokosov <DDRokosov@sberdevices.ru>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"lorenzo.bianconi83@gmail.com" <lorenzo.bianconi83@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"stephan@gerhold.net" <stephan@gerhold.net>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"antoniu.miclaus@analog.com" <antoniu.miclaus@analog.com>,
"sean@geanix.com" <sean@geanix.com>,
"linmq006@gmail.com" <linmq006@gmail.com>,
"gwendal@chromium.org" <gwendal@chromium.org>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 0/5] iio: treewide: rearrange iio trig get/register
Date: Mon, 23 May 2022 19:40:27 +0200 [thread overview]
Message-ID: <CAHp75VeuAxMWknoG28v8k-gKCpUQFJbwpq+pTaTVPeY45vQo2w@mail.gmail.com> (raw)
In-Reply-To: <20220523164159.11579-1-ddrokosov@sberdevices.ru>
On Mon, May 23, 2022 at 6:42 PM Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:
>
> The following patchset resolves problems with iio_trigger_get() and
> iio_trigger_register() call order in the different IIO drivers.
>
> IIO trigger interface function iio_trigger_get() should be called after
> iio_trigger_register() (or its devm analogue) strictly, because of
> iio_trigger_get() acquires module refcnt based on the trigger->owner
> pointer, which is initialized inside iio_trigger_register() to
> THIS_MODULE.
> If this call order is wrong, the next iio_trigger_put() (from sysfs
> callbacks or rmmod) will derefence "default" module refcnt, which is
dereference
> completely incorrect.
Cool set! But it sounds like a set of fixes, can you add a Fixes tag
to each of the patches?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-23 18:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 16:41 [PATCH v1 0/5] iio: treewide: rearrange iio trig get/register Dmitry Rokosov
2022-05-23 16:41 ` [PATCH v1 1/5] iio:accel:bma180: rearrange iio trigger get and register Dmitry Rokosov
2022-05-23 16:41 ` [PATCH v1 2/5] iio:accel:kxcjk-1013: " Dmitry Rokosov
2022-05-23 16:41 ` [PATCH v1 3/5] iio:accel:mxc4005: " Dmitry Rokosov
2022-05-23 16:41 ` [PATCH v1 4/5] iio:chemical:ccs811: " Dmitry Rokosov
2022-05-23 17:40 ` Andy Shevchenko [this message]
2022-05-23 19:06 ` [PATCH v1 0/5] iio: treewide: rearrange iio trig get/register Dmitry Rokosov
2022-05-23 18:36 ` [PATCH v1 5/5] iio:humidity:hts221: rearrange iio trigger get and register Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeuAxMWknoG28v8k-gKCpUQFJbwpq+pTaTVPeY45vQo2w@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=DDRokosov@sberdevices.ru \
--cc=antoniu.miclaus@analog.com \
--cc=gwendal@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@geanix.com \
--cc=stephan@gerhold.net \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.