From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B981DC43334 for ; Fri, 1 Jul 2022 20:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbiGAUYR (ORCPT ); Fri, 1 Jul 2022 16:24:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbiGAUYQ (ORCPT ); Fri, 1 Jul 2022 16:24:16 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CAB32ED5B; Fri, 1 Jul 2022 13:24:13 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id 205so3467617ybe.3; Fri, 01 Jul 2022 13:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/MRsD2vJA8bDPtwGkMOr5/5qFkYCaN1HrNYJP8Aooaw=; b=MRMpkkkXd/AxaYKSqzVZ+JHGaNVydSScCwxeeTHy7nH9KnkQVHPCiFczxXqDZ++Eou oVPL5T2xx4TJ6WrEVruW23jgn5i0TbeLnhYhbNHWvJ/WJyf7ev8SxZF2YbGAfdUj2bqR BNRaRznaCwOa3BaYlKZi1g5WgSO4/Zg0olrORzny6nh9qIbQkP1FZTOltjqjit/0/vUF sbk8BerO6Qd9qJj9xpU62MQ5wpEivT03M+gjvTjP0AdvLDgncvTpscUSJsa7ULEq+aKc glVbZ9ngxZixwRW1/pJd4TNQON1BiMrb4owcn1YR3jIn8IJFW+EUDYQmgPdBlky6fwIs 93/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/MRsD2vJA8bDPtwGkMOr5/5qFkYCaN1HrNYJP8Aooaw=; b=FfyIZFlG3h28qdvwFuWaM1KzACweZp8PyTE7063p9+3F9Fy+txjx3YH2QCxzAeHyrD Bir+V+HbHb2DCzVe03/BJ7uNxpQQHn8W8OZtazrL1Ob6MGwmZvk4aojZynUJgBBkiUyH AD4DWsGG1CQKR0lMhLMqb/85PChuCq/6VvUovbA4hb5GCxCTHxn8gSqRKjVKhA5MFz2p ZsljI1KABvIzKGdTOYVkR11oR78x5R2lAfSKcpNK8T5cIIiRL2gsLsso3zCCEGP5Cam1 BdMpjRqG+O1HuTa1GZ+2gPTYBnBt+UG6R8U8K70y6lzhyqJX5TflZz4VEyec3UcvrnP7 qXmg== X-Gm-Message-State: AJIora8P72FZszn/0raMeO5JMO68YLVzTYq/lwE7+PiWNfidsaVSl1VK 1M2iMzlqxj12vg4sd6PzquXCpDTKYWSriI2rP2c= X-Google-Smtp-Source: AGRyM1vq5LZzi17RwsZX1h8W1o/LdR7lMKPEJ+/xA1ayuCIn2yWQfXjsi0iDyG5el8EluNbqyOSP9Fylvctdu7Yr1Ss= X-Received: by 2002:a05:6902:c4:b0:64b:4677:331b with SMTP id i4-20020a05690200c400b0064b4677331bmr17139233ybs.93.1656707052779; Fri, 01 Jul 2022 13:24:12 -0700 (PDT) MIME-Version: 1.0 References: <20220701192609.3970317-1-colin.foster@in-advantage.com> <20220701192609.3970317-2-colin.foster@in-advantage.com> In-Reply-To: <20220701192609.3970317-2-colin.foster@in-advantage.com> From: Andy Shevchenko Date: Fri, 1 Jul 2022 22:23:36 +0200 Message-ID: Subject: Re: [PATCH v12 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource To: Colin Foster Cc: devicetree , Linux Kernel Mailing List , netdev , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Vladimir Oltean , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Linus Walleij , Wolfram Sang , Terry Bowman , katie.morris@in-advantage.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jul 1, 2022 at 9:26 PM Colin Foster wrote: > > Several ocelot-related modules are designed for MMIO / regmaps. As such, > they often use a combination of devm_platform_get_and_ioremap_resource and > devm_regmap_init_mmio. > > Operating in an MFD might be different, in that it could be memory mapped, > or it could be SPI, I2C... In these cases a fallback to use IORESOURCE_REG > instead of IORESOURCE_MEM becomes necessary. > > When this happens, there's redundant logic that needs to be implemented in > every driver. In order to avoid this redundancy, utilize a single function > that, if the MFD scenario is enabled, will perform this fallback logic. ... > + res = platform_get_resource(pdev, IORESOURCE_MEM, index); > + if (res) { > + regs = devm_ioremap_resource(dev, res); > + if (IS_ERR(regs)) > + return ERR_CAST(regs); Why can't it be devm_platform_get_and_ioremap_resource() here? regs = devm_platform_get_and_ioremap_resource(); if (res) { if (IS_ERR(regs)) return ERR_CAST(); return ... } > + return devm_regmap_init_mmio(dev, regs, config); > + } ... > + return (map) ? map : ERR_PTR(-ENOENT); Too many parentheses. Also you may use short form of ternary operator: return map ?: ERR_PTR(-ENOENT); -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6D79C433EF for ; Fri, 1 Jul 2022 20:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sj2WMvqWbGffXkKPPBW24QmQX7qpMiFsmJ6YcM/ptq0=; b=qcF4PVeGE6Pe27 nkWTBGL8LnvLxffcJgULTtLgZUGmz4jgagxySsryo9l7TZKLSD0illBke6E5+NF5myAbF4uZ5QI1T 2wRTJ4Hfu0aCWgBAoIeMm44raVuI7YuVdeQrPYceuORl4gIzqTVvLcaJHPZoQGsWBU9EED3prAthN 4yBbB8rMvPH1phpPpLQs2jQxOOO3BG2+ErURbMJNOYQ9UwKWZctWMzwvOoAYTXv8CelS2tVdX7uEq RAnPrSW3nbs1MENvIL+XPqbcvRH1uIBzCQcpRZt/PX5DaYS+gTBfrsgedDncKKhDpcmQ2qwcBB2KE UyAzh0rL09QW1egfuDKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7NBc-006n16-EC; Fri, 01 Jul 2022 20:24:20 +0000 Received: from mail-yb1-xb29.google.com ([2607:f8b0:4864:20::b29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7NBV-006n02-UH for linux-arm-kernel@lists.infradead.org; Fri, 01 Jul 2022 20:24:17 +0000 Received: by mail-yb1-xb29.google.com with SMTP id v185so5876857ybe.8 for ; Fri, 01 Jul 2022 13:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/MRsD2vJA8bDPtwGkMOr5/5qFkYCaN1HrNYJP8Aooaw=; b=MRMpkkkXd/AxaYKSqzVZ+JHGaNVydSScCwxeeTHy7nH9KnkQVHPCiFczxXqDZ++Eou oVPL5T2xx4TJ6WrEVruW23jgn5i0TbeLnhYhbNHWvJ/WJyf7ev8SxZF2YbGAfdUj2bqR BNRaRznaCwOa3BaYlKZi1g5WgSO4/Zg0olrORzny6nh9qIbQkP1FZTOltjqjit/0/vUF sbk8BerO6Qd9qJj9xpU62MQ5wpEivT03M+gjvTjP0AdvLDgncvTpscUSJsa7ULEq+aKc glVbZ9ngxZixwRW1/pJd4TNQON1BiMrb4owcn1YR3jIn8IJFW+EUDYQmgPdBlky6fwIs 93/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/MRsD2vJA8bDPtwGkMOr5/5qFkYCaN1HrNYJP8Aooaw=; b=ae3A2akmwmAWn6ycjPrnqlCuJWQe+UGfhedkLiDqdv8ep2HlQFVO6vuoBybTKuDG8k vzBgGUbsQ7ls2N75lt3K0+v+UDd1D+hRKGLXzgrldcLVnVX+x1Cw5mn6ckE8fzHXi83F Vw0H+80wjnzY95KAMvBpGdKmtQgtgxZyGBpmY9zk24qTT7+g28Y7nLdHSDGdXB2KijjL cYsbt1std7GR71dNIuX7AKw+lm+YxMoLhIUw10uwbmtMjlsqHVvXwiF0xriQT9Pya7a4 WUJ51Z/mCNwo1QKm+xL0x2g+mmCV4M1+vwXVeRaIKxwTblbHijWeoPEjkVulAcbE4ZOu EnHw== X-Gm-Message-State: AJIora9NbGeoYUqDbdQc5BCqwqH8DDiR4nA/6YdxMsjjA9hrgJ4yVWQw DKvsXCPrnAqmtgApDn1y0l+DW1GVGS+Ju60NG5U= X-Google-Smtp-Source: AGRyM1vq5LZzi17RwsZX1h8W1o/LdR7lMKPEJ+/xA1ayuCIn2yWQfXjsi0iDyG5el8EluNbqyOSP9Fylvctdu7Yr1Ss= X-Received: by 2002:a05:6902:c4:b0:64b:4677:331b with SMTP id i4-20020a05690200c400b0064b4677331bmr17139233ybs.93.1656707052779; Fri, 01 Jul 2022 13:24:12 -0700 (PDT) MIME-Version: 1.0 References: <20220701192609.3970317-1-colin.foster@in-advantage.com> <20220701192609.3970317-2-colin.foster@in-advantage.com> In-Reply-To: <20220701192609.3970317-2-colin.foster@in-advantage.com> From: Andy Shevchenko Date: Fri, 1 Jul 2022 22:23:36 +0200 Message-ID: Subject: Re: [PATCH v12 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource To: Colin Foster Cc: devicetree , Linux Kernel Mailing List , netdev , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Vladimir Oltean , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Linus Walleij , Wolfram Sang , Terry Bowman , katie.morris@in-advantage.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_132414_028648_7AA63DF8 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 1, 2022 at 9:26 PM Colin Foster wrote: > > Several ocelot-related modules are designed for MMIO / regmaps. As such, > they often use a combination of devm_platform_get_and_ioremap_resource and > devm_regmap_init_mmio. > > Operating in an MFD might be different, in that it could be memory mapped, > or it could be SPI, I2C... In these cases a fallback to use IORESOURCE_REG > instead of IORESOURCE_MEM becomes necessary. > > When this happens, there's redundant logic that needs to be implemented in > every driver. In order to avoid this redundancy, utilize a single function > that, if the MFD scenario is enabled, will perform this fallback logic. ... > + res = platform_get_resource(pdev, IORESOURCE_MEM, index); > + if (res) { > + regs = devm_ioremap_resource(dev, res); > + if (IS_ERR(regs)) > + return ERR_CAST(regs); Why can't it be devm_platform_get_and_ioremap_resource() here? regs = devm_platform_get_and_ioremap_resource(); if (res) { if (IS_ERR(regs)) return ERR_CAST(); return ... } > + return devm_regmap_init_mmio(dev, regs, config); > + } ... > + return (map) ? map : ERR_PTR(-ENOENT); Too many parentheses. Also you may use short form of ternary operator: return map ?: ERR_PTR(-ENOENT); -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel