From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7BBC433E0 for ; Wed, 30 Dec 2020 20:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1E3720B1F for ; Wed, 30 Dec 2020 20:48:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbgL3Ust (ORCPT ); Wed, 30 Dec 2020 15:48:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgL3Ust (ORCPT ); Wed, 30 Dec 2020 15:48:49 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3F28C061573; Wed, 30 Dec 2020 12:48:08 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id h10so9295795pfo.9; Wed, 30 Dec 2020 12:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jRVdipqMo3SGkScdVCSY0NCVDydJxCZXUp0vL0ss0j8=; b=Ex8hVNUWqY+rbyZwRHu0Z8ZFDWv3n6GCNQ6/oKC9ORvHkbkiVNGzdB91SjAk392fsg s3ED8sOmsckgJOxTaNfYxosbDaaMTahyn8teOd4ojTAUMBd0JUPKX5HzCwG4Hhbis73B uRuMcfr3NQT5ekO4VMFxihb+mdcnRnFki6aY9LJt3PYKLZkgwrGw4VeNdH9ioFHjsks1 vbOzj6pKww4PqUZL4f29Bi4HnqOfCxVzr4w0ISFjRmcq4dfx2pLhCVAB43Q8usle0KNN XoU1DpgnpDL8QwmG6+owvGJ/TZUxTIGNNavC1HalaTQByK0CRPAB+fhq7VP0yAqWMm5L wt4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jRVdipqMo3SGkScdVCSY0NCVDydJxCZXUp0vL0ss0j8=; b=EvKOt2D2oKqHTPO5ECfCGDcGPZ/Mbx08uNO1GIA/DrfNwAMXzjq1gjhaz7jsMzcrDb WcOjDyFGLUj3FbBeEHViVCpxk32HKfZeoqVcJ7eAGlBDqfBFxh1Ee55QOyeTfJrrH79T 51ibimUaLZuv9ZtE6/AIIOT7kyXfr/iW1Tti6s8DTecrnbHjHiJP+rUL2axyGHbbL4xb 6ib/1VVZOcgq/eI6HmOhtOgS+pdi4HB0F6b5b+umvKghnxsnWYyeMyEuYa6cqsY3rcH5 A1ZNW/TwuLOkvwvRk1HNboy2XIyBcy0JwKFcKr6PZtM0A3Mq7Jo0eAdj2fsAKXswx66Y ypxA== X-Gm-Message-State: AOAM531K/Ev6mIXZCkokCn4f4uqC4EiEjFgnlJNiq9kNNkx1sBUOrr0C 0fVAuJzt3YkLKoEwLhzJ62RQL9cXZsTi/XqjnroaXIlKC6/9wA== X-Google-Smtp-Source: ABdhPJxSMf4/TA4B3IeFbMjgSsLR1NtTgwkka1CnQ1qojXL0WNjbTMpocAhYi5Qhs2jjwKkiX06W8HtrgHf96sok07s= X-Received: by 2002:a63:c04b:: with SMTP id z11mr53914993pgi.74.1609361287808; Wed, 30 Dec 2020 12:48:07 -0800 (PST) MIME-Version: 1.0 References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> <20201228225544.GH4077@smile.fi.intel.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 30 Dec 2020 22:47:51 +0200 Message-ID: Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver To: Laurent Pinchart , Andy Shevchenko Cc: Daniel Scally , Sakari Ailus , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Dec 29, 2020 at 2:07 AM Laurent Pinchart wrote: > On Tue, Dec 29, 2020 at 01:54:59AM +0200, Andy Shevchenko wrote: > > On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote: ... > > +#include > > I think this can be dropped. I dropped above (I noticed it's included by a half of the headers listed below. > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include ... > How about grouping all forward declarations at the top ? Done. > Otherwise this looks good, > > Reviewed-by: Laurent Pinchart Thanks! I just sent a formal patch with your tag included. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6186935708824645347==" MIME-Version: 1.0 From: Andy Shevchenko Subject: [Devel] Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Date: Wed, 30 Dec 2020 20:48:08 +0000 Message-ID: In-Reply-To: X+pzKDNWpiQWenHy@pendragon.ideasonboard.com List-ID: To: devel@acpica.org --===============6186935708824645347== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Dec 29, 2020 at 2:07 AM Laurent Pinchart wrote: > On Tue, Dec 29, 2020 at 01:54:59AM +0200, Andy Shevchenko wrote: > > On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote: ... > > +#include > > I think this can be dropped. I dropped above (I noticed it's included by a half of the headers listed be= low. > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include ... > How about grouping all forward declarations at the top ? Done. > Otherwise this looks good, > > Reviewed-by: Laurent Pinchart Thanks! I just sent a formal patch with your tag included. -- = With Best Regards, Andy Shevchenko --===============6186935708824645347==--