From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions Date: Wed, 3 May 2017 20:47:31 +0300 Message-ID: References: <64ab3ba9-6cfa-fd59-976c-8f22b2b9a2c5@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-qt0-f180.google.com ([209.85.216.180]:34173 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbdECRrd (ORCPT ); Wed, 3 May 2017 13:47:33 -0400 In-Reply-To: <64ab3ba9-6cfa-fd59-976c-8f22b2b9a2c5@users.sourceforge.net> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: SF Markus Elfring Cc: "linux-gpio@vger.kernel.org" , Linus Walleij , LKML , kernel-janitors@vger.kernel.org On Tue, May 2, 2017 at 12:22 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 May 2017 22:42:13 +0200 > > Some text was put into a sequence by two separate function calls. > Print the same data by a single function call instead. I don't see a benefit here, sorry. This is slow path in any case (printing is slow). Currently code is neat, you do it slightly harder to parse. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Wed, 03 May 2017 17:47:31 +0000 Subject: Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions Message-Id: List-Id: References: <64ab3ba9-6cfa-fd59-976c-8f22b2b9a2c5@users.sourceforge.net> In-Reply-To: <64ab3ba9-6cfa-fd59-976c-8f22b2b9a2c5@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: "linux-gpio@vger.kernel.org" , Linus Walleij , LKML , kernel-janitors@vger.kernel.org On Tue, May 2, 2017 at 12:22 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 May 2017 22:42:13 +0200 > > Some text was put into a sequence by two separate function calls. > Print the same data by a single function call instead. I don't see a benefit here, sorry. This is slow path in any case (printing is slow). Currently code is neat, you do it slightly harder to parse. -- With Best Regards, Andy Shevchenko