From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbbKYUT3 (ORCPT ); Wed, 25 Nov 2015 15:19:29 -0500 Received: from mail-yk0-f177.google.com ([209.85.160.177]:36626 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbbKYUT0 convert rfc822-to-8bit (ORCPT ); Wed, 25 Nov 2015 15:19:26 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 25 Nov 2015 22:19:25 +0200 Message-ID: Subject: Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used. From: Andy Shevchenko To: Dmitry Krivenok Cc: "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2015 at 9:16 PM, Dmitry Krivenok wrote: > Do not use "0x" in front of %pa, %pap and %pad to avoid > duplicate "0x" in the output. First of all, please, split per subsystem / driver. Here seems one file — one patch. And one comment below. > > Signed-off-by: Dmitry V. Krivenok > --- > drivers/dma/at_hdmac_regs.h | 2 +- > drivers/i2c/busses/i2c-st.c | 2 +- > drivers/nvdimm/pmem.c | 2 +- > drivers/of/fdt.c | 2 +- > drivers/pci/host/pcie-iproc.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h > index 7f58f06..0474e4a 100644 > --- a/drivers/dma/at_hdmac_regs.h > +++ b/drivers/dma/at_hdmac_regs.h > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {} > static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli) > { > dev_crit(chan2dev(&atchan->chan_common), > - " desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n", > + " desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n", > &lli->saddr, &lli->daddr, > lli->ctrla, lli->ctrlb, &lli->dscr); > } > diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c > index ea72dca..25020ec 100644 > --- a/drivers/i2c/busses/i2c-st.c > +++ b/drivers/i2c/busses/i2c-st.c > @@ -822,7 +822,7 @@ static int st_i2c_probe(struct platform_device *pdev) > > adap = &i2c_dev->adap; > i2c_set_adapdata(adap, i2c_dev); > - snprintf(adap->name, sizeof(adap->name), "ST I2C(0x%pa)", &res->start); > + snprintf(adap->name, sizeof(adap->name), "ST I2C(%pa)", &res->start); > adap->owner = THIS_MODULE; > adap->timeout = 2 * HZ; > adap->retries = 0; > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 8ee7989..93396f4 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -135,7 +135,7 @@ static struct pmem_device *pmem_alloc(struct device *dev, > > if (!devm_request_mem_region(dev, pmem->phys_addr, pmem->size, > dev_name(dev))) { > - dev_warn(dev, "could not reserve region [0x%pa:0x%zx]\n", > + dev_warn(dev, "could not reserve region [%pa:0x%zx]\n", > &pmem->phys_addr, pmem->size); > return ERR_PTR(-EBUSY); > } > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index d243029..1bbe3a9 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -1041,7 +1041,7 @@ void __init __weak > early_init_dt_add_memory_arch(u64 base, u64 size) > int __init __weak early_init_dt_reserve_memory_arch(phys_addr_t base, > phys_addr_t size, bool nomap) > { > - pr_err("Reserved memory not supported, ignoring range 0x%pa - 0x%pa%s\n", > + pr_err("Reserved memory not supported, ignoring range %pa - %pa%s\n", > &base, &size, nomap ? " (nomap)" : ""); > return -ENOSYS; > } > diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c > index eac719a..d1ad883 100644 > --- a/drivers/pci/host/pcie-iproc.c > +++ b/drivers/pci/host/pcie-iproc.c > @@ -245,7 +245,7 @@ static int iproc_pcie_setup_ob(struct iproc_pcie > *pcie, u64 axi_addr, > > if (size > max_size) { > dev_err(pcie->dev, > - "res size 0x%pap exceeds max supported size 0x%llx\n", > + "res size %pap exceeds max supported size 0x%llx\n", %pa also works. > &size, max_size); -- With Best Regards, Andy Shevchenko