Re: linux-next: build failure after merge of the gpio-brgl tree

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Fri, Feb 23, 2024 at 9:51 AM Bartosz Golaszewski
<bartosz.golaszewski@linaro.org> wrote:
> On Fri, 23 Feb 2024 at 04:33, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
> > gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
> > gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
> > gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
> > x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
> > gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'
> >
> > Caused by commit
> >
> >   36e44186e0ba ("gpio: mmio: Support 64-bit BE access")
> >
> > I have used the gpio-brgl from next-20240222 for today.

> I'm not seeing this issue with allmodconfig on x86_64, could you give
> me some more information on the build environment?
>
> Andy: Could it be that the ifdefs you added should depend on
> CONFIG_64BIT and not only on the BITS_PER_LONG value?

If so, it will be the old issue as I just used what is currently done
for LE 64-bit accessors in the same file.
I think the problem here is different, i.e. io*64*() are not available
on all (64-bit) architectures in comparison to readq()/writeq().
I'll look at this later today.


-- 
With Best Regards,
Andy Shevchenko