From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Corentin Chary <corentin.chary@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: samsung-laptop: set debugfs blobs to read only
Date: Tue, 4 May 2021 18:05:18 +0300 [thread overview]
Message-ID: <CAHp75Vf59LDsh0D2+Cd429Z01BApz8niFyg_HU_NG-D4mhuH8g@mail.gmail.com> (raw)
In-Reply-To: <20210504131714.GB43834@ninjato>
On Tue, May 4, 2021 at 4:17 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
>
> > Linus has (had?) a strong opinion about it. My point is to reduce the
>
> OK, I see. Thanks for the pointer!
>
> > churn since two patches fixing the very same parameter in a row seems
> > too much to me.
>
> I'd still prefer that and having a seperate patch fixing the whole
> driver. IMO better than having a mixture of octals and defines.
You can convert the rest as well. And point out that only blobs are RO.
Whatever, the main idea is to do both things either with one patch or
two in a series at the same time.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-05-04 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 12:31 [PATCH] platform/x86: samsung-laptop: set debugfs blobs to read only Wolfram Sang
2021-05-04 12:40 ` Andy Shevchenko
2021-05-04 12:51 ` Wolfram Sang
2021-05-04 13:09 ` Andy Shevchenko
2021-05-04 13:17 ` Wolfram Sang
2021-05-04 15:05 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf59LDsh0D2+Cd429Z01BApz8niFyg_HU_NG-D4mhuH8g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.