From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D27CC433E9 for ; Mon, 8 Mar 2021 16:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF79565249 for ; Mon, 8 Mar 2021 16:40:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbhCHQjo (ORCPT ); Mon, 8 Mar 2021 11:39:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbhCHQjW (ORCPT ); Mon, 8 Mar 2021 11:39:22 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B0C2C06174A; Mon, 8 Mar 2021 08:39:22 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id a24so5111441plm.11; Mon, 08 Mar 2021 08:39:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XB+F7uA0KNP+y7mhzqyQJTQNMPmYH3O9SOc1rrsQPnc=; b=dHZenSv6k3j3wpDCQnk5ASz0ZJBo5MNQt5dCIUWyt4AflynuJoeLcWO3uNE3JsZReW 5N9CDr9cJxSRsggqWE1SJCMlBWUdBgO1zX5cQgEXRSiCP06VxpD3rWUtV8TNde24fcfG ApAmhnwCmH9JktdnchWAhnTrrKt/V0fHuAOzrhRoOx0iA+dirRRjByj/MJpwkY9pkTCl UXqPBAre93JP6gG3Lp39dBqOiS5T8gQdIpBGneYwqzWjXqvdLdx+lhNqacvhj2ZiOWKl lACl1TNN1B9n7AwDVZcRVfs8S7KA8EsLfbOhRXXjBzTI+WiIri13hMZxwrkITkPGisyA JUEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XB+F7uA0KNP+y7mhzqyQJTQNMPmYH3O9SOc1rrsQPnc=; b=ZWPGtbOt5Fy8VXJ7q1MOYTFjkiGFy8Tnqg1ocMqV1DMjzg8uRvHKwuoUFL2slgm6Io 7jHuPkeK9s5U1AXDQn75X6ERf2DTm44wpK76WlsfvFdCgcbeiklveVKEu+QktgQuGrjK mcCFJtdELFzWeAVTkJQBy2DoeXVBKuTZPkv0PokBpPEvzyYPM8EhkRPdF/2MVBmdjdP7 9MSSQQcxtyWT5LnIkgla8UO+eMHYiMcmwo41kynbSLTgaeSv2Avgzhner5HGs/YcX7Fl hC+ZFimocAT/NSdOFNxe8TKNiqikLZSVM5/Xqj73cwMSWX19Z4hpvzOVU0g4bQD/FFrS lvWw== X-Gm-Message-State: AOAM533QBnLqpuTvkvf7acSoJjReHkVzMV6Oec0wFxSCWmH4JpZavMhv x8+w4F5OjuqB4p4Fng6zdHX8An/Zo/nXB7bRB5Eom/74hmEIn9y2 X-Google-Smtp-Source: ABdhPJwL0Wch/MCgaFA2pHVXY7Wray9aHN2M1G8UX1UsXIi++pmGIpWzcXzB2aZuIsasVQ5+j4vDpONGvk4TdIQi6t0= X-Received: by 2002:a17:902:c808:b029:e6:4204:f62f with SMTP id u8-20020a170902c808b02900e64204f62fmr692632plx.0.1615221561612; Mon, 08 Mar 2021 08:39:21 -0800 (PST) MIME-Version: 1.0 References: <20210218052654.28995-1-calvin.johnson@oss.nxp.com> <20210218052654.28995-11-calvin.johnson@oss.nxp.com> <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> <20210308162811.GB2740@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210308162811.GB2740@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Mon, 8 Mar 2021 18:39:04 +0200 Message-ID: Subject: Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Linux Kernel Mailing List , netdev , ACPI Devel Maling List , Laurentiu Tudor , Diana Madalina Craciun , linux-arm Mailing List , "linux.cj" , "David S. Miller" , Heiner Kallweit , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Mar 8, 2021 at 6:28 PM Calvin Johnson wrote: > On Mon, Mar 08, 2021 at 04:57:35PM +0200, Andy Shevchenko wrote: .... > I thought of including device.h instead of dev_printk.h because, it is the > only file that includes dev_printk.h and device.h is widely used. Of course, > it will mean that dev_printk.h is indirectly called. The split happened recently, not every developer knows about it and definitely most of the contributors are too lazy to properly write the inclusion block in their code. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2EEEC433DB for ; Mon, 8 Mar 2021 16:40:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82C676522B for ; Mon, 8 Mar 2021 16:40:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82C676522B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7I9KiQz3scnbR6yUTLCVxjA0xFg2PZPz9h8RznS6mmQ=; b=mGHuwAzx4d9xsjHuO63taweSk 6KxKi7hXt0jylREkVgybpJmVgWjVTtLL+0lDL0qxC3EfWdWKjxnPstwtilA2Bm1TYT8rjSzccYD7M n2zItWoSV7wMX/XvK0D2ZOBUPaloIfrx4yiJ+ag3C+Q9Sg0z4RidTC81dIL6MrhoxFM7g8vAwEBgR 4s/c6j+llkIjlYgmqpUpBRDFxOGEho4OczqRhzAiCKtekZtp5KxLNPe0VzdaH0RhwemyYReC1l8h4 eWqNuZx0k1bEctvWvuroMSx/BmYfMwa7wGCBJp40HHMFqfwesRRBSfuV4na13mNsWnF4zLXFpBHCS bhvjNWE0A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJIum-0016gp-Mr; Mon, 08 Mar 2021 16:39:28 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJIuh-0016dJ-Bd for linux-arm-kernel@lists.infradead.org; Mon, 08 Mar 2021 16:39:25 +0000 Received: by mail-pl1-x630.google.com with SMTP id w7so1639901pll.8 for ; Mon, 08 Mar 2021 08:39:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XB+F7uA0KNP+y7mhzqyQJTQNMPmYH3O9SOc1rrsQPnc=; b=dHZenSv6k3j3wpDCQnk5ASz0ZJBo5MNQt5dCIUWyt4AflynuJoeLcWO3uNE3JsZReW 5N9CDr9cJxSRsggqWE1SJCMlBWUdBgO1zX5cQgEXRSiCP06VxpD3rWUtV8TNde24fcfG ApAmhnwCmH9JktdnchWAhnTrrKt/V0fHuAOzrhRoOx0iA+dirRRjByj/MJpwkY9pkTCl UXqPBAre93JP6gG3Lp39dBqOiS5T8gQdIpBGneYwqzWjXqvdLdx+lhNqacvhj2ZiOWKl lACl1TNN1B9n7AwDVZcRVfs8S7KA8EsLfbOhRXXjBzTI+WiIri13hMZxwrkITkPGisyA JUEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XB+F7uA0KNP+y7mhzqyQJTQNMPmYH3O9SOc1rrsQPnc=; b=RguYFezkMQXG7mjfdVgwYs7igPiZzC6d4BAl9Sciv8jEcAsLn7hZtjMHGiddKLC0fe 3rTKKcmE98c4vDc0pG0oFcnNB11dQrJtO4V+zBQltqGte8gtjAjyXpaUPojn7HuO8UaI AHgOkpIWJI4/Fuygoe+TfYbBZYxzcxAAskmn+diOHQFXR6HksxofPOgV6kefhIWifzRq fsDcI/hTv/FFYcg/ykmlsLH03tauDCOtmBa3QDkK4U4RLKfW8CLPbckHhOA+sEnlobrr W6fdQX5w/4zuxEdAoKDPkeijsXIAtuX4nJiscnp+SZLhZnEvaldd/7wwiO5n2I99vDQh 5Azg== X-Gm-Message-State: AOAM5301ddkq/AAweLV7wbDEpbwZE+VfaHspmzVy87xrkvg2xWRYTZ2A K3Lg0yTjr2iwpiS4lfMWYXdDur6BP/x9Ws+bMgo= X-Google-Smtp-Source: ABdhPJwL0Wch/MCgaFA2pHVXY7Wray9aHN2M1G8UX1UsXIi++pmGIpWzcXzB2aZuIsasVQ5+j4vDpONGvk4TdIQi6t0= X-Received: by 2002:a17:902:c808:b029:e6:4204:f62f with SMTP id u8-20020a170902c808b02900e64204f62fmr692632plx.0.1615221561612; Mon, 08 Mar 2021 08:39:21 -0800 (PST) MIME-Version: 1.0 References: <20210218052654.28995-1-calvin.johnson@oss.nxp.com> <20210218052654.28995-11-calvin.johnson@oss.nxp.com> <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> <20210308162811.GB2740@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210308162811.GB2740@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Mon, 8 Mar 2021 18:39:04 +0200 Message-ID: Subject: Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Linux Kernel Mailing List , netdev , ACPI Devel Maling List , Laurentiu Tudor , Diana Madalina Craciun , linux-arm Mailing List , "linux.cj" , "David S. Miller" , Heiner Kallweit , Jakub Kicinski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_163923_541735_800C79ED X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 8, 2021 at 6:28 PM Calvin Johnson wrote: > On Mon, Mar 08, 2021 at 04:57:35PM +0200, Andy Shevchenko wrote: .... > I thought of including device.h instead of dev_printk.h because, it is the > only file that includes dev_printk.h and device.h is widely used. Of course, > it will mean that dev_printk.h is indirectly called. The split happened recently, not every developer knows about it and definitely most of the contributors are too lazy to properly write the inclusion block in their code. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel