From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3C0C19F2C for ; Wed, 3 Aug 2022 11:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237478AbiHCLdA (ORCPT ); Wed, 3 Aug 2022 07:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237482AbiHCLcz (ORCPT ); Wed, 3 Aug 2022 07:32:55 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 420753D595; Wed, 3 Aug 2022 04:32:54 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id dc19so8202908ejb.12; Wed, 03 Aug 2022 04:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=9eJR3E7r7PDYrwPyZgyOXsCTuvoCZ7sVt4yoqxYJPX4=; b=o+b6PdvDZDHi+nrpABUNjbp4ZVQx6du6ZHu9GoXgPmUTTrA/+kwnw8G5mBplzCN0C7 ZIetmXEoNJfVr2FN7EwJjlYcRN6NNSEVk9xNLVbxKyAvdd4I+qf6X3CGa/KI1U0gzKpn ujQW5ZuCvqVsOz+IgiQdiIwg74oVc/j9WVb1L1B+Of/Mv+ZkthKmcULTU4gCmr3MfMKh nGFhdpSVwWZ57YnHrXpQSuoEZGoJ50GC2wKXtRhkMXYj3CTaWLN9n6DU5IuaBXfY1GCt 7PZu4AQS3JxFrqrgxJWDI4+dPT5uEQe5AYxlpcmNXzE7wKyeqTyp3SPdQrrkvy064Fai 8Q3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=9eJR3E7r7PDYrwPyZgyOXsCTuvoCZ7sVt4yoqxYJPX4=; b=2yt/rSvUttWHi1zKC7Gj9KG+uFMRK1QCuRp56OXU9KA/a6t+Gtxi2R6YnPY7KXKYxf Tb1mpGQ5ss9Eminxg1TpcPP+6g0UHPPh5LtqFYggD5LDyHgPd4wousFF0D4nhh+Da5Ww IGr/G1l/ire2BoSdb8ynxmQyWFe+SmgUQI7FMVCBC/KVQvBEJhhPAh8rMB7eqvsAV9My jRNn+x10iMjBnPtVR0PlafdeQhSalAy3zF+KtAaeAiD+6F7Pi2ISAwa0g/XM/tSNmn7C ALyWjDqMR56K/r1lbAgascnqZ7IK80o98Ev7lNpL6l7UV5aTCTX0yhv72Gr6MozrIahq yoUA== X-Gm-Message-State: AJIora+HenZEtkNCUGUUcfPi5SHjfi6adDxpei16UVWRggXdNnoY/Csj 8K5JOtDhwk0+a1VtlcUGY2HSZyWMoTL70PqTpPI= X-Google-Smtp-Source: AGRyM1uQNT2sLEmn+47hvcwdSagVjYBFsLCmTzLrhiz4Zx2S8Lc2gPvuaO7WU6VMLuHwWblWK12jxjfziNzhVGYgVwk= X-Received: by 2002:a17:907:28d6:b0:72b:7497:76b with SMTP id en22-20020a17090728d600b0072b7497076bmr19322425ejc.365.1659526372574; Wed, 03 Aug 2022 04:32:52 -0700 (PDT) MIME-Version: 1.0 References: <20220803054728.1541104-1-colin.foster@in-advantage.com> <20220803054728.1541104-5-colin.foster@in-advantage.com> In-Reply-To: <20220803054728.1541104-5-colin.foster@in-advantage.com> From: Andy Shevchenko Date: Wed, 3 Aug 2022 13:32:15 +0200 Message-ID: Subject: Re: [PATCH v15 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration To: Colin Foster Cc: linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , netdev , Linux Kernel Mailing List , devicetree , Terry Bowman , Vladimir Oltean , Wolfram Sang , Microchip Linux Driver Support , Steen Hegelund , Lars Povlsen , Linus Walleij , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Krzysztof Kozlowski , Rob Herring , Lee Jones , katie.morris@in-advantage.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Aug 3, 2022 at 7:47 AM Colin Foster wrote: > > There are a few Ocelot chips that contain pinctrl logic, but can be > controlled externally. Specifically the VSC7511, 7512, 7513 and 7514. In > the externally controlled configurations these registers are not > memory-mapped. > > Add support for these non-memory-mapped configurations. FWIW, Reviewed-by: Andy Shevchenko > Signed-off-by: Colin Foster > Reviewed-by: Vladimir Oltean > Acked-by: Linus Walleij > --- > > (No changes since v14) > > v14 > * Add Reviewed and Acked tags > > --- > drivers/pinctrl/pinctrl-ocelot.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c > index d18047d2306d..80a3bba520cb 100644 > --- a/drivers/pinctrl/pinctrl-ocelot.c > +++ b/drivers/pinctrl/pinctrl-ocelot.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1918,7 +1919,6 @@ static int ocelot_pinctrl_probe(struct platform_device *pdev) > struct ocelot_pinctrl *info; > struct reset_control *reset; > struct regmap *pincfg; > - void __iomem *base; > int ret; > struct regmap_config regmap_config = { > .reg_bits = 32, > @@ -1938,20 +1938,14 @@ static int ocelot_pinctrl_probe(struct platform_device *pdev) > "Failed to get reset\n"); > reset_control_reset(reset); > > - base = devm_ioremap_resource(dev, > - platform_get_resource(pdev, IORESOURCE_MEM, 0)); > - if (IS_ERR(base)) > - return PTR_ERR(base); > - > info->stride = 1 + (info->desc->npins - 1) / 32; > > regmap_config.max_register = OCELOT_GPIO_SD_MAP * info->stride + 15 * 4; > > - info->map = devm_regmap_init_mmio(dev, base, ®map_config); > - if (IS_ERR(info->map)) { > - dev_err(dev, "Failed to create regmap\n"); > - return PTR_ERR(info->map); > - } > + info->map = ocelot_regmap_from_resource(pdev, 0, ®map_config); > + if (IS_ERR(info->map)) > + return dev_err_probe(dev, PTR_ERR(info->map), > + "Failed to create regmap\n"); > dev_set_drvdata(dev, info->map); > info->dev = dev; > > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 208CCC19F28 for ; Wed, 3 Aug 2022 11:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rvw7drTrIaZ6s1IBpMHSx1DL3+ZLd+B5RQR8sb5XBkM=; b=n2AM0nwOgjTGTz fIy+7evzGhDQikIELeUKsoANjgLLgTDyg6gUQCgzFKsvSzmkoQR2R78nyNZFg2t/AnsT9tqdgBIxf spjltE9ATq9NT+epYFJD9VjhTrwYAERV3AVQaeVC2ctzk4gRDXLGkOo4ttmz+Sbjwyj+oqD+dmliz YCx8sTbK6zh05lFzOvPFqhQzJg5a2uxXn9JCpB8wwXEpzu7yRV83NBsHsSEmgKj+3ec1BFeQMQLHQ yXvCRbxJdQqGbuw+Xm8uZvRP9cCYv/QHiKPBdwDL5yRYnZQVauSzIoPNHFSDtCBBdV2PlrOMOIFMP 1pPHaxMHjFQgGmTTyLEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCd2-005OGO-Sf; Wed, 03 Aug 2022 11:33:33 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCcS-005Nrc-Hl for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2022 11:33:00 +0000 Received: by mail-ej1-x62b.google.com with SMTP id m4so9120111ejr.3 for ; Wed, 03 Aug 2022 04:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=9eJR3E7r7PDYrwPyZgyOXsCTuvoCZ7sVt4yoqxYJPX4=; b=o+b6PdvDZDHi+nrpABUNjbp4ZVQx6du6ZHu9GoXgPmUTTrA/+kwnw8G5mBplzCN0C7 ZIetmXEoNJfVr2FN7EwJjlYcRN6NNSEVk9xNLVbxKyAvdd4I+qf6X3CGa/KI1U0gzKpn ujQW5ZuCvqVsOz+IgiQdiIwg74oVc/j9WVb1L1B+Of/Mv+ZkthKmcULTU4gCmr3MfMKh nGFhdpSVwWZ57YnHrXpQSuoEZGoJ50GC2wKXtRhkMXYj3CTaWLN9n6DU5IuaBXfY1GCt 7PZu4AQS3JxFrqrgxJWDI4+dPT5uEQe5AYxlpcmNXzE7wKyeqTyp3SPdQrrkvy064Fai 8Q3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=9eJR3E7r7PDYrwPyZgyOXsCTuvoCZ7sVt4yoqxYJPX4=; b=pVRKVVaXY+vPXL4LWnMBOZbJhws8V6xT/zjB9K5ScljT9pUSEY8ZyONZKYz8Fo6ccY 6D12BfhqH0QDoGD1agrlASgzWzcdTu0RAnn4gapFeMbph5rCNIjNXreMvfUIOyEXDFL0 ild4QQO69E/8LquW6ztHDP8ooXA6OjOs23wBsA3Csghkrizc7FAZdDQGP+69eIDXVrJ9 MH2/FIFKXLhIxnaLg4zXf4UDIGU+E1Tv1KOXrSXvi4nv9qByjNp7ChSuaX2ZM7dwU4GH QbtOgBQFKudBaYzFyjpmmh42BarrkqDwpTESKIOS4mmhbKq7tSDv8T+hlpOnfPO/glRG 1+Mg== X-Gm-Message-State: AJIora/Eq2imYylupESSmPqj5b1h16km1x9dAzPykHzb7XWj2U6Z0glo 1leTgVP5pr87PxP6AQt3JsGE//+n0PM5X5AeuNE= X-Google-Smtp-Source: AGRyM1uQNT2sLEmn+47hvcwdSagVjYBFsLCmTzLrhiz4Zx2S8Lc2gPvuaO7WU6VMLuHwWblWK12jxjfziNzhVGYgVwk= X-Received: by 2002:a17:907:28d6:b0:72b:7497:76b with SMTP id en22-20020a17090728d600b0072b7497076bmr19322425ejc.365.1659526372574; Wed, 03 Aug 2022 04:32:52 -0700 (PDT) MIME-Version: 1.0 References: <20220803054728.1541104-1-colin.foster@in-advantage.com> <20220803054728.1541104-5-colin.foster@in-advantage.com> In-Reply-To: <20220803054728.1541104-5-colin.foster@in-advantage.com> From: Andy Shevchenko Date: Wed, 3 Aug 2022 13:32:15 +0200 Message-ID: Subject: Re: [PATCH v15 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration To: Colin Foster Cc: linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , netdev , Linux Kernel Mailing List , devicetree , Terry Bowman , Vladimir Oltean , Wolfram Sang , Microchip Linux Driver Support , Steen Hegelund , Lars Povlsen , Linus Walleij , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Krzysztof Kozlowski , Rob Herring , Lee Jones , katie.morris@in-advantage.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_043256_663007_96674152 X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 3, 2022 at 7:47 AM Colin Foster wrote: > > There are a few Ocelot chips that contain pinctrl logic, but can be > controlled externally. Specifically the VSC7511, 7512, 7513 and 7514. In > the externally controlled configurations these registers are not > memory-mapped. > > Add support for these non-memory-mapped configurations. FWIW, Reviewed-by: Andy Shevchenko > Signed-off-by: Colin Foster > Reviewed-by: Vladimir Oltean > Acked-by: Linus Walleij > --- > > (No changes since v14) > > v14 > * Add Reviewed and Acked tags > > --- > drivers/pinctrl/pinctrl-ocelot.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c > index d18047d2306d..80a3bba520cb 100644 > --- a/drivers/pinctrl/pinctrl-ocelot.c > +++ b/drivers/pinctrl/pinctrl-ocelot.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1918,7 +1919,6 @@ static int ocelot_pinctrl_probe(struct platform_device *pdev) > struct ocelot_pinctrl *info; > struct reset_control *reset; > struct regmap *pincfg; > - void __iomem *base; > int ret; > struct regmap_config regmap_config = { > .reg_bits = 32, > @@ -1938,20 +1938,14 @@ static int ocelot_pinctrl_probe(struct platform_device *pdev) > "Failed to get reset\n"); > reset_control_reset(reset); > > - base = devm_ioremap_resource(dev, > - platform_get_resource(pdev, IORESOURCE_MEM, 0)); > - if (IS_ERR(base)) > - return PTR_ERR(base); > - > info->stride = 1 + (info->desc->npins - 1) / 32; > > regmap_config.max_register = OCELOT_GPIO_SD_MAP * info->stride + 15 * 4; > > - info->map = devm_regmap_init_mmio(dev, base, ®map_config); > - if (IS_ERR(info->map)) { > - dev_err(dev, "Failed to create regmap\n"); > - return PTR_ERR(info->map); > - } > + info->map = ocelot_regmap_from_resource(pdev, 0, ®map_config); > + if (IS_ERR(info->map)) > + return dev_err_probe(dev, PTR_ERR(info->map), > + "Failed to create regmap\n"); > dev_set_drvdata(dev, info->map); > info->dev = dev; > > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel