All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
	"David S . Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	ldv-project@linuxtesting.org
Subject: Re: [PATCH net-next v2] wan: dscc4: add checks for dma mapping errors
Date: Wed, 9 Aug 2017 13:45:48 +0300	[thread overview]
Message-ID: <CAHp75VfAs8Bt2=qgN-foeTk7U+Y5WFFfm4bf4fWPk7kpLOU2Tg@mail.gmail.com> (raw)
In-Reply-To: <1502220499-18351-1-git-send-email-khoroshilov@ispras.ru>

On Tue, Aug 8, 2017 at 10:28 PM, Alexey Khoroshilov
<khoroshilov@ispras.ru> wrote:
> The driver does not check if mapping dma memory succeed.
> The patch adds the checks and failure handling.
>
> Found by Linux Driver Verification project (linuxtesting.org).

Since it is going to be v3, just to mention that IIRC we better not to
use PCI DMA mapping API in favour of generic DMA mapping API.
Can you please double check this?


-- 
With Best Regards,
Andy Shevchenko

      parent reply	other threads:[~2017-08-09 10:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 20:23 [PATCH] wan: dscc4: add checks for dma mapping errors Alexey Khoroshilov
2017-08-07 21:06 ` David Miller
2017-08-07 21:59 ` Francois Romieu
2017-08-08 19:28   ` [PATCH net-next v2] " Alexey Khoroshilov
2017-08-08 23:21     ` Francois Romieu
2017-08-10 22:55       ` [PATCH v3 net-next 1/2] " Alexey Khoroshilov
2017-08-10 22:55         ` [PATCH v3 net-next 2/2] wan: dscc4: convert to plain DMA API Alexey Khoroshilov
2017-08-11 21:42           ` David Miller
2017-08-11 21:45           ` Francois Romieu
2017-08-11 21:49             ` David Miller
2017-08-11 23:32               ` Francois Romieu
2017-08-11 21:42         ` [PATCH v3 net-next 1/2] wan: dscc4: add checks for dma mapping errors David Miller
2017-08-09 10:45     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VfAs8Bt2=qgN-foeTk7U+Y5WFFfm4bf4fWPk7kpLOU2Tg@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=davem@davemloft.net \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.