From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D3AECAAD3 for ; Mon, 5 Sep 2022 10:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237845AbiIEKy6 (ORCPT ); Mon, 5 Sep 2022 06:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237965AbiIEKyr (ORCPT ); Mon, 5 Sep 2022 06:54:47 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3139118E1D; Mon, 5 Sep 2022 03:54:38 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id u5so1840287qvv.3; Mon, 05 Sep 2022 03:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=BT3xLpeH3RjbxWQzTHtluGWFLcpz2c3gkUTiSpzfoPpU7gaIO6czvS8W4reMZ4cCO4 3eMf/g+K3UKbJS6Jk0JxrWeNOy6+42NuOyskDMGWojnEiJoNCccaKDrBXpafZBuULjuW dYcA7PiA983MMDKcYZKgKx3pSqByFVARqZpiSeVPU2Zd8gAbIKhjyD904CbNMtAzjOUC uG1HJFkRMuzcZrZpIhoUBQgxwknWCtImNXXD19IvU58Ts2K5UQm4oyao9nlr1q38XCd5 l4cO9hdybc4SBkJmevuxR16Y4XsOdXf+9PHct3p0BX/cs/X4ebLeTYqHTloP7bvoOCLm luuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=kmi0d39df4dc/Shr2iEEyzWx00+hupGAE/iIIwCNnbW+EbPR08zbuQybW+P6It0YIF hyd4UVRGo24295w6EGJtII1ZCpXJ/uOG9xgbqqnJbwHcnAXoFfmjjsvzbczBYTelThob Kl1yCOm0MQ0+i4hGWpy2EChNTaq3+ex0JzRyT3PFVUfRI/C6CvGhbEhclCrgJW15ZcBh o3chJnAHhAvqAnj3sL3C3eMCGQEZikaMHHxguK2AVPUYlip8J6ea+EKbN93JwSF7ruv5 enExdjXvYB03yR9GTiEgYOWeL1Z9EeMF7GdG0baVh/lOO+6Yrf1RzB4ctlGa5GWNc+tb UW/g== X-Gm-Message-State: ACgBeo2lc9Jf9EALtdoDsrTlkjxQCHgwGh47ele3OOUF77s7br9htLVj vY/EmTuOsY5Ub+KiVdC9igP/Tj15ev21tyTY6b4= X-Google-Smtp-Source: AA6agR5qY7QHGswD32uCDWcX3OPsA9Qr7QwZIbiYbOgQNRx+s2EA487X6YBau9sHW1SCIA7Zbx5vkCR0pqATT7Z+4Es= X-Received: by 2002:ad4:5f8f:0:b0:4a9:b75a:e33c with SMTP id jp15-20020ad45f8f000000b004a9b75ae33cmr757802qvb.82.1662375277275; Mon, 05 Sep 2022 03:54:37 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-1-b29adfb27a6c@gmail.com> <20220905071902.fv4uozrsttk3mosu@pali> In-Reply-To: From: Andy Shevchenko Date: Mon, 5 Sep 2022 13:54:00 +0300 Message-ID: Subject: Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Dmitry Torokhov , Thierry Reding , Mark Brown , Matti Vaittinen , Lorenzo Pieralisi , Claudiu Beznea , Liam Girdwood , Wim Van Sebroeck , Greg Kroah-Hartman , Guenter Roeck , Miquel Raynal , Linus Walleij , Felipe Balbi , Alexandre Belloni , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Vignesh Raghavendra , Daniel Vetter , Thomas Petazzoni , Alexandre Torgue , Marc Zyngier , Richard Weinberger , David Airlie , Nicolas Ferre , Alyssa Rosenzweig , Bartosz Golaszewski , Jonathan Hunter , Rob Herring , Maxime Coquelin , Bjorn Helgaas , LINUXWATCHDOG , USB , "open list:GPIO SUBSYSTEM" , linux-pci , linux-tegra , "open list:MEMORY TECHNOLOGY..." , Linux Kernel Mailing List , dri-devel , linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Sep 5, 2022 at 1:49 PM Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 10:23 AM Pali Roh=C3=A1r wrote: > > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > ... > > > > - rp->reset_gpio =3D devm_gpiod_get_from_of_node(dev, por= t, > > > - "reset-gpi= os", 0, > > > - GPIOD_OUT_= LOW, > > > - label); > > > + rp->reset_gpio =3D devm_fwnode_gpiod_get(dev, > > > + of_fwnode_handle= (port), > > > + "reset", > > > + GPIOD_OUT_LOW, > > > + label); > > > > Why in pci-aardvark.c for PERST# reset-gpio you have used > > devm_gpiod_get_optional() and here in pci-tegra.c you have used > > devm_fwnode_gpiod_get()? I think that PERST# logic is same in both > > drivers. > > It's not the same dev and its node in this case. There is one reset > for _all_ ports, here is the reset on _per port_ basis. Actually I'm wrong, the aardvark has only one port (?) to serve there. In any case, here dev =3D=3D dev->of_node, here dev !=3D port. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 332CFECAAD5 for ; Mon, 5 Sep 2022 10:54:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 65CF810E28E; Mon, 5 Sep 2022 10:54:43 +0000 (UTC) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D47D10E28E for ; Mon, 5 Sep 2022 10:54:38 +0000 (UTC) Received: by mail-qv1-xf32.google.com with SMTP id c6so3806510qvn.6 for ; Mon, 05 Sep 2022 03:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=BT3xLpeH3RjbxWQzTHtluGWFLcpz2c3gkUTiSpzfoPpU7gaIO6czvS8W4reMZ4cCO4 3eMf/g+K3UKbJS6Jk0JxrWeNOy6+42NuOyskDMGWojnEiJoNCccaKDrBXpafZBuULjuW dYcA7PiA983MMDKcYZKgKx3pSqByFVARqZpiSeVPU2Zd8gAbIKhjyD904CbNMtAzjOUC uG1HJFkRMuzcZrZpIhoUBQgxwknWCtImNXXD19IvU58Ts2K5UQm4oyao9nlr1q38XCd5 l4cO9hdybc4SBkJmevuxR16Y4XsOdXf+9PHct3p0BX/cs/X4ebLeTYqHTloP7bvoOCLm luuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=UVdd5rtPmdHsvgjibrW/lPNanlKg2fHL5B+2ltxm8RH+vsBtA+G0qfmd/T66yMq+JS 2da+ueWlgnuJjdAp88vFPL9nMnKbkM8FPYoU8gNDQOjZf64F2KqyvMR7eP1eWNiNyOWC W6o5uLe4OMAostlqKEo1UUQWxi6ye8lynsc6pKN8BMDrnmzNVAxMnHzlPMbaoaEGycKT hc7un83WXUoLkyTsDwQXyFuII+3bvDE1+QRAH8znS+X5H/AVr2laKSfqxqzUvdkWLezv t6GGe+eVAbDzl6QvEupJVKIN+0dqD0Dq2jUdpkRrMrBluQV8AWdktg6P+rwLRUyF7IEi p0eQ== X-Gm-Message-State: ACgBeo0LkuhUTNS69ts8flibcdH3sDlye+bKHsRqCB+LWPj+Lkhg3d9i idzEwJHU5urEHg55r5ahmAR6xwy8GfCqUn105yA= X-Google-Smtp-Source: AA6agR5qY7QHGswD32uCDWcX3OPsA9Qr7QwZIbiYbOgQNRx+s2EA487X6YBau9sHW1SCIA7Zbx5vkCR0pqATT7Z+4Es= X-Received: by 2002:ad4:5f8f:0:b0:4a9:b75a:e33c with SMTP id jp15-20020ad45f8f000000b004a9b75ae33cmr757802qvb.82.1662375277275; Mon, 05 Sep 2022 03:54:37 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-1-b29adfb27a6c@gmail.com> <20220905071902.fv4uozrsttk3mosu@pali> In-Reply-To: From: Andy Shevchenko Date: Mon, 5 Sep 2022 13:54:00 +0300 Message-ID: Subject: Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Alexandre Belloni , USB , Vignesh Raghavendra , David Airlie , linux-pci , Alexandre Torgue , dri-devel , Nicolas Ferre , linux-tegra , Thierry Reding , "open list:MEMORY TECHNOLOGY..." , Thomas Petazzoni , Miquel Raynal , linux-stm32@st-md-mailman.stormreply.com, Alyssa Rosenzweig , LINUXWATCHDOG , Marc Zyngier , Bartosz Golaszewski , Jonathan Hunter , Lorenzo Pieralisi , Guenter Roeck , Maxime Coquelin , Matti Vaittinen , "open list:GPIO SUBSYSTEM" , Mark Brown , Bjorn Helgaas , Wim Van Sebroeck , linux-arm Mailing List , Felipe Balbi , Greg Kroah-Hartman , Dmitry Torokhov , Liam Girdwood , Linux Kernel Mailing List , Richard Weinberger , Claudiu Beznea Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Sep 5, 2022 at 1:49 PM Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 10:23 AM Pali Roh=C3=A1r wrote: > > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > ... > > > > - rp->reset_gpio =3D devm_gpiod_get_from_of_node(dev, por= t, > > > - "reset-gpi= os", 0, > > > - GPIOD_OUT_= LOW, > > > - label); > > > + rp->reset_gpio =3D devm_fwnode_gpiod_get(dev, > > > + of_fwnode_handle= (port), > > > + "reset", > > > + GPIOD_OUT_LOW, > > > + label); > > > > Why in pci-aardvark.c for PERST# reset-gpio you have used > > devm_gpiod_get_optional() and here in pci-tegra.c you have used > > devm_fwnode_gpiod_get()? I think that PERST# logic is same in both > > drivers. > > It's not the same dev and its node in this case. There is one reset > for _all_ ports, here is the reset on _per port_ basis. Actually I'm wrong, the aardvark has only one port (?) to serve there. In any case, here dev =3D=3D dev->of_node, here dev !=3D port. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9C5AECAAD5 for ; Mon, 5 Sep 2022 14:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ar5kvoAuh2nqOY470B3AlAR+/aop6573RItezGhYE9k=; b=cbmR839IEvETl9 9DT+CqZLArI/4gsZGzjisHkRNkNhPCoil6Io0GTq8WS2ZN5CQO2qNaRyCXxmijlQK9R4PL8K58bYt 32VWLrzUN5xQflpKJrWbEJPU5ogkMUvKkTmmpBLnnMbBri96UTU4ghGxjjVOhMoh18gwuIczgQZPr mCioSjOPrvDMz4S/t8z1R43rkYqVcM52r2q3cK8xKWX82bVJmztDahk2bV+hgLyesE0AwRRJmlIqW ZMevUH2Hczr3LZuHy1slLTP+HQnIRFx2TwrUuqLeqMoNnJPksbznl9Ea4vNZXorv7EhqyntYpYIoF 70V1WQhjqe8YPMArDDPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVCt2-004Gc5-Bn; Mon, 05 Sep 2022 14:15:40 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVA0L-000vM7-HH; Mon, 05 Sep 2022 11:11:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version: Sender:Reply-To:Content-ID:Content-Description; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=Pd7VmL7M1Wn7B4QGCjWUi+lgHN h0gMQKwqiVeR4WMM8tZouXE+irVD3CxgdVt2dtbHi4bCaeotK/LxtART3GYE+qQUzyWxKcYHCcmc1 GH9/i3vYZi3L7JMKgEpegynfhp3HLyhVlaCpF0DQ7cJhlTnI5yiKIe1wUFPGLx2Oz6uItdRQ70QPW fZUiyt8JQ/I+nhErtVixzQQSr48VqqHjTzrdU9YiEQzHWZbpeavufUvSaS7/4C16lcDQ5KwrZLfZA wFh3stLiNv5KASuzCTczuMZntcb8QuK6ToaaqGPLnP2KdjMUVZM9RoTe/HCvFH8x0f++Y0+rpxh84 HYtEHXAg==; Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV9kV-009YBj-7f; Mon, 05 Sep 2022 10:54:41 +0000 Received: by mail-qv1-xf30.google.com with SMTP id v15so3417350qvi.11; Mon, 05 Sep 2022 03:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=BT3xLpeH3RjbxWQzTHtluGWFLcpz2c3gkUTiSpzfoPpU7gaIO6czvS8W4reMZ4cCO4 3eMf/g+K3UKbJS6Jk0JxrWeNOy6+42NuOyskDMGWojnEiJoNCccaKDrBXpafZBuULjuW dYcA7PiA983MMDKcYZKgKx3pSqByFVARqZpiSeVPU2Zd8gAbIKhjyD904CbNMtAzjOUC uG1HJFkRMuzcZrZpIhoUBQgxwknWCtImNXXD19IvU58Ts2K5UQm4oyao9nlr1q38XCd5 l4cO9hdybc4SBkJmevuxR16Y4XsOdXf+9PHct3p0BX/cs/X4ebLeTYqHTloP7bvoOCLm luuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=GtYgAcjFDJO16HpoSjJVtrFB3JiOxH+0QLP3lDMfppqyU44Ysk3nRgePramo6BGbSM NJ/tnbNaxvXq/SXIlBGzeEjxzDqymUzR/E7CppEBCmLqLURbe4broxJNHfIa6po3XB5l Pkf+ftOsScAYJ9zf+0I1Imfm3ymcGQ2u+MpiisKn59WKlrqdCI2rAf1ON6OGOUTdnyTt xuTNT8UevQJmqzYHaaEOxT0Z5IaKxJEU3hpSyOiOUfJrgS6aGEdMFSYBuY0jyTN6uN0D W+PbEkas+fNH/95FSKpy/YoAmQCpsaG+4KtsdQJC0I6xoajs/8GNaFvMzv/Pkw7bRS4v ZSKA== X-Gm-Message-State: ACgBeo1+gEyoB3r5Sgc/3cB06p1GH035H6w05HBQntSrfqUTkFj/1nop K0vBg4SuPqWu4eAVtQwsQgbAgogNUCp2rquNgH8= X-Google-Smtp-Source: AA6agR5qY7QHGswD32uCDWcX3OPsA9Qr7QwZIbiYbOgQNRx+s2EA487X6YBau9sHW1SCIA7Zbx5vkCR0pqATT7Z+4Es= X-Received: by 2002:ad4:5f8f:0:b0:4a9:b75a:e33c with SMTP id jp15-20020ad45f8f000000b004a9b75ae33cmr757802qvb.82.1662375277275; Mon, 05 Sep 2022 03:54:37 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-1-b29adfb27a6c@gmail.com> <20220905071902.fv4uozrsttk3mosu@pali> In-Reply-To: From: Andy Shevchenko Date: Mon, 5 Sep 2022 13:54:00 +0300 Message-ID: Subject: Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Dmitry Torokhov , Thierry Reding , Mark Brown , Matti Vaittinen , Lorenzo Pieralisi , Claudiu Beznea , Liam Girdwood , Wim Van Sebroeck , Greg Kroah-Hartman , Guenter Roeck , Miquel Raynal , Linus Walleij , Felipe Balbi , Alexandre Belloni , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Vignesh Raghavendra , Daniel Vetter , Thomas Petazzoni , Alexandre Torgue , Marc Zyngier , Richard Weinberger , David Airlie , Nicolas Ferre , Alyssa Rosenzweig , Bartosz Golaszewski , Jonathan Hunter , Rob Herring , Maxime Coquelin , Bjorn Helgaas , LINUXWATCHDOG , USB , "open list:GPIO SUBSYSTEM" , linux-pci , linux-tegra , "open list:MEMORY TECHNOLOGY..." , Linux Kernel Mailing List , dri-devel , linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_115439_703084_65CFD124 X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgNSwgMjAyMiBhdCAxOjQ5IFBNIEFuZHkgU2hldmNoZW5rbwo8YW5keS5zaGV2 Y2hlbmtvQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBPbiBNb24sIFNlcCA1LCAyMDIyIGF0IDEwOjIz IEFNIFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gT24gU3VuZGF5IDA0 IFNlcHRlbWJlciAyMDIyIDIzOjMwOjUzIERtaXRyeSBUb3Jva2hvdiB3cm90ZToKPgo+IC4uLgo+ Cj4gPiA+IC0gICAgICAgICAgICAgcnAtPnJlc2V0X2dwaW8gPSBkZXZtX2dwaW9kX2dldF9mcm9t X29mX25vZGUoZGV2LCBwb3J0LAo+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJyZXNldC1ncGlvcyIsIDAsCj4gPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR1BJ T0RfT1VUX0xPVywKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBsYWJlbCk7Cj4gPiA+ICsgICAgICAgICAgICAgcnAtPnJlc2V0 X2dwaW8gPSBkZXZtX2Z3bm9kZV9ncGlvZF9nZXQoZGV2LAo+ID4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9mX2Z3bm9kZV9oYW5kbGUocG9y dCksCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgInJlc2V0IiwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBHUElPRF9PVVRfTE9XLAo+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxhYmVsKTsKPiA+Cj4gPiBXaHkgaW4g cGNpLWFhcmR2YXJrLmMgZm9yIFBFUlNUIyByZXNldC1ncGlvIHlvdSBoYXZlIHVzZWQKPiA+IGRl dm1fZ3Bpb2RfZ2V0X29wdGlvbmFsKCkgYW5kIGhlcmUgaW4gcGNpLXRlZ3JhLmMgeW91IGhhdmUg dXNlZAo+ID4gZGV2bV9md25vZGVfZ3Bpb2RfZ2V0KCk/IEkgdGhpbmsgdGhhdCBQRVJTVCMgbG9n aWMgaXMgc2FtZSBpbiBib3RoCj4gPiBkcml2ZXJzLgo+Cj4gSXQncyBub3QgdGhlIHNhbWUgZGV2 IGFuZCBpdHMgbm9kZSBpbiB0aGlzIGNhc2UuIFRoZXJlIGlzIG9uZSByZXNldAo+IGZvciBfYWxs XyBwb3J0cywgaGVyZSBpcyB0aGUgcmVzZXQgb24gX3BlciBwb3J0XyBiYXNpcy4KCkFjdHVhbGx5 IEknbSB3cm9uZywgdGhlIGFhcmR2YXJrIGhhcyBvbmx5IG9uZSBwb3J0ICg/KSB0byBzZXJ2ZSB0 aGVyZS4KSW4gYW55IGNhc2UsIGhlcmUgZGV2ID09IGRldi0+b2Zfbm9kZSwgaGVyZSBkZXYgIT0g cG9ydC4KCgotLSAKV2l0aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBk aXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A82E8ECAAD3 for ; Mon, 5 Sep 2022 14:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ljOVYzInWPyBc/YCITG/hiLeBbHBEZfP1As4QJD2uCQ=; b=qlFW4boPrBbu9g WW30dOQxt3CbkIe6oNGfrzhuyQswJXkImwkHfqt3x91EcmBLlFaibj6lO18FAFfL/91JbkpzNJbDR slWz81eKL15UZGUgivmK5xTzSyTJivKKlggGJvJtG85KD5IijPndDzrP9giFRdzLvNXd0PCrOYPpR NEh3iQ34DVo1toU2wMG4T9cqjhqBMZAURlUA5tosYTjo3SpHzSHq/a/ykx4/1hrxVGS9CFGLtGN6n lDRxM9ill6Zbyo3DUM2khWc7i/jDw8wP9/EmyhbjaqTfyOBsLOhuqjKJExyj71VTHm3zkcHHW8KLo 0tuV5PW9N3zwnvqg5Jgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVCtC-004GlZ-G6; Mon, 05 Sep 2022 14:15:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVA0L-000vM7-HH; Mon, 05 Sep 2022 11:11:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version: Sender:Reply-To:Content-ID:Content-Description; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=Pd7VmL7M1Wn7B4QGCjWUi+lgHN h0gMQKwqiVeR4WMM8tZouXE+irVD3CxgdVt2dtbHi4bCaeotK/LxtART3GYE+qQUzyWxKcYHCcmc1 GH9/i3vYZi3L7JMKgEpegynfhp3HLyhVlaCpF0DQ7cJhlTnI5yiKIe1wUFPGLx2Oz6uItdRQ70QPW fZUiyt8JQ/I+nhErtVixzQQSr48VqqHjTzrdU9YiEQzHWZbpeavufUvSaS7/4C16lcDQ5KwrZLfZA wFh3stLiNv5KASuzCTczuMZntcb8QuK6ToaaqGPLnP2KdjMUVZM9RoTe/HCvFH8x0f++Y0+rpxh84 HYtEHXAg==; Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV9kV-009YBj-7f; Mon, 05 Sep 2022 10:54:41 +0000 Received: by mail-qv1-xf30.google.com with SMTP id v15so3417350qvi.11; Mon, 05 Sep 2022 03:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=BT3xLpeH3RjbxWQzTHtluGWFLcpz2c3gkUTiSpzfoPpU7gaIO6czvS8W4reMZ4cCO4 3eMf/g+K3UKbJS6Jk0JxrWeNOy6+42NuOyskDMGWojnEiJoNCccaKDrBXpafZBuULjuW dYcA7PiA983MMDKcYZKgKx3pSqByFVARqZpiSeVPU2Zd8gAbIKhjyD904CbNMtAzjOUC uG1HJFkRMuzcZrZpIhoUBQgxwknWCtImNXXD19IvU58Ts2K5UQm4oyao9nlr1q38XCd5 l4cO9hdybc4SBkJmevuxR16Y4XsOdXf+9PHct3p0BX/cs/X4ebLeTYqHTloP7bvoOCLm luuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Kl0QJJuFrqWw0yrcvdhKbmcA1hZ+nxHWOs1loNonK4k=; b=GtYgAcjFDJO16HpoSjJVtrFB3JiOxH+0QLP3lDMfppqyU44Ysk3nRgePramo6BGbSM NJ/tnbNaxvXq/SXIlBGzeEjxzDqymUzR/E7CppEBCmLqLURbe4broxJNHfIa6po3XB5l Pkf+ftOsScAYJ9zf+0I1Imfm3ymcGQ2u+MpiisKn59WKlrqdCI2rAf1ON6OGOUTdnyTt xuTNT8UevQJmqzYHaaEOxT0Z5IaKxJEU3hpSyOiOUfJrgS6aGEdMFSYBuY0jyTN6uN0D W+PbEkas+fNH/95FSKpy/YoAmQCpsaG+4KtsdQJC0I6xoajs/8GNaFvMzv/Pkw7bRS4v ZSKA== X-Gm-Message-State: ACgBeo1+gEyoB3r5Sgc/3cB06p1GH035H6w05HBQntSrfqUTkFj/1nop K0vBg4SuPqWu4eAVtQwsQgbAgogNUCp2rquNgH8= X-Google-Smtp-Source: AA6agR5qY7QHGswD32uCDWcX3OPsA9Qr7QwZIbiYbOgQNRx+s2EA487X6YBau9sHW1SCIA7Zbx5vkCR0pqATT7Z+4Es= X-Received: by 2002:ad4:5f8f:0:b0:4a9:b75a:e33c with SMTP id jp15-20020ad45f8f000000b004a9b75ae33cmr757802qvb.82.1662375277275; Mon, 05 Sep 2022 03:54:37 -0700 (PDT) MIME-Version: 1.0 References: <20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com> <20220903-gpiod_get_from_of_node-remove-v1-1-b29adfb27a6c@gmail.com> <20220905071902.fv4uozrsttk3mosu@pali> In-Reply-To: From: Andy Shevchenko Date: Mon, 5 Sep 2022 13:54:00 +0300 Message-ID: Subject: Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get To: =?UTF-8?Q?Pali_Roh=C3=A1r?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_115439_703084_65CFD124 X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Alexandre Belloni , USB , Vignesh Raghavendra , David Airlie , linux-pci , Linus Walleij , Alexandre Torgue , dri-devel , linux-tegra , Thierry Reding , "open list:MEMORY TECHNOLOGY..." , Thomas Petazzoni , Miquel Raynal , linux-stm32@st-md-mailman.stormreply.com, Alyssa Rosenzweig , LINUXWATCHDOG , Rob Herring , Marc Zyngier , Bartosz Golaszewski , Jonathan Hunter , Lorenzo Pieralisi , Guenter Roeck , Maxime Coquelin , Matti Vaittinen , "open list:GPIO SUBSYSTEM" , Mark Brown , Bjorn Helgaas , Wim Van Sebroeck , linux-arm Mailing List , Felipe Balbi , Greg Kroah-Hartman , Dmitry Torokhov , Liam Girdwood , Linux Kernel Mailing List , Daniel Vetter , Richard Weinberger , Claudiu Beznea Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgNSwgMjAyMiBhdCAxOjQ5IFBNIEFuZHkgU2hldmNoZW5rbwo8YW5keS5zaGV2 Y2hlbmtvQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBPbiBNb24sIFNlcCA1LCAyMDIyIGF0IDEwOjIz IEFNIFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gT24gU3VuZGF5IDA0 IFNlcHRlbWJlciAyMDIyIDIzOjMwOjUzIERtaXRyeSBUb3Jva2hvdiB3cm90ZToKPgo+IC4uLgo+ Cj4gPiA+IC0gICAgICAgICAgICAgcnAtPnJlc2V0X2dwaW8gPSBkZXZtX2dwaW9kX2dldF9mcm9t X29mX25vZGUoZGV2LCBwb3J0LAo+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJyZXNldC1ncGlvcyIsIDAsCj4gPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR1BJ T0RfT1VUX0xPVywKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBsYWJlbCk7Cj4gPiA+ICsgICAgICAgICAgICAgcnAtPnJlc2V0 X2dwaW8gPSBkZXZtX2Z3bm9kZV9ncGlvZF9nZXQoZGV2LAo+ID4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9mX2Z3bm9kZV9oYW5kbGUocG9y dCksCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgInJlc2V0IiwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBHUElPRF9PVVRfTE9XLAo+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxhYmVsKTsKPiA+Cj4gPiBXaHkgaW4g cGNpLWFhcmR2YXJrLmMgZm9yIFBFUlNUIyByZXNldC1ncGlvIHlvdSBoYXZlIHVzZWQKPiA+IGRl dm1fZ3Bpb2RfZ2V0X29wdGlvbmFsKCkgYW5kIGhlcmUgaW4gcGNpLXRlZ3JhLmMgeW91IGhhdmUg dXNlZAo+ID4gZGV2bV9md25vZGVfZ3Bpb2RfZ2V0KCk/IEkgdGhpbmsgdGhhdCBQRVJTVCMgbG9n aWMgaXMgc2FtZSBpbiBib3RoCj4gPiBkcml2ZXJzLgo+Cj4gSXQncyBub3QgdGhlIHNhbWUgZGV2 IGFuZCBpdHMgbm9kZSBpbiB0aGlzIGNhc2UuIFRoZXJlIGlzIG9uZSByZXNldAo+IGZvciBfYWxs XyBwb3J0cywgaGVyZSBpcyB0aGUgcmVzZXQgb24gX3BlciBwb3J0XyBiYXNpcy4KCkFjdHVhbGx5 IEknbSB3cm9uZywgdGhlIGFhcmR2YXJrIGhhcyBvbmx5IG9uZSBwb3J0ICg/KSB0byBzZXJ2ZSB0 aGVyZS4KSW4gYW55IGNhc2UsIGhlcmUgZGV2ID09IGRldi0+b2Zfbm9kZSwgaGVyZSBkZXYgIT0g cG9ydC4KCgotLSAKV2l0aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=