From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981DBC433FE for ; Thu, 23 Dec 2021 13:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348703AbhLWNwA (ORCPT ); Thu, 23 Dec 2021 08:52:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348462AbhLWNv7 (ORCPT ); Thu, 23 Dec 2021 08:51:59 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE753C061401; Thu, 23 Dec 2021 05:51:58 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id z29so21689987edl.7; Thu, 23 Dec 2021 05:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xnf5tg9xjHOiwQT7N7ZwvL+tTqg5m1BRJMGrP/gost0=; b=W1gHvUFoH7AC/jJSsUR+59BWEHjad338aw2rsUTO4hTo39kVOtEN5XRgqkmu5iHBTl xciVJzHMEsEyFwkI0Tp3YZjg4ec7aIYjlvnrOKR5hU1JXFUaFzsxeou6BPoUiYEZap+J Wwbf8mT41tWLCjbO/PdHIpqM+gaHLunukPSCKHcZsRU5hpZoqPXhmK1MltlwKFKNpSkW NDXQEdaGCeYIsl3ZrnOmL1ZuzLJxIj+P9YjrVDjWNNRFbeTb48shaffamYJARuWH3eVN lyAghmhiBSmX8wsNtpdvqGStGkQoPUKofYsT6jmSBMXGHpqNQh3+6oZZa4Qp5TyWuzv7 HO0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xnf5tg9xjHOiwQT7N7ZwvL+tTqg5m1BRJMGrP/gost0=; b=19Bq8w1HHXe8aG+NYZ0f5x0VrX0ibc0R/0+cQCUGCTwSBDzvwtTc8eb2dohe46guU7 W0JPAE/jk8O/KgzCo8RU34mLMdVJPXeGgL3fiyd7EAjMStkSVCgyYOTLXObiyWIzAzt2 YWhMN4zkYVrPBcsEi2/yl/V4YzetB1ZFE+HPqh3xzj9nk23UIDiQps72beyhCT65To90 itfCDtjz1VYkcwDiqVEfa+Quvt2yeQSB96Xc5mDjU9SJrxYgJnZkz5TUGVEuNDhS0KoD vuw/NLu3SYxbDfoREQR21LRPz9QgvENheGrVGfRRiusnVT2JCiltZlkEDUIpEqA3BO51 cemw== X-Gm-Message-State: AOAM531MpSVVvDuK3zv+sM8YRTYufyTtTzuX2XZqQYsVjpVHXGZPgQjy HXKSxhM+Ydi5X37jr2wbGTeDYcdzXAGS+sttBG0= X-Google-Smtp-Source: ABdhPJz+eA0P9hj70NkKVI2oJ5ZhiYaKQWne8/nJALPRVJKwOWxjRe+E1NYX8khEBzMr1jOLJieed7m/+AqpVzKp28E= X-Received: by 2002:a17:906:ced9:: with SMTP id si25mr2160700ejb.77.1640267517196; Thu, 23 Dec 2021 05:51:57 -0800 (PST) MIME-Version: 1.0 References: <20211202122021.43124-1-alistair@alistair23.me> <20211202122021.43124-2-alistair@alistair23.me> In-Reply-To: <20211202122021.43124-2-alistair@alistair23.me> From: Andy Shevchenko Date: Thu, 23 Dec 2021 15:49:59 +0200 Message-ID: Subject: Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen To: Alistair Francis Cc: Linux Kernel Mailing List , devicetree , linux-input , linux-arm Mailing List , Rob Herring , Andreas Kemnade , Alistair Francis , Dmitry Torokhov , Linus Walleij , Henrik Rydberg , =?UTF-8?Q?Myl=C3=A8ne_Josserand?= , Maxime Ripard Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 6, 2021 at 9:05 AM Alistair Francis wr= ote: > > From: Myl=C3=A8ne Josserand > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen > controllers. This driver supports only the I2C bus but it uses regmap > so SPI support could be added later. > The touchscreen can retrieve some defined zone that are handled as > buttons (according to the hardware). That is why it handles > button and multitouch events. Most of the comments I just gave against v2 are applicable here, please address them. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D846AC433F5 for ; Thu, 23 Dec 2021 13:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hXovvUhV0tmr0hPNJs7oxvjpwA+Fm3wxZNE6bECh2Ks=; b=KMV8D0cewdmd+x jWuRvNSCISC86/rcwLjy6lTZB70e9SQJAbpyv1MV/xgUr3YLFBFye3iSI8/uW4q+DLR16lEX5nDik 8eo+y8YU1l/iJoarH5G5xviZ+UWIP9H/8NtL8eeN+hK1X76jwIkF6RS3+uh3RqstXXMm6CsOQBXFR Tbs6Cd5zfvyuhap1cSv+8FzGZ7ovPmTEUmr4iRv+hWwg3KQhVKIvEx3HV6FqXVMqpHmybF2RroOJ4 cNr/fdFoWjTV01XuT6I6DjB298hbyNJn3/ElLMN03Afcz5NiamWanHLbBgriKJ6IHkbo+DN5Ss6se jxpq6+6we7ryzXiELLAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0OVm-00CqHA-Gj; Thu, 23 Dec 2021 13:52:02 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0OVk-00CqGW-04 for linux-arm-kernel@lists.infradead.org; Thu, 23 Dec 2021 13:52:01 +0000 Received: by mail-ed1-x533.google.com with SMTP id q14so14103241edi.3 for ; Thu, 23 Dec 2021 05:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xnf5tg9xjHOiwQT7N7ZwvL+tTqg5m1BRJMGrP/gost0=; b=W1gHvUFoH7AC/jJSsUR+59BWEHjad338aw2rsUTO4hTo39kVOtEN5XRgqkmu5iHBTl xciVJzHMEsEyFwkI0Tp3YZjg4ec7aIYjlvnrOKR5hU1JXFUaFzsxeou6BPoUiYEZap+J Wwbf8mT41tWLCjbO/PdHIpqM+gaHLunukPSCKHcZsRU5hpZoqPXhmK1MltlwKFKNpSkW NDXQEdaGCeYIsl3ZrnOmL1ZuzLJxIj+P9YjrVDjWNNRFbeTb48shaffamYJARuWH3eVN lyAghmhiBSmX8wsNtpdvqGStGkQoPUKofYsT6jmSBMXGHpqNQh3+6oZZa4Qp5TyWuzv7 HO0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xnf5tg9xjHOiwQT7N7ZwvL+tTqg5m1BRJMGrP/gost0=; b=S5HD8jEvlcpg6J2RLfuNQ33n5kn6xzlsXBFJE3uuoOzIca43YI1+FQlkHqSGZto35E P4Jtqvz8QxMHzZr/FiLq2jkqFCZERKI3uvcPzSJtF0GBvRqqWFRGbzBCUc822wikZIc6 3Prk4D1kfzFQjhUXoI7jm8T59iVYXN84SndbBmP0iBlkTs7N0BYmM0xgYBzQTvLxC86G 9ik/CWjoVX6Sy0UFB5DRy93mCffPwCMOcnf2T3KAVwzRLGkfxklgbgyXOdpbHc4ebbth z3z4EQXg1jyczPZJFFGXayzfh1S9e+vC8S7hCosUkPU9fMB2TunhklhC6jEALEW0qMZr siNw== X-Gm-Message-State: AOAM532FlrKMcEz8LaUOFcXM/wc+FWY5l7nQzftLoMS7IY/OSueunqhh BnFtE0TYQlU5tSmf0HR4xltC5/mqDmbH7ZwQMlk= X-Google-Smtp-Source: ABdhPJz+eA0P9hj70NkKVI2oJ5ZhiYaKQWne8/nJALPRVJKwOWxjRe+E1NYX8khEBzMr1jOLJieed7m/+AqpVzKp28E= X-Received: by 2002:a17:906:ced9:: with SMTP id si25mr2160700ejb.77.1640267517196; Thu, 23 Dec 2021 05:51:57 -0800 (PST) MIME-Version: 1.0 References: <20211202122021.43124-1-alistair@alistair23.me> <20211202122021.43124-2-alistair@alistair23.me> In-Reply-To: <20211202122021.43124-2-alistair@alistair23.me> From: Andy Shevchenko Date: Thu, 23 Dec 2021 15:49:59 +0200 Message-ID: Subject: Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen To: Alistair Francis Cc: Linux Kernel Mailing List , devicetree , linux-input , linux-arm Mailing List , Rob Herring , Andreas Kemnade , Alistair Francis , Dmitry Torokhov , Linus Walleij , Henrik Rydberg , =?UTF-8?Q?Myl=C3=A8ne_Josserand?= , Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211223_055200_056738_CAB9D6A6 X-CRM114-Status: GOOD ( 12.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBEZWMgNiwgMjAyMSBhdCA5OjA1IEFNIEFsaXN0YWlyIEZyYW5jaXMgPGFsaXN0YWly QGFsaXN0YWlyMjMubWU+IHdyb3RlOgo+Cj4gRnJvbTogTXlsw6huZSBKb3NzZXJhbmQgPG15bGVu ZS5qb3NzZXJhbmRAYm9vdGxpbi5jb20+Cj4KPiBUaGlzIGlzIHRoZSBiYXNpYyBkcml2ZXIgZm9y IHRoZSBDeXByZXNzIFRydWVUb3VjaCBHZW41IHRvdWNoc2NyZWVuCj4gY29udHJvbGxlcnMuIFRo aXMgZHJpdmVyIHN1cHBvcnRzIG9ubHkgdGhlIEkyQyBidXMgYnV0IGl0IHVzZXMgcmVnbWFwCj4g c28gU1BJIHN1cHBvcnQgY291bGQgYmUgYWRkZWQgbGF0ZXIuCj4gVGhlIHRvdWNoc2NyZWVuIGNh biByZXRyaWV2ZSBzb21lIGRlZmluZWQgem9uZSB0aGF0IGFyZSBoYW5kbGVkIGFzCj4gYnV0dG9u cyAoYWNjb3JkaW5nIHRvIHRoZSBoYXJkd2FyZSkuIFRoYXQgaXMgd2h5IGl0IGhhbmRsZXMKPiBi dXR0b24gYW5kIG11bHRpdG91Y2ggZXZlbnRzLgoKTW9zdCBvZiB0aGUgY29tbWVudHMgSSBqdXN0 IGdhdmUgYWdhaW5zdCB2MiBhcmUgYXBwbGljYWJsZSBoZXJlLApwbGVhc2UgYWRkcmVzcyB0aGVt LgoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK