From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA4FC2D0EE for ; Tue, 31 Mar 2020 13:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4103F206F5 for ; Tue, 31 Mar 2020 13:54:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dgw72UMD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731031AbgCaNyC (ORCPT ); Tue, 31 Mar 2020 09:54:02 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46307 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730216AbgCaNyC (ORCPT ); Tue, 31 Mar 2020 09:54:02 -0400 Received: by mail-pl1-f193.google.com with SMTP id s23so8132796plq.13; Tue, 31 Mar 2020 06:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eh6HoD2WSOyoYld2ZBtCaKD/ZdY+NnuzhftXLHQtZcw=; b=Dgw72UMDYMek1J2mctOS59XCDcB+nQhKYfiTsgobYLQQ/vLuKHZCFx0RPHCeMNyGbS Fi9isGEufr3h4mqnpBvzdn85v8BiVplFmzR5ZZcaj/wCP7Mfz2rzyWM6EF8hRUAii4Up y10n0nsI2JxhTh1CHtzZJ1lSTO4m9dX4FmyMqRfcZhqEJ+g2D2ELqMcwuuM+TAkrHO3A rwTi8VI6ODuCooHh5/C/tD9lNjEhUi2CaJKckqPOHtppSHh5u0iBrJ95thbEnn752HvZ EMq/d95XbBuGOuvENOO8q/iGoAhUQrvVcJaFnWgMqAbJ0lHgjZyYhnMABjdbMhdd/bd6 /pdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eh6HoD2WSOyoYld2ZBtCaKD/ZdY+NnuzhftXLHQtZcw=; b=cOp2W9tB+q1XZoUG8VlqgIu7StDXokxx8kW7WrLBwMBKjKXv+4PuJdwL4ETlz7mn11 oMBNqq24cZHRQSv0Q+qccirGtI/A8na10qHZXAskdBeAa0ou8aaeLjNEVUA7IzobXTjh jpwjzsTIprAuaIHUfTJwi3+p5bpflmfOA17eQjC2ITURTpP9j1SuRtFy/WypWZ/ystfw 1yPeV/msqspKRUF15NqzjID3mNfJCku+PsssHK+jrvlvTUTy6ntS5hmX/XCjYz9ROmL5 UKXk9CefS4EyMnN70lCsfxSQ1GwO/MHIDQaSeNfvcNitwLQL5m6T7mSDfqf3flaEtg4o W6aA== X-Gm-Message-State: AGi0PuaU4DCtiyMiBAP8Ogaj10ghiVxaT6pHEvzgwc4naY/wlMFsXHhD +qm7Cd/8yF+HHj4N5aQOi/zSygzTbqmVaSamWRk= X-Google-Smtp-Source: APiQypLYRrzWxZrlbpaHLCWWd1ElKKp5WQ8rvraTOsv33YWtdO90qCriipsZO40uAtIGauLg9nTUCvQqCtacCa2Id2s= X-Received: by 2002:a17:902:5acb:: with SMTP id g11mr4436095plm.18.1585662841043; Tue, 31 Mar 2020 06:54:01 -0700 (PDT) MIME-Version: 1.0 References: <20200313110350.10864-1-robert.foss@linaro.org> <20200313110350.10864-3-robert.foss@linaro.org> In-Reply-To: From: Andy Shevchenko Date: Tue, 31 Mar 2020 16:53:53 +0300 Message-ID: Subject: Re: [v2 2/3] media: ov8856: Add devicetree support To: Fabio Estevam Cc: Robert Foss , Dongchun Zhu , Andy Shevchenko , Sakari Ailus , Tomasz Figa , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2020 at 4:43 PM Fabio Estevam wrote: > On Tue, Mar 31, 2020 at 10:37 AM Robert Foss wrote: > > > After testing this change, it breaks the driver during probing. > > Why exactly does it break probing? Maybe the GPIO polarity defined in > the device tree is wrong? > > > I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they > > seem to never be 0 or 1. > > If you do a grep in all gpiod_set_value_cansleep() usages in the > kernel tree, there is not a single case where GPIOD_OUT_HIGH or > GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep(). +1. It simple reveals the problem that is somewhere else. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB94C43331 for ; Tue, 31 Mar 2020 15:39:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A4F020848 for ; Tue, 31 Mar 2020 15:39:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eJPN+32C"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dgw72UMD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A4F020848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jE7MFUU1Gq+1sGCCIRjeND3BmvmAmheuYAzPQB7+qBg=; b=eJPN+32CB1YQHf BzYszba98YBbPWUL93hhV1FQ4eYJI0bkxGJ+4a1WoKSsx8qmKpPaYt4gmzjZha5i3bfRAaqWpd57C vvJxNHVNN0NPQnOSi6sTi7BXdseaacumlqLJy/xok3YsTdj/8gsm8sLAh/GejfbA+/E+fjhPKw221 tQ6xG+OcPgeLkFl6puqQdWQYGA9+ksu+m5KRdBsxbHhXC9+NWylkpQtLp06xyofCvPTb4QPPQXCOh OH/B8M/mJtm3H7ODxNqG8Z0j5uAwTlMTqdlOokfgUt2SkL78w9Fgj5ZldPqtxGsaTzQOachK0d8M/ pkKW9oPLMU15os6QURsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJIyi-0004E7-Qd; Tue, 31 Mar 2020 15:39:00 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJIyf-0004DQ-Oh for linux-arm-kernel@lists.infradead.org; Tue, 31 Mar 2020 15:38:59 +0000 Received: by mail-pl1-x629.google.com with SMTP id g18so8273370plq.0 for ; Tue, 31 Mar 2020 08:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eh6HoD2WSOyoYld2ZBtCaKD/ZdY+NnuzhftXLHQtZcw=; b=Dgw72UMDYMek1J2mctOS59XCDcB+nQhKYfiTsgobYLQQ/vLuKHZCFx0RPHCeMNyGbS Fi9isGEufr3h4mqnpBvzdn85v8BiVplFmzR5ZZcaj/wCP7Mfz2rzyWM6EF8hRUAii4Up y10n0nsI2JxhTh1CHtzZJ1lSTO4m9dX4FmyMqRfcZhqEJ+g2D2ELqMcwuuM+TAkrHO3A rwTi8VI6ODuCooHh5/C/tD9lNjEhUi2CaJKckqPOHtppSHh5u0iBrJ95thbEnn752HvZ EMq/d95XbBuGOuvENOO8q/iGoAhUQrvVcJaFnWgMqAbJ0lHgjZyYhnMABjdbMhdd/bd6 /pdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eh6HoD2WSOyoYld2ZBtCaKD/ZdY+NnuzhftXLHQtZcw=; b=bkDczCs++X8NXDIx4I+cA+f8A6MtUxfkW0hQmUx8PWDxrZvwznDV89TyPb4Q2r/tvM Mvh+/485ROSSteHKP2nTUSdbUHv4eHEirD6tZoxvKWgtAqDVvbcaQ581WjNBwjuDTrOi FbJQWp1hIhJgw4axO6TFEhjwYeyh7PsKPQTj0UaEmqVyvIJPjQFLBEhFZBF5X9Ypx3sq eZ5zuWeY92eA8nfQtReXpFOj4ecKihsq7J/zJcCyrVefCmQ72vX6hTTkOT8dr7BfEj5l hMjc3I1TlHH/IpJ3TNobPpcVCEip1ZG4jizDhdsw5AZDZFhOHaUayhJkH7tAi+jikPK6 PUaw== X-Gm-Message-State: ANhLgQ1Zrl60WybKs2cj++ci+Uo2ws8SJDGXz1zwnUBLCBJ7WZINbbGE 9YaC84diduECarmLhYGeR3yxC7Yo/thIMi2O3jHmb+umpYA= X-Google-Smtp-Source: APiQypLYRrzWxZrlbpaHLCWWd1ElKKp5WQ8rvraTOsv33YWtdO90qCriipsZO40uAtIGauLg9nTUCvQqCtacCa2Id2s= X-Received: by 2002:a17:902:5acb:: with SMTP id g11mr4436095plm.18.1585662841043; Tue, 31 Mar 2020 06:54:01 -0700 (PDT) MIME-Version: 1.0 References: <20200313110350.10864-1-robert.foss@linaro.org> <20200313110350.10864-3-robert.foss@linaro.org> In-Reply-To: From: Andy Shevchenko Date: Tue, 31 Mar 2020 16:53:53 +0300 Message-ID: Subject: Re: [v2 2/3] media: ov8856: Add devicetree support To: Fabio Estevam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_083857_802500_2C8F72BC X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Robert Foss , Tomasz Figa , Sakari Ailus , Dongchun Zhu , Andy Shevchenko , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-media Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 31, 2020 at 4:43 PM Fabio Estevam wrote: > On Tue, Mar 31, 2020 at 10:37 AM Robert Foss wrote: > > > After testing this change, it breaks the driver during probing. > > Why exactly does it break probing? Maybe the GPIO polarity defined in > the device tree is wrong? > > > I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they > > seem to never be 0 or 1. > > If you do a grep in all gpiod_set_value_cansleep() usages in the > kernel tree, there is not a single case where GPIOD_OUT_HIGH or > GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep(). +1. It simple reveals the problem that is somewhere else. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel