Re: [PATCH] lib/string_helpers: add allocated strarray to device's resource list.

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Puyou Lu <puyou.lu@gmail.com>
Cc: akpm@linux-foundation.org, andy@kernel.org, chris@chrisdown.name,
	keescook@chromium.org, linus.walleij@linaro.org,
	linux-kernel@vger.kernel.org, linux@roeck-us.net,
	pmladek@suse.com
Subject: Re: [PATCH] lib/string_helpers: add allocated strarray to device's resource list.
Date: Fri, 6 May 2022 08:43:24 +0200	[thread overview]
Message-ID: <CAHp75VfJoiAW+rMcDawFdaSZrNhjjnFF9j94B=1mDKLSeMNYBw@mail.gmail.com> (raw)
In-Reply-To: <20220506044409.30066-1-puyou.lu@gmail.com>

On Fri, May 6, 2022 at 6:44 AM Puyou Lu <puyou.lu@gmail.com> wrote:
>
> This is a must to automatically release strarray when the device
> disappears.

Thanks for your patch!

First of all, since this is a v2 of it, you need to update the subject
to reflect this and add a changelog after the cutter '--- ' line
below.
Second, because this is the fix, please add a Fixes tag.

> Signed-off-by: Puyou Lu <puyou.lu@gmail.com>
> ---
>  lib/string_helpers.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/string_helpers.c b/lib/string_helpers.c
> index 4f877e9551d5..5ed3beb066e6 100644
> --- a/lib/string_helpers.c
> +++ b/lib/string_helpers.c
> @@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n)
>                 return ERR_PTR(-ENOMEM);
>         }
>
> +       ptr->n = n;
> +       devres_add(dev, ptr);

The code seems correct, good catch!

>         return ptr->array;
>  }
>  EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);
> --
> 2.17.1
>

-- 
With Best Regards,
Andy Shevchenko