From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D3DC433E0 for ; Sat, 6 Mar 2021 16:27:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A67AD65018 for ; Sat, 6 Mar 2021 16:27:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231142AbhCFQ0p (ORCPT ); Sat, 6 Mar 2021 11:26:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231139AbhCFQ0h (ORCPT ); Sat, 6 Mar 2021 11:26:37 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA31DC06174A; Sat, 6 Mar 2021 08:26:37 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id q6-20020a17090a4306b02900c42a012202so831296pjg.5; Sat, 06 Mar 2021 08:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yL/aYoE+aG2ZWMHaqrx7JSuFUFqJAg4Q9N8gr1xJxaE=; b=QIY9YO+t6iNg+hPO7BaluUlpxvQSHxLbmrTNoMtPNn1sicK1+WlSGLV2n4IFruyWds yl/8+jz5d2aQhTPX7t1/oBfbukW+c1HWIhGV1UORhYTCcZ9wcY90wB866kHBTIhG/tTC FFYZDcjTazf8Q0srQ2xfsOG4aj6LgXY38qiB6YXArzadHVm+/wAFJefkg5KXD/eJSFnZ W7I8ibxDkNx0fCgr5frBbuKQrrYDYwG7Yc73atPBi8PPhsLCt/7B4IfGV8tjQl3QYczw rG9HxQPbl6f1YkewbUGBY0/H19EdsbpCBuWjekKOICZYZR6Sj0WyWCvsqe64QD5YpHWo cZqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yL/aYoE+aG2ZWMHaqrx7JSuFUFqJAg4Q9N8gr1xJxaE=; b=Lg10NfO+YDbDWahi+h4OzJ3/Peu9qTyHm3aXC7WS2E1znqXN/KluqtnOGbdYabtGQY 03cY6HvdohwBXWyS/TcRlm9DXLJh8C2UEGzsQrrZp3Dz3RfTrBC46TTngba3NSlRKfT+ HDWEyzId7HmXBX9VGuJjJ3f07j1SZff/bCZ/+G/5hj/02G6UgIxNJ1xfCQumAMQRLgIR RNnHuTDM3V01++BscWGQj27luyh0yX87wg4PhRp+GfHH4d9u647ty+RBr34r1DxFdePZ TlXjV65kDYXibyiuUvyBvCxPR+GwY5PduTUrP/dmDlHOp4QzGSMWOtpZmot74dKqzDtY UKkg== X-Gm-Message-State: AOAM531Z/rCLNNdDOAvXJjqH8N7xNXa1FGYDjehzRe8iWMGMhxj0BbH8 L84g9Mh/6gflzazs7wsytv4nXoodhALif0nbTg4= X-Google-Smtp-Source: ABdhPJzHiUiVzOzuJW3HjdQZ5ow91HEc/Br5TUfGZPReNYbeuEk/YkffDiezsRwhPrst0+3LMlEkAuCXJrjsXjcGMTE= X-Received: by 2002:a17:90a:4586:: with SMTP id v6mr15155077pjg.129.1615047997252; Sat, 06 Mar 2021 08:26:37 -0800 (PST) MIME-Version: 1.0 References: <20210306155712.4298-1-noltari@gmail.com> <20210306155712.4298-3-noltari@gmail.com> In-Reply-To: <20210306155712.4298-3-noltari@gmail.com> From: Andy Shevchenko Date: Sat, 6 Mar 2021 18:26:20 +0200 Message-ID: Subject: Re: [PATCH v5 02/15] gpio: regmap: set gpio_chip of_node To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Linus Walleij , Rob Herring , Michael Walle , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list , Jonas Gorski , Necip Fazil Yildiran , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-arm Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Mar 6, 2021 at 5:57 PM =C3=81lvaro Fern=C3=A1ndez Rojas wrote: > > This is needed for properly registering GPIO regmap as a child of a regma= p > pin controller. Thanks for an update! ... > chip->parent =3D config->parent; > + if (config->fwnode) This... > + chip->of_node =3D to_of_node(config->fwnode); > + else > + chip->of_node =3D dev_of_node(config->parent); ...and these lines are not needed. If there is no of_node in the chip, the GPIO library will take care of it to be parent's one. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0549EC433DB for ; Sat, 6 Mar 2021 16:28:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5700B65005 for ; Sat, 6 Mar 2021 16:28:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5700B65005 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BEXADqNZCoecOy5Za2Lk07mMB8a93uYBAX+i1Q5yfmQ=; b=olcGmCNX3VOa8QKhxWwAjg3+U 4umklxzo/HseyWHf5ABma4I04/M4QyNZzNAd2syQpMnpbqESfNfOWc9Tgb5hlDMV8hZ2B/AeEUq27 t0rdpMz54uI7Jo3xAkXN5pt+wi60YWurnlY6LnnPosIVfKR2rS4J3lQVcBI5VAdBsCl5RbeSYPgAw Ex4jra2Woe0EL0vslQq47ZWFFm34DuD2Kyq+9x64KrmyRqAZhr9d18cpI6PgjViDCkwlySYSY6Aen TKDt7jXTMaLB4JWkShnLxdNoH4wpTRQ2T33u3aLTlcBsonxS8/9IfuEbPnbDtUjdKllaVCzbEGbuZ lZ9AGQlGQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lIZlM-003eu3-Dm; Sat, 06 Mar 2021 16:26:44 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lIZlH-003esT-LG for linux-arm-kernel@lists.infradead.org; Sat, 06 Mar 2021 16:26:41 +0000 Received: by mail-pj1-x102a.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so831926pjv.1 for ; Sat, 06 Mar 2021 08:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yL/aYoE+aG2ZWMHaqrx7JSuFUFqJAg4Q9N8gr1xJxaE=; b=QIY9YO+t6iNg+hPO7BaluUlpxvQSHxLbmrTNoMtPNn1sicK1+WlSGLV2n4IFruyWds yl/8+jz5d2aQhTPX7t1/oBfbukW+c1HWIhGV1UORhYTCcZ9wcY90wB866kHBTIhG/tTC FFYZDcjTazf8Q0srQ2xfsOG4aj6LgXY38qiB6YXArzadHVm+/wAFJefkg5KXD/eJSFnZ W7I8ibxDkNx0fCgr5frBbuKQrrYDYwG7Yc73atPBi8PPhsLCt/7B4IfGV8tjQl3QYczw rG9HxQPbl6f1YkewbUGBY0/H19EdsbpCBuWjekKOICZYZR6Sj0WyWCvsqe64QD5YpHWo cZqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yL/aYoE+aG2ZWMHaqrx7JSuFUFqJAg4Q9N8gr1xJxaE=; b=MI5V7g2JQ3gJUUEgoWZpT5YnsXCLhcgx/JQnmkaEU1FKYKgvFOsYo+LmTGbV6JasXo oxZt3w8fTLGKzu1kQOdfw5dkLSWKWA421ABcRKnb0KsEeeeokxnyZ3NdgRYRLoQjwwKU 0pBCtFULupRra6J9wNEr1CUFFU2qKK7tSGGRJ1nolodQqNjUyhhTBqPK5LikloXPhSi4 PlXHeCzViBeeaypwJZuybC4qvHaNuxywdjGbFW7VLXYYbHyRCoiRY3urgTaGB5XMqJH3 qxxHZ7sr/zvY3k6snK8nP0y/jMVSDAQYLTaH6PKF44CBn1RMAMxzGeYrodLhih8wRwG0 ti0A== X-Gm-Message-State: AOAM532eKFM3ofe7SbDgAvbV8pxhG3ndgt+R9B6/K8OsQOM3ZbELNUVU 5Q9K1SeO9GobQBQAF1IsopXeod1eoUPWrC2ri04= X-Google-Smtp-Source: ABdhPJzHiUiVzOzuJW3HjdQZ5ow91HEc/Br5TUfGZPReNYbeuEk/YkffDiezsRwhPrst0+3LMlEkAuCXJrjsXjcGMTE= X-Received: by 2002:a17:90a:4586:: with SMTP id v6mr15155077pjg.129.1615047997252; Sat, 06 Mar 2021 08:26:37 -0800 (PST) MIME-Version: 1.0 References: <20210306155712.4298-1-noltari@gmail.com> <20210306155712.4298-3-noltari@gmail.com> In-Reply-To: <20210306155712.4298-3-noltari@gmail.com> From: Andy Shevchenko Date: Sat, 6 Mar 2021 18:26:20 +0200 Message-ID: Subject: Re: [PATCH v5 02/15] gpio: regmap: set gpio_chip of_node To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Linus Walleij , Rob Herring , Michael Walle , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list , Jonas Gorski , Necip Fazil Yildiran , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-arm Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210306_162639_821352_E34C0BAC X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBNYXIgNiwgMjAyMSBhdCA1OjU3IFBNIMOBbHZhcm8gRmVybsOhbmRleiBSb2phcyA8 bm9sdGFyaUBnbWFpbC5jb20+IHdyb3RlOgo+Cj4gVGhpcyBpcyBuZWVkZWQgZm9yIHByb3Blcmx5 IHJlZ2lzdGVyaW5nIEdQSU8gcmVnbWFwIGFzIGEgY2hpbGQgb2YgYSByZWdtYXAKPiBwaW4gY29u dHJvbGxlci4KClRoYW5rcyBmb3IgYW4gdXBkYXRlIQoKLi4uCgo+ICAgICAgICAgY2hpcC0+cGFy ZW50ID0gY29uZmlnLT5wYXJlbnQ7Cgo+ICsgICAgICAgaWYgKGNvbmZpZy0+Zndub2RlKQoKVGhp cy4uLgoKPiArICAgICAgICAgICAgICAgY2hpcC0+b2Zfbm9kZSA9IHRvX29mX25vZGUoY29uZmln LT5md25vZGUpOwoKPiArICAgICAgIGVsc2UKPiArICAgICAgICAgICAgICAgY2hpcC0+b2Zfbm9k ZSA9IGRldl9vZl9ub2RlKGNvbmZpZy0+cGFyZW50KTsKCi4uLmFuZCB0aGVzZSBsaW5lcyBhcmUg bm90IG5lZWRlZC4gSWYgdGhlcmUgaXMgbm8gb2Zfbm9kZSBpbiB0aGUgY2hpcCwKdGhlIEdQSU8g bGlicmFyeSB3aWxsIHRha2UgY2FyZSBvZiBpdCB0byBiZSBwYXJlbnQncyBvbmUuCgotLSAKV2l0 aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=