From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23039C432C0 for ; Sun, 24 Nov 2019 19:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5812207FD for ; Sun, 24 Nov 2019 19:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QOscabZb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfKXT6B (ORCPT ); Sun, 24 Nov 2019 14:58:01 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44753 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbfKXT6B (ORCPT ); Sun, 24 Nov 2019 14:58:01 -0500 Received: by mail-pg1-f193.google.com with SMTP id e6so5952524pgi.11; Sun, 24 Nov 2019 11:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dkRSUp4LWvNPm+vfZgEiYDvglJm3beCRxL71deUAo/A=; b=QOscabZbSDR/sllFcuyMh2fWkaut3t5bOuY0nM8nOMKiyZG47JOoS081/sEHP6TiSj uGU32SMvZMtWe7va8tydQDaKyPTujE/Uyyg2LN5+d6IkKB5zwwzTWFwIQXzl7vDR53ov qMpnw6eDrkP0065xCLc0cF8tbAz8CZympuICLaAj16lD1w8IYzBxaS9CqyvEvAY1LITb A4/c1jqiNY62vbqQdyjhHiY02iU7tjNwKnEe0xffiquj+SOzSW0R0tDQxzr4TZf36xb9 BTdBTQgr4qL+qn6RAGZ3KS8xnq3EnmUYHcuAv8yiowvBPu+SZ53MJQanBy0DM/sw+3u3 Fhlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dkRSUp4LWvNPm+vfZgEiYDvglJm3beCRxL71deUAo/A=; b=UKuhZpfvISuyU9zZY07CLkqh+sP+CjzyGpohiyi2duvGfSGjY4VfH8GoApdGZ3cdvA y+DO2PP4CRGmZ4DaOo4BCDIgaLqpwyxuLoJ1wPUpv9ffXAeQHYvccV7Xf2X7lDTYldHM +g2HkMqJUSxGDUit1cG4JYAYy6X74KUtHDu/RLjknkARKhUIZJ5ujbKSGRtLB+IW8V7a Iul3MvSyIbYm8QjKAILtlwTT/dp3whIUwVgctDN6pHU0pTTcY/v0eDydvzsW6YKqoLu/ MqWwg5zNwixndUXaCDVsYfvJgl8NoG9ubq6tGR5Tzf47xPaYXTTF9kEZJsZcXKl+Ces8 C8zQ== X-Gm-Message-State: APjAAAVFLzYpUdcTxxS6dQgujkjISDw2bffDyXZCfNl1f/anXIUKVazf GSpouErij0miFJf4PeasGdoE4/ALT98oalvc711V1RNT X-Google-Smtp-Source: APXvYqzZWhn8q4bZQQp+nT7h6x2ELej7bYnsrWqD8H+1zhdVeihgLHB4jq7aMAZW914Rfqu8lIObgLw+MrjOOlyJyzk= X-Received: by 2002:a65:6118:: with SMTP id z24mr29135288pgu.203.1574625480441; Sun, 24 Nov 2019 11:58:00 -0800 (PST) MIME-Version: 1.0 References: <1574604530-9024-1-git-send-email-akinobu.mita@gmail.com> <1574604530-9024-5-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1574604530-9024-5-git-send-email-akinobu.mita@gmail.com> From: Andy Shevchenko Date: Sun, 24 Nov 2019 21:57:49 +0200 Message-ID: Subject: Re: [PATCH 4/8] platform/x86: intel_menlow: switch to use helpers To: Akinobu Mita Cc: Linux NVMe Mailinglist , linux-hwmon@vger.kernel.org, Linux PM , Linux Kernel Mailing List , Sujith Thomas , Darren Hart , Andy Shevchenko , Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , Jean Delvare , Guenter Roeck , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Content-Type: text/plain; charset="UTF-8" Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita wrote: > > This switches the intel_menlow driver to use deci_kelvin_to_celsius() and > celsius_to_deci_kelvin() in instead of helpers in > . > > This is preparation for centralizing the kelvin to/from Celsius conversion > helpers in . > > Cc: Sujith Thomas > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Daniel Lezcano > Cc: Amit Kucheria > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: Keith Busch > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Sagi Grimberg > Signed-off-by: Akinobu Mita > --- > drivers/platform/x86/intel_menlow.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel_menlow.c > index b102f6d..6313591 100644 > --- a/drivers/platform/x86/intel_menlow.c > +++ b/drivers/platform/x86/intel_menlow.c > @@ -302,8 +302,10 @@ static ssize_t aux_show(struct device *dev, struct device_attribute *dev_attr, > int result; > > result = sensor_get_auxtrip(attr->handle, idx, &value); > + if (result) > + return result; > > - return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO_CELSIUS(value)); > + return sprintf(buf, "%ld", deci_kelvin_to_celsius(value)); Can you explain the change %lu to %ld? > } > > static ssize_t aux0_show(struct device *dev, > @@ -332,8 +334,8 @@ static ssize_t aux_store(struct device *dev, struct device_attribute *dev_attr, > if (value < 0) > return -EINVAL; > > - result = sensor_set_auxtrip(attr->handle, idx, > - CELSIUS_TO_DECI_KELVIN(value)); > + result = sensor_set_auxtrip(attr->handle, idx, > + celsius_to_deci_kelvin(value)); How come the first line has been changed? > return result ? result : count; > } > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F69C432C0 for ; Sun, 24 Nov 2019 19:58:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D8FD207FD for ; Sun, 24 Nov 2019 19:58:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m6UvZskF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QOscabZb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D8FD207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VhW9mlpu4Tb+TK7s8IXMQ+yDaeLOtrDuC04sC51P2RI=; b=m6UvZskF726cEf +qgbtCusT37kdGHO9Rv5DRNqcO2f0FT7Cs2cSEWBR5fNmS6fNSKsporQ2EcTJJPMUOiwF58GSIYE6 mwj2esuoi0EAW/vmvE0sjr3uNrq1uwKYOnoEqMJrHXakRWJTM665U0gqnY7KBjIAQFvS4RSfyfk/t YGwGrMRo/KJ44TsUlr0rZ3dXTAMCk/8IfBq3V/9NCqLocpQl7G5VoblAmXcg7vlKiqiTyn4WYmVZS jyZWkHqEfvz3oNHX9nqplmwLJKgrr55/nvKoU+Eih/ZLSCOP45NeUwCAiD6LQJ75Ajh9U3voX8fK4 N40oS5NJM6odfQQbEQ5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYy1E-0007tL-9h; Sun, 24 Nov 2019 19:58:04 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYy1B-0007sX-58 for linux-nvme@lists.infradead.org; Sun, 24 Nov 2019 19:58:02 +0000 Received: by mail-pf1-x441.google.com with SMTP id d199so1537605pfd.11 for ; Sun, 24 Nov 2019 11:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dkRSUp4LWvNPm+vfZgEiYDvglJm3beCRxL71deUAo/A=; b=QOscabZbSDR/sllFcuyMh2fWkaut3t5bOuY0nM8nOMKiyZG47JOoS081/sEHP6TiSj uGU32SMvZMtWe7va8tydQDaKyPTujE/Uyyg2LN5+d6IkKB5zwwzTWFwIQXzl7vDR53ov qMpnw6eDrkP0065xCLc0cF8tbAz8CZympuICLaAj16lD1w8IYzBxaS9CqyvEvAY1LITb A4/c1jqiNY62vbqQdyjhHiY02iU7tjNwKnEe0xffiquj+SOzSW0R0tDQxzr4TZf36xb9 BTdBTQgr4qL+qn6RAGZ3KS8xnq3EnmUYHcuAv8yiowvBPu+SZ53MJQanBy0DM/sw+3u3 Fhlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dkRSUp4LWvNPm+vfZgEiYDvglJm3beCRxL71deUAo/A=; b=i58NdgZxf9zbh2xE1EIoMeAxHD6SYu7YtPVQ4e4Wj+1QiXFyxZLe1PuhTP1lIAqeA3 44+UHNQhblBrEsMZTaxdLJe7BzdXwsjsAJDmnRrrXa0p8wAR4PEw32DXQ2Ajdr782LC1 XhM0KK08UnRPl8MFUbqBcS81NdKK59JBCj+OveZVyLRF48/+jVlSEMvr9jibTJSbiXkV dC1kaw6r3ZSNSbSFhFOMO942xfGD5qwnGAPyXvhHjuHlN4pZpOZuIsZ7pxff8PyAN++K KN2fGtudjDRWnq0V2EIzLlUZFDoomqbNE5vSwMTLvEo/RTCqozSGtnF64jsLk8d+eg1u uuZA== X-Gm-Message-State: APjAAAUuNb53aW9iqg3jK5/5JlGvNUInRCvt8lqs7JdUW5e/wMEIP+wT YTyTb2SRcoWZcsUd2SaQnpNehhjjZckvNuiIErg= X-Google-Smtp-Source: APXvYqzZWhn8q4bZQQp+nT7h6x2ELej7bYnsrWqD8H+1zhdVeihgLHB4jq7aMAZW914Rfqu8lIObgLw+MrjOOlyJyzk= X-Received: by 2002:a65:6118:: with SMTP id z24mr29135288pgu.203.1574625480441; Sun, 24 Nov 2019 11:58:00 -0800 (PST) MIME-Version: 1.0 References: <1574604530-9024-1-git-send-email-akinobu.mita@gmail.com> <1574604530-9024-5-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1574604530-9024-5-git-send-email-akinobu.mita@gmail.com> From: Andy Shevchenko Date: Sun, 24 Nov 2019 21:57:49 +0200 Message-ID: Subject: Re: [PATCH 4/8] platform/x86: intel_menlow: switch to use helpers To: Akinobu Mita X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191124_115801_196565_8D4B163E X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Jens Axboe , Amit Kucheria , Jean Delvare , Sagi Grimberg , Linux PM , Sujith Thomas , Daniel Lezcano , Linux Kernel Mailing List , Linux NVMe Mailinglist , Eduardo Valentin , Guenter Roeck , Keith Busch , Darren Hart , Zhang Rui , Christoph Hellwig , Andy Shevchenko Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita wrote: > > This switches the intel_menlow driver to use deci_kelvin_to_celsius() and > celsius_to_deci_kelvin() in instead of helpers in > . > > This is preparation for centralizing the kelvin to/from Celsius conversion > helpers in . > > Cc: Sujith Thomas > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Daniel Lezcano > Cc: Amit Kucheria > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: Keith Busch > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Sagi Grimberg > Signed-off-by: Akinobu Mita > --- > drivers/platform/x86/intel_menlow.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel_menlow.c > index b102f6d..6313591 100644 > --- a/drivers/platform/x86/intel_menlow.c > +++ b/drivers/platform/x86/intel_menlow.c > @@ -302,8 +302,10 @@ static ssize_t aux_show(struct device *dev, struct device_attribute *dev_attr, > int result; > > result = sensor_get_auxtrip(attr->handle, idx, &value); > + if (result) > + return result; > > - return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO_CELSIUS(value)); > + return sprintf(buf, "%ld", deci_kelvin_to_celsius(value)); Can you explain the change %lu to %ld? > } > > static ssize_t aux0_show(struct device *dev, > @@ -332,8 +334,8 @@ static ssize_t aux_store(struct device *dev, struct device_attribute *dev_attr, > if (value < 0) > return -EINVAL; > > - result = sensor_set_auxtrip(attr->handle, idx, > - CELSIUS_TO_DECI_KELVIN(value)); > + result = sensor_set_auxtrip(attr->handle, idx, > + celsius_to_deci_kelvin(value)); How come the first line has been changed? > return result ? result : count; > } > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme