From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F5C8C4743C for ; Mon, 7 Jun 2021 08:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A82C61208 for ; Mon, 7 Jun 2021 08:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbhFGIok (ORCPT ); Mon, 7 Jun 2021 04:44:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbhFGIoi (ORCPT ); Mon, 7 Jun 2021 04:44:38 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB697C061766 for ; Mon, 7 Jun 2021 01:42:47 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d16so12527451pfn.12 for ; Mon, 07 Jun 2021 01:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wDg8/aI1PuYOAa2UFE+KVmLp+L8E9j1GBJnNz/20160=; b=DnqQNTiXccMXKvEMdxBrWrV1+npUmpiZFOKUaNbe9s4kwc4oWESXEWzfdu8kukfLjY xYAb2QgLbef6ca/V6V7077rRzvgq8Ccpb0noOcuvGk+oYahrooyUdLORTJnl7iiEB/5r tq1wFnBqX62mqQmZyTg3CVtRwTYnqKAz1Q7Okcfl5fTnYyk+RpRE02iR+ohVbBKrszFu izakVi+NLWDUakCZ47YE7Zw7C9RGgipWLHBOvHm3QYlEEDOkRFSW/vqbSFh6KUxx21VZ Skd4K8MihUztx6gKSJ8xHZRnOrhGXAdp7xzXnkvs6UbGq9lSd1JabwYR7A3SYUKc/yvN fotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wDg8/aI1PuYOAa2UFE+KVmLp+L8E9j1GBJnNz/20160=; b=PRhCz0WzofumySWf9dD1KYeB0phTZ2FHRbx/uzBq5gbiC+N+PKb+SsjRuUTp5+wW5k 18IQJJ3cT8EvBvf6OfqBE/Er/5s6vJAUFY6iLjKX9DdJs/qSemEkAp/L+vya3LerMqUU naI+tVY7GGFHPphFVVh/FhoRuqreYG2G15QhuCf6Gk3I1x7B9IQHmuPS3VXFN2CVwRzG 1019PGECMRNEK0Y6r4UKsY6TFEc1iVyHoHTRPtBdKY02JEz8+KZe0lOPjMjQAgR1fCe+ 5avfnx4jSpP2RKarQKjhG6tPCoaX3rvRaBYzsAIHUIxsfWUr7lhTogn6PqXx8CV4b45W e2dA== X-Gm-Message-State: AOAM532zaNZEBl8xe+e0IEmYGHqwMGJbFMrujhOgCJMovWT1ZiR+vCMX 834l2YavPBzvxvWFABjURltyDxXxMbo0ipYkj/g= X-Google-Smtp-Source: ABdhPJzFEb94kqJTu/BGex0Ss8ROGxSRDb7v248+ug+o6gMFoBTJnzzyhTyFlJW6S6wdIo/LvRo0u0sGUmhWlC6aOZE= X-Received: by 2002:a63:79c3:: with SMTP id u186mr16809558pgc.203.1623055367160; Mon, 07 Jun 2021 01:42:47 -0700 (PDT) MIME-Version: 1.0 References: <1622996045-25826-1-git-send-email-faiyazm@codeaurora.org> In-Reply-To: From: Andy Shevchenko Date: Mon, 7 Jun 2021 11:42:31 +0300 Message-ID: Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs To: Faiyaz Mohammed Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , linux-mm , Linux Kernel Mailing List , Greg KH , glittao@gmail.com, vinmenon@codeaurora.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 7, 2021 at 5:40 AM Faiyaz Mohammed wro= te: > On 6/7/2021 2:01 AM, Andy Shevchenko wrote: > > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed = wrote: ... > >> + if (l->sum_time !=3D l->min_time) { > >> + seq_printf(seq, " age=3D%ld/%ld/%ld", > >> + l->min_time, > > > >> + (long)div_u64(l->sum_time, l->count), > > > > Hmm... Why is the cast needed here? > > > To avoid below warning while preparing build for arm/32 bit, > "format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98long int= =E2=80=99, but argument 4 has > type =E2=80=98u64 {aka long long unsigned int}" . Perhaps use %llu? > >> + l->max_time); > >> + } else > >> + seq_printf(seq, " age=3D%ld", > >> + l->min_time); --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE545C47082 for ; Mon, 7 Jun 2021 08:42:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9BB3261105 for ; Mon, 7 Jun 2021 08:42:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BB3261105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F3CB6B006E; Mon, 7 Jun 2021 04:42:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A5816B0070; Mon, 7 Jun 2021 04:42:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21E906B0071; Mon, 7 Jun 2021 04:42:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id E20F06B006E for ; Mon, 7 Jun 2021 04:42:48 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7EAF9B9F7 for ; Mon, 7 Jun 2021 08:42:48 +0000 (UTC) X-FDA: 78226287216.12.7C78B79 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 8A6A84202A19 for ; Mon, 7 Jun 2021 08:42:46 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id z26so12552592pfj.5 for ; Mon, 07 Jun 2021 01:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wDg8/aI1PuYOAa2UFE+KVmLp+L8E9j1GBJnNz/20160=; b=DnqQNTiXccMXKvEMdxBrWrV1+npUmpiZFOKUaNbe9s4kwc4oWESXEWzfdu8kukfLjY xYAb2QgLbef6ca/V6V7077rRzvgq8Ccpb0noOcuvGk+oYahrooyUdLORTJnl7iiEB/5r tq1wFnBqX62mqQmZyTg3CVtRwTYnqKAz1Q7Okcfl5fTnYyk+RpRE02iR+ohVbBKrszFu izakVi+NLWDUakCZ47YE7Zw7C9RGgipWLHBOvHm3QYlEEDOkRFSW/vqbSFh6KUxx21VZ Skd4K8MihUztx6gKSJ8xHZRnOrhGXAdp7xzXnkvs6UbGq9lSd1JabwYR7A3SYUKc/yvN fotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wDg8/aI1PuYOAa2UFE+KVmLp+L8E9j1GBJnNz/20160=; b=Jkyo7CTteJ80LnxPL3L4kuUwELxrFcZETIgjf+a3P6/63pLEcNYHQNXGJ+nfEVGAQp SsCrzymrcFnZOfE9MADppRJArvsAcap1zaiNrRF2IPcYEqKtAVclUN2ZTQSEjUyp539J kiw1O4zrTMFLwaCj+nDTrJwtgA6mBc4sICvaiqDqyO0hAOvh4PTQNdZeVtLMjUIvdeal vio+eiC6FfqSbdAuqZLvYjsEsjNaDC0kpWNaRR64F8HqJb2rsoPKGK5VjHg+ieESv6zQ Y2dv1aKU3dt3BuI5E8FU97GhEQA76jDPxObezL915omUBIbHnjwi1i1cXUEN2dl81fxm 0meg== X-Gm-Message-State: AOAM533crS2TKqknMpwaXvfkEgakfu8QPt+10K0c9MDkv64rOR0BBsCt dnS7Y0+rVwj6q6hn9+iUIz3tiKL5sJ8UDqCYx50= X-Google-Smtp-Source: ABdhPJzFEb94kqJTu/BGex0Ss8ROGxSRDb7v248+ug+o6gMFoBTJnzzyhTyFlJW6S6wdIo/LvRo0u0sGUmhWlC6aOZE= X-Received: by 2002:a63:79c3:: with SMTP id u186mr16809558pgc.203.1623055367160; Mon, 07 Jun 2021 01:42:47 -0700 (PDT) MIME-Version: 1.0 References: <1622996045-25826-1-git-send-email-faiyazm@codeaurora.org> In-Reply-To: From: Andy Shevchenko Date: Mon, 7 Jun 2021 11:42:31 +0300 Message-ID: Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs To: Faiyaz Mohammed Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , linux-mm , Linux Kernel Mailing List , Greg KH , glittao@gmail.com, vinmenon@codeaurora.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=DnqQNTiX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of andyshevchenko@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=andyshevchenko@gmail.com X-Stat-Signature: e5kaj59qqj5ducyrnxj3n49wipubsh6e X-Rspamd-Queue-Id: 8A6A84202A19 X-Rspamd-Server: rspam02 X-HE-Tag: 1623055366-803337 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 7, 2021 at 5:40 AM Faiyaz Mohammed wro= te: > On 6/7/2021 2:01 AM, Andy Shevchenko wrote: > > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed = wrote: ... > >> + if (l->sum_time !=3D l->min_time) { > >> + seq_printf(seq, " age=3D%ld/%ld/%ld", > >> + l->min_time, > > > >> + (long)div_u64(l->sum_time, l->count), > > > > Hmm... Why is the cast needed here? > > > To avoid below warning while preparing build for arm/32 bit, > "format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98long int= =E2=80=99, but argument 4 has > type =E2=80=98u64 {aka long long unsigned int}" . Perhaps use %llu? > >> + l->max_time); > >> + } else > >> + seq_printf(seq, " age=3D%ld", > >> + l->min_time); --=20 With Best Regards, Andy Shevchenko