All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] iio: adxl372: change indentation for of_table
Date: Tue, 21 Jul 2020 21:36:19 +0300	[thread overview]
Message-ID: <CAHp75VfSRUYUaYaHgsr91H9DfV4WeObhzTB3r9UwdNx2tyW6Gg@mail.gmail.com> (raw)
In-Reply-To: <20200720134839.71124-1-alexandru.ardelean@analog.com>

On Mon, Jul 20, 2020 at 4:49 PM Alexandru Ardelean
<alexandru.ardelean@analog.com> wrote:
>
> The change is mostly stylistic. The table should be indented with tabs
> instead of spaces.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
>  drivers/iio/accel/adxl372_spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
> index 3ef7e3a4804e..7741890674c1 100644
> --- a/drivers/iio/accel/adxl372_spi.c
> +++ b/drivers/iio/accel/adxl372_spi.c
> @@ -40,8 +40,8 @@ static const struct spi_device_id adxl372_spi_id[] = {
>  MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
>
>  static const struct of_device_id adxl372_of_match[] = {
> -        { .compatible = "adi,adxl372" },
> -        { },
> +       { .compatible = "adi,adxl372" },
> +       { },

Please, drop useless and even bad in very rare cases comma at the
terminator line.

>  };
>  MODULE_DEVICE_TABLE(of, adxl372_of_match);
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2020-07-21 18:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 13:48 [PATCH] iio: adxl372: change indentation for of_table Alexandru Ardelean
2020-07-21 18:36 ` Andy Shevchenko [this message]
2020-07-22  7:25 ` [PATCH v2] iio: adxl372_spi: " Alexandru Ardelean
2020-07-26 12:30   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VfSRUYUaYaHgsr91H9DfV4WeObhzTB3r9UwdNx2tyW6Gg@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.