From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbeEaS7U (ORCPT ); Thu, 31 May 2018 14:59:20 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:43419 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755895AbeEaS7R (ORCPT ); Thu, 31 May 2018 14:59:17 -0400 X-Google-Smtp-Source: ADUXVKJ8CC+QDm6XrFkgjvugGQXbIQVWLvqH2ALixCn2m++g+g8kLAuLaOGH0QmLhWdaNX0N2uF9uum/d6df3wf81Rw= MIME-Version: 1.0 In-Reply-To: References: <1527765086-19873-1-git-send-email-xieyisheng1@huawei.com> <1527765086-19873-2-git-send-email-xieyisheng1@huawei.com> From: Andy Shevchenko Date: Thu, 31 May 2018 21:59:16 +0300 Message-ID: Subject: Re: [PATCH v2 01/21] usb: phy: use match_string() helper To: Sergei Shtylyov Cc: Yisheng Xie , Linux Kernel Mailing List , USB , Felipe Balbi , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 31, 2018 at 9:56 PM, Sergei Shtylyov wrote: > On 05/31/2018 09:47 PM, Andy Shevchenko wrote: >>>> - int err, i; >>>> + err = match_string(usbphy_modes, ARRAY_SIZE(usbphy_modes), phy_type); >>>> + if (err < 0) >>> >>> This is one of the few cases when 'err' is not the best name for such a >>> variable. I'd prefer to see something like 'match' or even 'rc' or 'ret'... :-) >> >> Then leaving i would make it? > Yes. :-) So, I leave it to Greg to decide either it's okay in this version, or needs update with i left untouched. >> I'm okay with either which just not renames err, b/c it's used with >> something else in this function. > > Looking at it again, 'err' seems equally bad for the result of > of_property_read_string()... unless the check there is changed to just *if* (err) -- > this function never returns positive values, 0 means success, others mean error. While you seems right, this is matter of another change which you are welcome to propose. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,01/21] usb: phy: use match_string() helper From: Andy Shevchenko Message-Id: Date: Thu, 31 May 2018 21:59:16 +0300 To: Sergei Shtylyov Cc: Yisheng Xie , Linux Kernel Mailing List , USB , Felipe Balbi , Greg Kroah-Hartman List-ID: T24gVGh1LCBNYXkgMzEsIDIwMTggYXQgOTo1NiBQTSwgU2VyZ2VpIFNodHlseW92CjxzZXJnZWku c2h0eWx5b3ZAY29nZW50ZW1iZWRkZWQuY29tPiB3cm90ZToKPiBPbiAwNS8zMS8yMDE4IDA5OjQ3 IFBNLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cgo+Pj4+IC0gICAgIGludCBlcnIsIGk7Cgo+Pj4+ ICsgICAgIGVyciA9IG1hdGNoX3N0cmluZyh1c2JwaHlfbW9kZXMsIEFSUkFZX1NJWkUodXNicGh5 X21vZGVzKSwgcGh5X3R5cGUpOwo+Pj4+ICsgICAgIGlmIChlcnIgPCAwKQo+Pj4KPj4+ICAgIFRo aXMgaXMgb25lIG9mIHRoZSBmZXcgY2FzZXMgd2hlbiAnZXJyJyBpcyBub3QgdGhlIGJlc3QgbmFt ZSBmb3Igc3VjaCBhCj4+PiB2YXJpYWJsZS4gSSdkIHByZWZlciB0byBzZWUgc29tZXRoaW5nIGxp a2UgJ21hdGNoJyBvciBldmVuICdyYycgb3IgJ3JldCcuLi4gOi0pCj4+Cj4+IFRoZW4gbGVhdmlu ZyBpIHdvdWxkIG1ha2UgaXQ/Cj4gICAgWWVzLiA6LSkKClNvLCBJIGxlYXZlIGl0IHRvIEdyZWcg dG8gZGVjaWRlIGVpdGhlciBpdCdzIG9rYXkgaW4gdGhpcyB2ZXJzaW9uLCBvcgpuZWVkcyB1cGRh dGUgd2l0aCBpIGxlZnQgdW50b3VjaGVkLgoKPj4gSSdtIG9rYXkgd2l0aCBlaXRoZXIgd2hpY2gg anVzdCBub3QgcmVuYW1lcyBlcnIsIGIvYyBpdCdzIHVzZWQgd2l0aAo+PiBzb21ldGhpbmcgZWxz ZSBpbiB0aGlzIGZ1bmN0aW9uLgo+Cj4gICAgTG9va2luZyBhdCBpdCBhZ2FpbiwgJ2Vycicgc2Vl bXMgZXF1YWxseSBiYWQgZm9yIHRoZSByZXN1bHQgb2YKPiBvZl9wcm9wZXJ0eV9yZWFkX3N0cmlu ZygpLi4uIHVubGVzcyB0aGUgY2hlY2sgdGhlcmUgaXMgY2hhbmdlZCB0byBqdXN0ICppZiogKGVy cikgLS0KPiB0aGlzIGZ1bmN0aW9uIG5ldmVyIHJldHVybnMgcG9zaXRpdmUgdmFsdWVzLCAwIG1l YW5zIHN1Y2Nlc3MsIG90aGVycyBtZWFuIGVycm9yLgoKV2hpbGUgeW91IHNlZW1zIHJpZ2h0LCB0 aGlzIGlzIG1hdHRlciBvZiBhbm90aGVyIGNoYW5nZSB3aGljaCB5b3UgYXJlCndlbGNvbWUgdG8g cHJvcG9zZS4K