From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85ED9C432BE for ; Fri, 27 Aug 2021 06:59:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E51160FC4 for ; Fri, 27 Aug 2021 06:59:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244289AbhH0HAF (ORCPT ); Fri, 27 Aug 2021 03:00:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232463AbhH0G75 (ORCPT ); Fri, 27 Aug 2021 02:59:57 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E63A3C0613CF; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id j4-20020a17090a734400b0018f6dd1ec97so4160984pjs.3; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=Ahob/aCaoxGGmBX3uT/2Oo+coR/T1tys8xgPUYlJZHQ+79x1W7tMhNYHihEb3g00Pw m+dgL0BLb9DG6XuqQrGIlpqK11vUr+Y2ytYHZ7LdTBFa1tFBJE3STgSjF41FypNGQroh EB33JFOQSvpQcvOA/KVG6FqtXl7O0+BT+q4qQg5vtIojCX29E2kJoRY1MRvb3ovAgDbp aFXAm0ssP0g7n3TLr2XOHHUaLQbsPjFKeMCjJaff6OnyliY0dDUUm9ACwqxN5BizOny5 6o6R1k1p3THp4VGKPD1gPgbF9N5SJmHFccehHvyHptaqGZoYeq1bOsTJYfzYeYbXFcTi n8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=ToFay4Mj171KSgAatRKbwrZRLxjM1j14IwtUx4af3DJaHCEo7VueRmcCerm9u0R0h7 zMCIJxbIoFyCGq1qzK4YABwtmkqF0PntLqY09nZRgYRD8RzB9A/X3p1GJhNsUc5RCKP6 uWk1J5WaqRFqUQCCUG5PzoZaZKipTGQmvXcn9XX0C8/ZNhuZUMwB4Dhj4ACyr4ZYdx2e ymc/kiobx37ur98IjTzBoTdMD1xC6h9aVzW8ILceizEer8qFS6k9bbQK7p4aq2EPljxf kruW11Lf/cldZpSMD+3+2JxfkC+7+PxuoFUxevHwltYku8u/woi7+Z9YNDIecECvB1h+ dTnw== X-Gm-Message-State: AOAM532go+s8Liqomo/NuCHFO1Ipw7T2YHTQsQ4tMwZ/Rsm+vHZFNOeq +gL7u+jikXdELWQEo7dO/mZWzY4dfUMGg+NmOGw= X-Google-Smtp-Source: ABdhPJzbMPfKsiNwRsmJ6wf35o+bM3Vsllxj/xaKs1Zg3gEKi2+LtrBilr6TwQqyx2Jk+YbMtx83ULLwDM5rxvcqh8o= X-Received: by 2002:a17:902:bb81:b0:12d:a7ec:3d85 with SMTP id m1-20020a170902bb8100b0012da7ec3d85mr7349833pls.17.1630047548297; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) MIME-Version: 1.0 References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-11-tientzu@chromium.org> In-Reply-To: <20210624155526.2775863-11-tientzu@chromium.org> From: Andy Shevchenko Date: Fri, 27 Aug 2021 09:58:32 +0300 Message-ID: Subject: Re: [PATCH v15 10/12] swiotlb: Add restricted DMA pool initialization To: Claire Chang Cc: Rob Herring , Michael Ellerman , Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , tfiga@chromium.org, bskeggs@redhat.com, bhelgaas@google.com, chris@chris-wilson.co.uk, daniel@ffwll.ch, airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jxgao@google.com, joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, thomas.lendacky@amd.com, quic_qiancai@quicinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 6:59 PM Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes. > > Regardless of swiotlb setting, the restricted DMA pool is preferred if > available. > > The restricted DMA pools provide a basic level of protection against the > DMA overwriting buffer contents at unexpected times. However, to protect > against general data leakage and system memory corruption, the system > needs to provide a way to lock down the memory access, e.g., MPU. > +static int rmem_swiotlb_device_init(struct reserved_mem *rmem, > + struct device *dev) > +{ > + struct io_tlb_mem *mem =3D rmem->priv; > + unsigned long nslabs =3D rmem->size >> IO_TLB_SHIFT; > + > + /* > + * Since multiple devices can share the same pool, the private da= ta, > + * io_tlb_mem struct, will be initialized by the first device att= ached > + * to it. > + */ > + if (!mem) { Can it be rather if (mem) goto out_assign; or so? > + mem =3D kzalloc(struct_size(mem, slots, nslabs), GFP_KERN= EL); > + if (!mem) > + return -ENOMEM; > + > + set_memory_decrypted((unsigned long)phys_to_virt(rmem->ba= se), > + rmem->size >> PAGE_SHIFT); Below you are using a macro from pfn.h, but not here, I think it's PFN_DOWN= (). > + swiotlb_init_io_tlb_mem(mem, rmem->base, nslabs, false); > + mem->force_bounce =3D true; > + mem->for_alloc =3D true; > + > + rmem->priv =3D mem; > + > + if (IS_ENABLED(CONFIG_DEBUG_FS)) { > + mem->debugfs =3D > + debugfs_create_dir(rmem->name, debugfs_di= r); > + swiotlb_create_debugfs_files(mem); > + } > + } > + > + dev->dma_io_tlb_mem =3D mem; > + > + return 0; > +} > + > +static void rmem_swiotlb_device_release(struct reserved_mem *rmem, > + struct device *dev) > +{ > + dev->dma_io_tlb_mem =3D io_tlb_default_mem; > +} > + > +static const struct reserved_mem_ops rmem_swiotlb_ops =3D { > + .device_init =3D rmem_swiotlb_device_init, > + .device_release =3D rmem_swiotlb_device_release, > +}; > + > +static int __init rmem_swiotlb_setup(struct reserved_mem *rmem) > +{ > + unsigned long node =3D rmem->fdt_node; > + > + if (of_get_flat_dt_prop(node, "reusable", NULL) || > + of_get_flat_dt_prop(node, "linux,cma-default", NULL) || > + of_get_flat_dt_prop(node, "linux,dma-default", NULL) || > + of_get_flat_dt_prop(node, "no-map", NULL)) > + return -EINVAL; > + > + if (PageHighMem(pfn_to_page(PHYS_PFN(rmem->base)))) { > + pr_err("Restricted DMA pool must be accessible within the= linear mapping."); > + return -EINVAL; > + } > + > + rmem->ops =3D &rmem_swiotlb_ops; > + pr_info("Reserved memory: created restricted DMA pool at %pa, siz= e %ld MiB\n", > + &rmem->base, (unsigned long)rmem->size / SZ_1M); Oh l=C3=A0 l=C3=A0, besides explicit casting that I believe can be avoided,= %ld !=3D unsigned long. Can you check the printk-formats.rst document? > + return 0; > +} > + > +RESERVEDMEM_OF_DECLARE(dma, "restricted-dma-pool", rmem_swiotlb_setup); > #endif /* CONFIG_DMA_RESTRICTED_POOL */ --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA07C432BE for ; Fri, 27 Aug 2021 06:59:16 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F9AF60FC4 for ; Fri, 27 Aug 2021 06:59:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F9AF60FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EDBF580C0B; Fri, 27 Aug 2021 06:59:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5IPsvB0vPP-3; Fri, 27 Aug 2021 06:59:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id C8BDB80B93; Fri, 27 Aug 2021 06:59:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8C53FC0010; Fri, 27 Aug 2021 06:59:11 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CAE5DC000E for ; Fri, 27 Aug 2021 06:59:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AC8E04269B for ; Fri, 27 Aug 2021 06:59:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OuaUAYkb4eqw for ; Fri, 27 Aug 2021 06:59:09 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by smtp4.osuosl.org (Postfix) with ESMTPS id 0CFDA425F9 for ; Fri, 27 Aug 2021 06:59:08 +0000 (UTC) Received: by mail-pj1-x1035.google.com with SMTP id fs6so3891567pjb.4 for ; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=Ahob/aCaoxGGmBX3uT/2Oo+coR/T1tys8xgPUYlJZHQ+79x1W7tMhNYHihEb3g00Pw m+dgL0BLb9DG6XuqQrGIlpqK11vUr+Y2ytYHZ7LdTBFa1tFBJE3STgSjF41FypNGQroh EB33JFOQSvpQcvOA/KVG6FqtXl7O0+BT+q4qQg5vtIojCX29E2kJoRY1MRvb3ovAgDbp aFXAm0ssP0g7n3TLr2XOHHUaLQbsPjFKeMCjJaff6OnyliY0dDUUm9ACwqxN5BizOny5 6o6R1k1p3THp4VGKPD1gPgbF9N5SJmHFccehHvyHptaqGZoYeq1bOsTJYfzYeYbXFcTi n8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=P8qwypAa5pfRjsjLXW6D/zL3tJlXeBOuxvk5zsDB4GPfcNMFcMzISz41BidF7YYKCT WHIgpgNmK/1DTvaDzYcXC1f9ea6T1lEQnfX+IAuaPksXgXOG8shDVZe/MzKyneZ8P25C XAaGa2qEvF2ybkKa5ao535Ct8GlmoQda96BXNQZqeXjGFYB9vkApjQwVsQvAZwJ3vaEO TE6sppzDtYV7Man8fFEBQcsMAW6ve6SvEkAxD4T3L80uerh7xKHiv5RkhZY2+wKL52pX cOl/TbrnOt0OBkTqGCm/GUJLpvyblbFZ7J4SKILKFqowRz3vxWJUfQ/t5KTfu9DxS/Ga /9IA== X-Gm-Message-State: AOAM530JVovbqkbRXdB1r94p+iW5Mw1TV9xVNWZle2POB9ujbTEgxmPt xtgDLTB4Y6nafRpZ+kCU4ncvvukC01OdOF5Sx6A= X-Google-Smtp-Source: ABdhPJzbMPfKsiNwRsmJ6wf35o+bM3Vsllxj/xaKs1Zg3gEKi2+LtrBilr6TwQqyx2Jk+YbMtx83ULLwDM5rxvcqh8o= X-Received: by 2002:a17:902:bb81:b0:12d:a7ec:3d85 with SMTP id m1-20020a170902bb8100b0012da7ec3d85mr7349833pls.17.1630047548297; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) MIME-Version: 1.0 References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-11-tientzu@chromium.org> In-Reply-To: <20210624155526.2775863-11-tientzu@chromium.org> From: Andy Shevchenko Date: Fri, 27 Aug 2021 09:58:32 +0300 Message-ID: Subject: Re: [PATCH v15 10/12] swiotlb: Add restricted DMA pool initialization To: Claire Chang Cc: heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, benh@kernel.crashing.org, joonas.lahtinen@linux.intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, Frank Rowand , mingo@kernel.org, sstabellini@kernel.org, Saravana Kannan , Michael Ellerman , "Rafael J . Wysocki" , Christoph Hellwig , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , jxgao@google.com, daniel@ffwll.ch, Will Deacon , Konrad Rzeszutek Wilk , maarten.lankhorst@linux.intel.com, airlied@linux.ie, Dan Williams , linuxppc-dev@lists.ozlabs.org, jani.nikula@linux.intel.com, Rob Herring , rodrigo.vivi@intel.com, bhelgaas@google.com, Boris Ostrovsky , Andy Shevchenko , Juergen Gross , Nicolas Boichat , Greg KH , Randy Dunlap , quic_qiancai@quicinc.com, lkml , "list@263.net:IOMMU DRIVERS" , Jim Quinlan , xypron.glpk@gmx.de, thomas.lendacky@amd.com, Robin Murphy , bauerman@linux.ibm.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gVGh1LCBKdW4gMjQsIDIwMjEgYXQgNjo1OSBQTSBDbGFpcmUgQ2hhbmcgPHRpZW50enVAY2hy b21pdW0ub3JnPiB3cm90ZToKPgo+IEFkZCB0aGUgaW5pdGlhbGl6YXRpb24gZnVuY3Rpb24gdG8g Y3JlYXRlIHJlc3RyaWN0ZWQgRE1BIHBvb2xzIGZyb20KPiBtYXRjaGluZyByZXNlcnZlZC1tZW1v cnkgbm9kZXMuCj4KPiBSZWdhcmRsZXNzIG9mIHN3aW90bGIgc2V0dGluZywgdGhlIHJlc3RyaWN0 ZWQgRE1BIHBvb2wgaXMgcHJlZmVycmVkIGlmCj4gYXZhaWxhYmxlLgo+Cj4gVGhlIHJlc3RyaWN0 ZWQgRE1BIHBvb2xzIHByb3ZpZGUgYSBiYXNpYyBsZXZlbCBvZiBwcm90ZWN0aW9uIGFnYWluc3Qg dGhlCj4gRE1BIG92ZXJ3cml0aW5nIGJ1ZmZlciBjb250ZW50cyBhdCB1bmV4cGVjdGVkIHRpbWVz LiBIb3dldmVyLCB0byBwcm90ZWN0Cj4gYWdhaW5zdCBnZW5lcmFsIGRhdGEgbGVha2FnZSBhbmQg c3lzdGVtIG1lbW9yeSBjb3JydXB0aW9uLCB0aGUgc3lzdGVtCj4gbmVlZHMgdG8gcHJvdmlkZSBh IHdheSB0byBsb2NrIGRvd24gdGhlIG1lbW9yeSBhY2Nlc3MsIGUuZy4sIE1QVS4KCgoKCgo+ICtz dGF0aWMgaW50IHJtZW1fc3dpb3RsYl9kZXZpY2VfaW5pdChzdHJ1Y3QgcmVzZXJ2ZWRfbWVtICpy bWVtLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkZXZpY2Ug KmRldikKPiArewo+ICsgICAgICAgc3RydWN0IGlvX3RsYl9tZW0gKm1lbSA9IHJtZW0tPnByaXY7 Cj4gKyAgICAgICB1bnNpZ25lZCBsb25nIG5zbGFicyA9IHJtZW0tPnNpemUgPj4gSU9fVExCX1NI SUZUOwo+ICsKPiArICAgICAgIC8qCj4gKyAgICAgICAgKiBTaW5jZSBtdWx0aXBsZSBkZXZpY2Vz IGNhbiBzaGFyZSB0aGUgc2FtZSBwb29sLCB0aGUgcHJpdmF0ZSBkYXRhLAo+ICsgICAgICAgICog aW9fdGxiX21lbSBzdHJ1Y3QsIHdpbGwgYmUgaW5pdGlhbGl6ZWQgYnkgdGhlIGZpcnN0IGRldmlj ZSBhdHRhY2hlZAo+ICsgICAgICAgICogdG8gaXQuCj4gKyAgICAgICAgKi8KCj4gKyAgICAgICBp ZiAoIW1lbSkgewoKQ2FuIGl0IGJlIHJhdGhlcgoKaWYgKG1lbSkKICBnb3RvIG91dF9hc3NpZ247 CgpvciBzbz8KCj4gKyAgICAgICAgICAgICAgIG1lbSA9IGt6YWxsb2Moc3RydWN0X3NpemUobWVt LCBzbG90cywgbnNsYWJzKSwgR0ZQX0tFUk5FTCk7Cj4gKyAgICAgICAgICAgICAgIGlmICghbWVt KQo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+ICsKPiArICAgICAg ICAgICAgICAgc2V0X21lbW9yeV9kZWNyeXB0ZWQoKHVuc2lnbmVkIGxvbmcpcGh5c190b192aXJ0 KHJtZW0tPmJhc2UpLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybWVt LT5zaXplID4+IFBBR0VfU0hJRlQpOwoKQmVsb3cgeW91IGFyZSB1c2luZyBhIG1hY3JvIGZyb20g cGZuLmgsIGJ1dCBub3QgaGVyZSwgSSB0aGluayBpdCdzIFBGTl9ET1dOKCkuCgo+ICsgICAgICAg ICAgICAgICBzd2lvdGxiX2luaXRfaW9fdGxiX21lbShtZW0sIHJtZW0tPmJhc2UsIG5zbGFicywg ZmFsc2UpOwo+ICsgICAgICAgICAgICAgICBtZW0tPmZvcmNlX2JvdW5jZSA9IHRydWU7Cj4gKyAg ICAgICAgICAgICAgIG1lbS0+Zm9yX2FsbG9jID0gdHJ1ZTsKPiArCj4gKyAgICAgICAgICAgICAg IHJtZW0tPnByaXYgPSBtZW07Cj4gKwo+ICsgICAgICAgICAgICAgICBpZiAoSVNfRU5BQkxFRChD T05GSUdfREVCVUdfRlMpKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgbWVtLT5kZWJ1Z2Zz ID0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlYnVnZnNfY3JlYXRlX2Rpcihy bWVtLT5uYW1lLCBkZWJ1Z2ZzX2Rpcik7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3dpb3Rs Yl9jcmVhdGVfZGVidWdmc19maWxlcyhtZW0pOwo+ICsgICAgICAgICAgICAgICB9Cj4gKyAgICAg ICB9Cj4gKwo+ICsgICAgICAgZGV2LT5kbWFfaW9fdGxiX21lbSA9IG1lbTsKPiArCj4gKyAgICAg ICByZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgcm1lbV9zd2lvdGxiX2RldmljZV9y ZWxlYXNlKHN0cnVjdCByZXNlcnZlZF9tZW0gKnJtZW0sCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkZXZpY2UgKmRldikKPiArewo+ICsgICAgICAgZGV2 LT5kbWFfaW9fdGxiX21lbSA9IGlvX3RsYl9kZWZhdWx0X21lbTsKPiArfQo+ICsKPiArc3RhdGlj IGNvbnN0IHN0cnVjdCByZXNlcnZlZF9tZW1fb3BzIHJtZW1fc3dpb3RsYl9vcHMgPSB7Cj4gKyAg ICAgICAuZGV2aWNlX2luaXQgPSBybWVtX3N3aW90bGJfZGV2aWNlX2luaXQsCj4gKyAgICAgICAu ZGV2aWNlX3JlbGVhc2UgPSBybWVtX3N3aW90bGJfZGV2aWNlX3JlbGVhc2UsCj4gK307Cj4gKwo+ ICtzdGF0aWMgaW50IF9faW5pdCBybWVtX3N3aW90bGJfc2V0dXAoc3RydWN0IHJlc2VydmVkX21l bSAqcm1lbSkKPiArewo+ICsgICAgICAgdW5zaWduZWQgbG9uZyBub2RlID0gcm1lbS0+ZmR0X25v ZGU7Cj4gKwo+ICsgICAgICAgaWYgKG9mX2dldF9mbGF0X2R0X3Byb3Aobm9kZSwgInJldXNhYmxl IiwgTlVMTCkgfHwKPiArICAgICAgICAgICBvZl9nZXRfZmxhdF9kdF9wcm9wKG5vZGUsICJsaW51 eCxjbWEtZGVmYXVsdCIsIE5VTEwpIHx8Cj4gKyAgICAgICAgICAgb2ZfZ2V0X2ZsYXRfZHRfcHJv cChub2RlLCAibGludXgsZG1hLWRlZmF1bHQiLCBOVUxMKSB8fAo+ICsgICAgICAgICAgIG9mX2dl dF9mbGF0X2R0X3Byb3Aobm9kZSwgIm5vLW1hcCIsIE5VTEwpKQo+ICsgICAgICAgICAgICAgICBy ZXR1cm4gLUVJTlZBTDsKPiArCj4gKyAgICAgICBpZiAoUGFnZUhpZ2hNZW0ocGZuX3RvX3BhZ2Uo UEhZU19QRk4ocm1lbS0+YmFzZSkpKSkgewo+ICsgICAgICAgICAgICAgICBwcl9lcnIoIlJlc3Ry aWN0ZWQgRE1BIHBvb2wgbXVzdCBiZSBhY2Nlc3NpYmxlIHdpdGhpbiB0aGUgbGluZWFyIG1hcHBp bmcuIik7Cj4gKyAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAgICAgfQo+ICsK PiArICAgICAgIHJtZW0tPm9wcyA9ICZybWVtX3N3aW90bGJfb3BzOwo+ICsgICAgICAgcHJfaW5m bygiUmVzZXJ2ZWQgbWVtb3J5OiBjcmVhdGVkIHJlc3RyaWN0ZWQgRE1BIHBvb2wgYXQgJXBhLCBz aXplICVsZCBNaUJcbiIsCj4gKyAgICAgICAgICAgICAgICZybWVtLT5iYXNlLCAodW5zaWduZWQg bG9uZylybWVtLT5zaXplIC8gU1pfMU0pOwoKT2ggbMOgIGzDoCwgYmVzaWRlcyBleHBsaWNpdCBj YXN0aW5nIHRoYXQgSSBiZWxpZXZlIGNhbiBiZSBhdm9pZGVkLCAlbGQKIT0gdW5zaWduZWQgbG9u Zy4gQ2FuIHlvdSBjaGVjayB0aGUgcHJpbnRrLWZvcm1hdHMucnN0IGRvY3VtZW50PwoKPiArICAg ICAgIHJldHVybiAwOwo+ICt9Cj4gKwo+ICtSRVNFUlZFRE1FTV9PRl9ERUNMQVJFKGRtYSwgInJl c3RyaWN0ZWQtZG1hLXBvb2wiLCBybWVtX3N3aW90bGJfc2V0dXApOwo+ICAjZW5kaWYgLyogQ09O RklHX0RNQV9SRVNUUklDVEVEX1BPT0wgKi8KCi0tIApXaXRoIEJlc3QgUmVnYXJkcywKQW5keSBT aGV2Y2hlbmtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRw czovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC1AC4320E for ; Fri, 27 Aug 2021 06:59:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BB3860FC4 for ; Fri, 27 Aug 2021 06:59:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BB3860FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7CFD36E8E5; Fri, 27 Aug 2021 06:59:09 +0000 (UTC) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1C2B6E8E5; Fri, 27 Aug 2021 06:59:08 +0000 (UTC) Received: by mail-pl1-x62e.google.com with SMTP id e1so3340072plt.11; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=Ahob/aCaoxGGmBX3uT/2Oo+coR/T1tys8xgPUYlJZHQ+79x1W7tMhNYHihEb3g00Pw m+dgL0BLb9DG6XuqQrGIlpqK11vUr+Y2ytYHZ7LdTBFa1tFBJE3STgSjF41FypNGQroh EB33JFOQSvpQcvOA/KVG6FqtXl7O0+BT+q4qQg5vtIojCX29E2kJoRY1MRvb3ovAgDbp aFXAm0ssP0g7n3TLr2XOHHUaLQbsPjFKeMCjJaff6OnyliY0dDUUm9ACwqxN5BizOny5 6o6R1k1p3THp4VGKPD1gPgbF9N5SJmHFccehHvyHptaqGZoYeq1bOsTJYfzYeYbXFcTi n8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=Wd3/Hkm1eXJtEn8Kx9vdzAudtryFZpOafpAkKmyyZluh0MeV89pMacuZJA8A4IW3Gg VQBMeGzjd6j+EPGqh+jONrTbm5+6A/EW9a7zZeSEP1BxU3dzFsQH79P9X6XjJzCZo48d f9W4p9ECeEK4dlfnXYXPs62SDCNi10XyIk8sh5ZstyboJ6l0XlnwrhCVXlsm9Egqle0Q x5afBxD1BjdMvN7znmn67HlPhuEvj2HOfCUIXZk9WVuHRa+Ylc2HnyRQMhHZKc9UK53x Ipe5BhkkSnLjhM7xPVaJHVaenNC4k58bvl1z6vMXye03e/VmBApsYKGtOymO8R5jeiJA E/PQ== X-Gm-Message-State: AOAM533YofVZvENYxuBB3ekdW37PAZGmCOpwL2UsnLe3zsVNHi9uhQgS UTRPNzcFujFwVOuJ1flPW0ALAKyz/nXJcT5O3kk= X-Google-Smtp-Source: ABdhPJzbMPfKsiNwRsmJ6wf35o+bM3Vsllxj/xaKs1Zg3gEKi2+LtrBilr6TwQqyx2Jk+YbMtx83ULLwDM5rxvcqh8o= X-Received: by 2002:a17:902:bb81:b0:12d:a7ec:3d85 with SMTP id m1-20020a170902bb8100b0012da7ec3d85mr7349833pls.17.1630047548297; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) MIME-Version: 1.0 References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-11-tientzu@chromium.org> In-Reply-To: <20210624155526.2775863-11-tientzu@chromium.org> From: Andy Shevchenko Date: Fri, 27 Aug 2021 09:58:32 +0300 Message-ID: Subject: Re: [PATCH v15 10/12] swiotlb: Add restricted DMA pool initialization To: Claire Chang Cc: Rob Herring , Michael Ellerman , Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , tfiga@chromium.org, bskeggs@redhat.com, bhelgaas@google.com, chris@chris-wilson.co.uk, daniel@ffwll.ch, airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jxgao@google.com, joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, thomas.lendacky@amd.com, quic_qiancai@quicinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 24, 2021 at 6:59 PM Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes. > > Regardless of swiotlb setting, the restricted DMA pool is preferred if > available. > > The restricted DMA pools provide a basic level of protection against the > DMA overwriting buffer contents at unexpected times. However, to protect > against general data leakage and system memory corruption, the system > needs to provide a way to lock down the memory access, e.g., MPU. > +static int rmem_swiotlb_device_init(struct reserved_mem *rmem, > + struct device *dev) > +{ > + struct io_tlb_mem *mem =3D rmem->priv; > + unsigned long nslabs =3D rmem->size >> IO_TLB_SHIFT; > + > + /* > + * Since multiple devices can share the same pool, the private da= ta, > + * io_tlb_mem struct, will be initialized by the first device att= ached > + * to it. > + */ > + if (!mem) { Can it be rather if (mem) goto out_assign; or so? > + mem =3D kzalloc(struct_size(mem, slots, nslabs), GFP_KERN= EL); > + if (!mem) > + return -ENOMEM; > + > + set_memory_decrypted((unsigned long)phys_to_virt(rmem->ba= se), > + rmem->size >> PAGE_SHIFT); Below you are using a macro from pfn.h, but not here, I think it's PFN_DOWN= (). > + swiotlb_init_io_tlb_mem(mem, rmem->base, nslabs, false); > + mem->force_bounce =3D true; > + mem->for_alloc =3D true; > + > + rmem->priv =3D mem; > + > + if (IS_ENABLED(CONFIG_DEBUG_FS)) { > + mem->debugfs =3D > + debugfs_create_dir(rmem->name, debugfs_di= r); > + swiotlb_create_debugfs_files(mem); > + } > + } > + > + dev->dma_io_tlb_mem =3D mem; > + > + return 0; > +} > + > +static void rmem_swiotlb_device_release(struct reserved_mem *rmem, > + struct device *dev) > +{ > + dev->dma_io_tlb_mem =3D io_tlb_default_mem; > +} > + > +static const struct reserved_mem_ops rmem_swiotlb_ops =3D { > + .device_init =3D rmem_swiotlb_device_init, > + .device_release =3D rmem_swiotlb_device_release, > +}; > + > +static int __init rmem_swiotlb_setup(struct reserved_mem *rmem) > +{ > + unsigned long node =3D rmem->fdt_node; > + > + if (of_get_flat_dt_prop(node, "reusable", NULL) || > + of_get_flat_dt_prop(node, "linux,cma-default", NULL) || > + of_get_flat_dt_prop(node, "linux,dma-default", NULL) || > + of_get_flat_dt_prop(node, "no-map", NULL)) > + return -EINVAL; > + > + if (PageHighMem(pfn_to_page(PHYS_PFN(rmem->base)))) { > + pr_err("Restricted DMA pool must be accessible within the= linear mapping."); > + return -EINVAL; > + } > + > + rmem->ops =3D &rmem_swiotlb_ops; > + pr_info("Reserved memory: created restricted DMA pool at %pa, siz= e %ld MiB\n", > + &rmem->base, (unsigned long)rmem->size / SZ_1M); Oh l=C3=A0 l=C3=A0, besides explicit casting that I believe can be avoided,= %ld !=3D unsigned long. Can you check the printk-formats.rst document? > + return 0; > +} > + > +RESERVEDMEM_OF_DECLARE(dma, "restricted-dma-pool", rmem_swiotlb_setup); > #endif /* CONFIG_DMA_RESTRICTED_POOL */ --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58EE1C4320E for ; Fri, 27 Aug 2021 06:59:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27E8660FC4 for ; Fri, 27 Aug 2021 06:59:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 27E8660FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACDB16E8E6; Fri, 27 Aug 2021 06:59:09 +0000 (UTC) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1C2B6E8E5; Fri, 27 Aug 2021 06:59:08 +0000 (UTC) Received: by mail-pl1-x62e.google.com with SMTP id e1so3340072plt.11; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=Ahob/aCaoxGGmBX3uT/2Oo+coR/T1tys8xgPUYlJZHQ+79x1W7tMhNYHihEb3g00Pw m+dgL0BLb9DG6XuqQrGIlpqK11vUr+Y2ytYHZ7LdTBFa1tFBJE3STgSjF41FypNGQroh EB33JFOQSvpQcvOA/KVG6FqtXl7O0+BT+q4qQg5vtIojCX29E2kJoRY1MRvb3ovAgDbp aFXAm0ssP0g7n3TLr2XOHHUaLQbsPjFKeMCjJaff6OnyliY0dDUUm9ACwqxN5BizOny5 6o6R1k1p3THp4VGKPD1gPgbF9N5SJmHFccehHvyHptaqGZoYeq1bOsTJYfzYeYbXFcTi n8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=Wd3/Hkm1eXJtEn8Kx9vdzAudtryFZpOafpAkKmyyZluh0MeV89pMacuZJA8A4IW3Gg VQBMeGzjd6j+EPGqh+jONrTbm5+6A/EW9a7zZeSEP1BxU3dzFsQH79P9X6XjJzCZo48d f9W4p9ECeEK4dlfnXYXPs62SDCNi10XyIk8sh5ZstyboJ6l0XlnwrhCVXlsm9Egqle0Q x5afBxD1BjdMvN7znmn67HlPhuEvj2HOfCUIXZk9WVuHRa+Ylc2HnyRQMhHZKc9UK53x Ipe5BhkkSnLjhM7xPVaJHVaenNC4k58bvl1z6vMXye03e/VmBApsYKGtOymO8R5jeiJA E/PQ== X-Gm-Message-State: AOAM533YofVZvENYxuBB3ekdW37PAZGmCOpwL2UsnLe3zsVNHi9uhQgS UTRPNzcFujFwVOuJ1flPW0ALAKyz/nXJcT5O3kk= X-Google-Smtp-Source: ABdhPJzbMPfKsiNwRsmJ6wf35o+bM3Vsllxj/xaKs1Zg3gEKi2+LtrBilr6TwQqyx2Jk+YbMtx83ULLwDM5rxvcqh8o= X-Received: by 2002:a17:902:bb81:b0:12d:a7ec:3d85 with SMTP id m1-20020a170902bb8100b0012da7ec3d85mr7349833pls.17.1630047548297; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) MIME-Version: 1.0 References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-11-tientzu@chromium.org> In-Reply-To: <20210624155526.2775863-11-tientzu@chromium.org> From: Andy Shevchenko Date: Fri, 27 Aug 2021 09:58:32 +0300 Message-ID: To: Claire Chang Cc: Rob Herring , Michael Ellerman , Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , Christoph Hellwig , Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , tfiga@chromium.org, bskeggs@redhat.com, bhelgaas@google.com, chris@chris-wilson.co.uk, daniel@ffwll.ch, airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, jxgao@google.com, joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, thomas.lendacky@amd.com, quic_qiancai@quicinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH v15 10/12] swiotlb: Add restricted DMA pool initialization X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jun 24, 2021 at 6:59 PM Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes. > > Regardless of swiotlb setting, the restricted DMA pool is preferred if > available. > > The restricted DMA pools provide a basic level of protection against the > DMA overwriting buffer contents at unexpected times. However, to protect > against general data leakage and system memory corruption, the system > needs to provide a way to lock down the memory access, e.g., MPU. > +static int rmem_swiotlb_device_init(struct reserved_mem *rmem, > + struct device *dev) > +{ > + struct io_tlb_mem *mem =3D rmem->priv; > + unsigned long nslabs =3D rmem->size >> IO_TLB_SHIFT; > + > + /* > + * Since multiple devices can share the same pool, the private da= ta, > + * io_tlb_mem struct, will be initialized by the first device att= ached > + * to it. > + */ > + if (!mem) { Can it be rather if (mem) goto out_assign; or so? > + mem =3D kzalloc(struct_size(mem, slots, nslabs), GFP_KERN= EL); > + if (!mem) > + return -ENOMEM; > + > + set_memory_decrypted((unsigned long)phys_to_virt(rmem->ba= se), > + rmem->size >> PAGE_SHIFT); Below you are using a macro from pfn.h, but not here, I think it's PFN_DOWN= (). > + swiotlb_init_io_tlb_mem(mem, rmem->base, nslabs, false); > + mem->force_bounce =3D true; > + mem->for_alloc =3D true; > + > + rmem->priv =3D mem; > + > + if (IS_ENABLED(CONFIG_DEBUG_FS)) { > + mem->debugfs =3D > + debugfs_create_dir(rmem->name, debugfs_di= r); > + swiotlb_create_debugfs_files(mem); > + } > + } > + > + dev->dma_io_tlb_mem =3D mem; > + > + return 0; > +} > + > +static void rmem_swiotlb_device_release(struct reserved_mem *rmem, > + struct device *dev) > +{ > + dev->dma_io_tlb_mem =3D io_tlb_default_mem; > +} > + > +static const struct reserved_mem_ops rmem_swiotlb_ops =3D { > + .device_init =3D rmem_swiotlb_device_init, > + .device_release =3D rmem_swiotlb_device_release, > +}; > + > +static int __init rmem_swiotlb_setup(struct reserved_mem *rmem) > +{ > + unsigned long node =3D rmem->fdt_node; > + > + if (of_get_flat_dt_prop(node, "reusable", NULL) || > + of_get_flat_dt_prop(node, "linux,cma-default", NULL) || > + of_get_flat_dt_prop(node, "linux,dma-default", NULL) || > + of_get_flat_dt_prop(node, "no-map", NULL)) > + return -EINVAL; > + > + if (PageHighMem(pfn_to_page(PHYS_PFN(rmem->base)))) { > + pr_err("Restricted DMA pool must be accessible within the= linear mapping."); > + return -EINVAL; > + } > + > + rmem->ops =3D &rmem_swiotlb_ops; > + pr_info("Reserved memory: created restricted DMA pool at %pa, siz= e %ld MiB\n", > + &rmem->base, (unsigned long)rmem->size / SZ_1M); Oh l=C3=A0 l=C3=A0, besides explicit casting that I believe can be avoided,= %ld !=3D unsigned long. Can you check the printk-formats.rst document? > + return 0; > +} > + > +RESERVEDMEM_OF_DECLARE(dma, "restricted-dma-pool", rmem_swiotlb_setup); > #endif /* CONFIG_DMA_RESTRICTED_POOL */ --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99886C4320A for ; Fri, 27 Aug 2021 06:59:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68A3E60FD8 for ; Fri, 27 Aug 2021 06:59:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 68A3E60FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GwrF54VGjz3096 for ; Fri, 27 Aug 2021 16:59:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Ahob/aCa; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::632; helo=mail-pl1-x632.google.com; envelope-from=andy.shevchenko@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Ahob/aCa; dkim-atps=neutral Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GwrDK4rwrz2yPq for ; Fri, 27 Aug 2021 16:59:11 +1000 (AEST) Received: by mail-pl1-x632.google.com with SMTP id m4so3389897pll.0 for ; Thu, 26 Aug 2021 23:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=Ahob/aCaoxGGmBX3uT/2Oo+coR/T1tys8xgPUYlJZHQ+79x1W7tMhNYHihEb3g00Pw m+dgL0BLb9DG6XuqQrGIlpqK11vUr+Y2ytYHZ7LdTBFa1tFBJE3STgSjF41FypNGQroh EB33JFOQSvpQcvOA/KVG6FqtXl7O0+BT+q4qQg5vtIojCX29E2kJoRY1MRvb3ovAgDbp aFXAm0ssP0g7n3TLr2XOHHUaLQbsPjFKeMCjJaff6OnyliY0dDUUm9ACwqxN5BizOny5 6o6R1k1p3THp4VGKPD1gPgbF9N5SJmHFccehHvyHptaqGZoYeq1bOsTJYfzYeYbXFcTi n8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rqn+GrCddwb17438Eb7/acjTBeKWly1ebyK4GCadnFc=; b=FstEEy/AisEuN8d3AMzeUqzleDXv13mISTcI61sbNnGOT8ni0Uv8XWpg8ko6s1ELOn m/zhSD6tJZsfZ/S20f11rMkSL8zcWWe9hLjEnDJl2WQUm/xXoj7okpJzXWopEaJcSjk8 +0G0W90ZltcPnmQyL924GqJCsNa3GQ4BBHm6q4r/OV5bK8HEouaxOiKxzbM6Q6/QsbJd 6MnknNmvAIHRngYoPWjesq9T4sKfURxv9jMt98MZgEHgDPmNOV1WSSgBwx6d+zrZ0Ry8 NGiKz7qzXEqtCGrw1fR4d2mBHWuFOaD0UPncgVsT2VFuU8h+khYy6JXDvIqmF/T6QXUI TeUw== X-Gm-Message-State: AOAM5330BjDwr9NOL+00GrOkCxWgoC1cin/H7K/p+iUdGdkPXy5W/PUo hzIO/L8TgxoMMFoBFS2KscUPrZrikXBr+qQIE4E= X-Google-Smtp-Source: ABdhPJzbMPfKsiNwRsmJ6wf35o+bM3Vsllxj/xaKs1Zg3gEKi2+LtrBilr6TwQqyx2Jk+YbMtx83ULLwDM5rxvcqh8o= X-Received: by 2002:a17:902:bb81:b0:12d:a7ec:3d85 with SMTP id m1-20020a170902bb8100b0012da7ec3d85mr7349833pls.17.1630047548297; Thu, 26 Aug 2021 23:59:08 -0700 (PDT) MIME-Version: 1.0 References: <20210624155526.2775863-1-tientzu@chromium.org> <20210624155526.2775863-11-tientzu@chromium.org> In-Reply-To: <20210624155526.2775863-11-tientzu@chromium.org> From: Andy Shevchenko Date: Fri, 27 Aug 2021 09:58:32 +0300 Message-ID: Subject: Re: [PATCH v15 10/12] swiotlb: Add restricted DMA pool initialization To: Claire Chang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heikki.krogerus@linux.intel.com, thomas.hellstrom@linux.intel.com, peterz@infradead.org, joonas.lahtinen@linux.intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, grant.likely@arm.com, paulus@samba.org, Frank Rowand , mingo@kernel.org, Marek Szyprowski , sstabellini@kernel.org, Saravana Kannan , Joerg Roedel , "Rafael J . Wysocki" , Christoph Hellwig , Bartosz Golaszewski , bskeggs@redhat.com, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Thierry Reding , intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, linux-devicetree , jxgao@google.com, daniel@ffwll.ch, Will Deacon , Konrad Rzeszutek Wilk , maarten.lankhorst@linux.intel.com, airlied@linux.ie, Dan Williams , linuxppc-dev@lists.ozlabs.org, jani.nikula@linux.intel.com, Rob Herring , rodrigo.vivi@intel.com, bhelgaas@google.com, Boris Ostrovsky , Andy Shevchenko , Juergen Gross , Nicolas Boichat , Greg KH , Randy Dunlap , quic_qiancai@quicinc.com, lkml , tfiga@chromium.org, "list@263.net:IOMMU DRIVERS" , Jim Quinlan , xypron.glpk@gmx.de, thomas.lendacky@amd.com, Robin Murphy , bauerman@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jun 24, 2021 at 6:59 PM Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes. > > Regardless of swiotlb setting, the restricted DMA pool is preferred if > available. > > The restricted DMA pools provide a basic level of protection against the > DMA overwriting buffer contents at unexpected times. However, to protect > against general data leakage and system memory corruption, the system > needs to provide a way to lock down the memory access, e.g., MPU. > +static int rmem_swiotlb_device_init(struct reserved_mem *rmem, > + struct device *dev) > +{ > + struct io_tlb_mem *mem =3D rmem->priv; > + unsigned long nslabs =3D rmem->size >> IO_TLB_SHIFT; > + > + /* > + * Since multiple devices can share the same pool, the private da= ta, > + * io_tlb_mem struct, will be initialized by the first device att= ached > + * to it. > + */ > + if (!mem) { Can it be rather if (mem) goto out_assign; or so? > + mem =3D kzalloc(struct_size(mem, slots, nslabs), GFP_KERN= EL); > + if (!mem) > + return -ENOMEM; > + > + set_memory_decrypted((unsigned long)phys_to_virt(rmem->ba= se), > + rmem->size >> PAGE_SHIFT); Below you are using a macro from pfn.h, but not here, I think it's PFN_DOWN= (). > + swiotlb_init_io_tlb_mem(mem, rmem->base, nslabs, false); > + mem->force_bounce =3D true; > + mem->for_alloc =3D true; > + > + rmem->priv =3D mem; > + > + if (IS_ENABLED(CONFIG_DEBUG_FS)) { > + mem->debugfs =3D > + debugfs_create_dir(rmem->name, debugfs_di= r); > + swiotlb_create_debugfs_files(mem); > + } > + } > + > + dev->dma_io_tlb_mem =3D mem; > + > + return 0; > +} > + > +static void rmem_swiotlb_device_release(struct reserved_mem *rmem, > + struct device *dev) > +{ > + dev->dma_io_tlb_mem =3D io_tlb_default_mem; > +} > + > +static const struct reserved_mem_ops rmem_swiotlb_ops =3D { > + .device_init =3D rmem_swiotlb_device_init, > + .device_release =3D rmem_swiotlb_device_release, > +}; > + > +static int __init rmem_swiotlb_setup(struct reserved_mem *rmem) > +{ > + unsigned long node =3D rmem->fdt_node; > + > + if (of_get_flat_dt_prop(node, "reusable", NULL) || > + of_get_flat_dt_prop(node, "linux,cma-default", NULL) || > + of_get_flat_dt_prop(node, "linux,dma-default", NULL) || > + of_get_flat_dt_prop(node, "no-map", NULL)) > + return -EINVAL; > + > + if (PageHighMem(pfn_to_page(PHYS_PFN(rmem->base)))) { > + pr_err("Restricted DMA pool must be accessible within the= linear mapping."); > + return -EINVAL; > + } > + > + rmem->ops =3D &rmem_swiotlb_ops; > + pr_info("Reserved memory: created restricted DMA pool at %pa, siz= e %ld MiB\n", > + &rmem->base, (unsigned long)rmem->size / SZ_1M); Oh l=C3=A0 l=C3=A0, besides explicit casting that I believe can be avoided,= %ld !=3D unsigned long. Can you check the printk-formats.rst document? > + return 0; > +} > + > +RESERVEDMEM_OF_DECLARE(dma, "restricted-dma-pool", rmem_swiotlb_setup); > #endif /* CONFIG_DMA_RESTRICTED_POOL */ --=20 With Best Regards, Andy Shevchenko