From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Liming Sun <lsun@mellanox.com>
Cc: Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Vadim Pasternak <vadimp@mellanox.com>,
David Woods <dwoods@mellanox.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] platform/mellanox: fix the mlx-bootctl sysfs
Date: Wed, 18 Dec 2019 19:59:43 +0200 [thread overview]
Message-ID: <CAHp75VfYwxviATZnmYcgzkKKGw47ki=BZQYw4xRmUrfNqsiBww@mail.gmail.com> (raw)
In-Reply-To: <1576682676-31957-1-git-send-email-lsun@mellanox.com>
On Wed, Dec 18, 2019 at 5:25 PM Liming Sun <lsun@mellanox.com> wrote:
>
> This is a follow-up commit for the sysfs attributes to change
> from DRIVER_ATTR to DEVICE_ATTR according to some initial comments.
> In such case, it's better to point the sysfs path to the device
> itself instead of the driver. The ABI document is also updated.
>
> Fixes: 79e29cb8fbc5 ("platform/mellanox: Add bootctl driver for Mellanox BlueField Soc")
> Signed-off-by: Liming Sun <lsun@mellanox.com>
...
> -ATTRIBUTE_GROUPS(mlxbf_bootctl);
What's wrong with above macro?
> +static const struct attribute_group mlxbf_bootctl_group = {
> + .attrs = mlxbf_bootctl_attrs,
> +};
...
> +static const struct attribute_group *mlxbf_bootctl_dev_groups[] = {
> + &mlxbf_bootctl_group,
> + NULL
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-12-18 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 19:23 [PATCH v1 1/1] platform/mellanox: fix the mlx-bootctl sysfs Liming Sun
2019-12-13 10:21 ` Andy Shevchenko
2019-12-13 15:22 ` Liming Sun
2019-12-13 15:21 ` [PATCH v2] " Liming Sun
2019-12-18 13:00 ` Andy Shevchenko
2019-12-18 15:26 ` Liming Sun
2019-12-18 15:24 ` [PATCH v3] " Liming Sun
2019-12-18 17:59 ` Andy Shevchenko [this message]
2019-12-18 18:36 ` Liming Sun
2019-12-18 18:35 ` [PATCH v4] " Liming Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfYwxviATZnmYcgzkKKGw47ki=BZQYw4xRmUrfNqsiBww@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=dwoods@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsun@mellanox.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.