From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbdF2L4K (ORCPT ); Thu, 29 Jun 2017 07:56:10 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35348 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbdF2L4F (ORCPT ); Thu, 29 Jun 2017 07:56:05 -0400 MIME-Version: 1.0 In-Reply-To: <1498736351-9021-3-git-send-email-claudiu.beznea@microchip.com> References: <1498736351-9021-1-git-send-email-claudiu.beznea@microchip.com> <1498736351-9021-3-git-send-email-claudiu.beznea@microchip.com> From: Andy Shevchenko Date: Thu, 29 Jun 2017 14:56:03 +0300 Message-ID: Subject: Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses To: Claudiu Beznea Cc: Rob Herring , Mark Rutland , Sekhar Nori , David Lechner , Wolfram Sang , devicetree , "linux-kernel@vger.kernel.org" , linux-i2c , Nicolas Ferre Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea wrote: > Add support for reading from different offsets of EEPROM. > The offset is initialized via device tree. If nothing is > given as input the old value, 0x90, is used. In this way > the driver could be used as generic driver for different > vendor memories by only changing the reading offset via > device tree. > + err = device_property_read_u8(dev, "start-offset", &chip->offset); This property has to be documented. Moreover, the name looks too broad (I checked current use of "*-offset" type of properties and they either vendor specific, or data type specific. Taking above into consideration mac-offset sounds better to me. -- With Best Regards, Andy Shevchenko