From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH v2 2/2] gpio: pca9570: add pca9571 support
Date: Wed, 29 Jun 2022 23:18:29 +0200 [thread overview]
Message-ID: <CAHp75VfbNz-gpGuDu3F_HixD3+izYpOPwNe2-EW0Mr5=46uUPg@mail.gmail.com> (raw)
In-Reply-To: <20220629170420.2712077-2-l.stach@pengutronix.de>
On Wed, Jun 29, 2022 at 7:18 PM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> The PCA9571 very similar to the PCA9570, it only differs in the
> number of GPIOs.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/gpio/gpio-pca9570.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c
> index cb2b2f735c15..ab2a652964ec 100644
> --- a/drivers/gpio/gpio-pca9570.c
> +++ b/drivers/gpio/gpio-pca9570.c
> @@ -121,12 +121,14 @@ static int pca9570_probe(struct i2c_client *client)
>
> static const struct i2c_device_id pca9570_id_table[] = {
> { "pca9570", 4 },
> + { "pca9571", 8 },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(i2c, pca9570_id_table);
>
> static const struct of_device_id pca9570_of_match_table[] = {
> { .compatible = "nxp,pca9570", .data = (void *)4 },
> + { .compatible = "nxp,pca9571", .data = (void *)8 },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, pca9570_of_match_table);
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-29 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 17:04 [PATCH v2 1/2] gpio: pca9570: Add DT bindings for NXP PCA9571 Lucas Stach
2022-06-29 17:04 ` [PATCH v2 2/2] gpio: pca9570: add pca9571 support Lucas Stach
2022-06-29 21:18 ` Andy Shevchenko [this message]
2022-07-01 9:20 ` Bartosz Golaszewski
2022-06-29 17:46 ` [PATCH v2 1/2] gpio: pca9570: Add DT bindings for NXP PCA9571 Krzysztof Kozlowski
2022-07-01 9:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfbNz-gpGuDu3F_HixD3+izYpOPwNe2-EW0Mr5=46uUPg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.