All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Krivenok <krivenok.dmitry@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used.
Date: Sun, 13 Dec 2015 03:13:46 +0200	[thread overview]
Message-ID: <CAHp75VfdGJtDia5oqVWzJ_pWKm=-BrHThN_9Uz8QU2c9ZT5PJA@mail.gmail.com> (raw)
In-Reply-To: <CAJN_NGb36NPwCPMHstU2Dck=BVAr9J1-cFcNjzhftxidNiWXww@mail.gmail.com>

On Mon, Nov 30, 2015 at 10:33 PM, Dmitry Krivenok
<krivenok.dmitry@gmail.com> wrote:
>>>      if (size > max_size) {
>>>          dev_err(pcie->dev,
>>> -            "res size 0x%pap exceeds max supported size 0x%llx\n",
>>> +            "res size %pap exceeds max supported size 0x%llx\n",
>>
>> %pa also works.
>>
>
> Yes, but AFAIK %pap and %pa are identical (see address_val() in lib/vsprintf.c),
> so I'm not sure I understand your comment.
>
> Did you mean that %pa should be used instead of %pap?
> I see that %pa is used much more often than %pap, but I didn't find any
> evidence that %pap is deprecated.

+Rasmus.

No, it's not, but it explicitly for phys_addr_t (it might be nice to
to have %par, for example for explicitly shown that is for
resource_size_t, Rasmus?).

For my opinion for resources better to use %pa for now, though %pap
will work as well.

-- 
With Best Regards,
Andy Shevchenko

      reply	other threads:[~2015-12-13  1:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 19:16 [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used Dmitry Krivenok
2015-11-25 20:19 ` Andy Shevchenko
2015-11-30 20:33   ` Dmitry Krivenok
2015-12-13  1:13     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VfdGJtDia5oqVWzJ_pWKm=-BrHThN_9Uz8QU2c9ZT5PJA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=krivenok.dmitry@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.