From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 500A7C48BD1 for ; Fri, 11 Jun 2021 09:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3414A613C8 for ; Fri, 11 Jun 2021 09:01:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231283AbhFKJD2 (ORCPT ); Fri, 11 Jun 2021 05:03:28 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:43710 "EHLO mail-pl1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230460AbhFKJD1 (ORCPT ); Fri, 11 Jun 2021 05:03:27 -0400 Received: by mail-pl1-f173.google.com with SMTP id v12so2504224plo.10; Fri, 11 Jun 2021 02:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIlvnpCPbICwDJ4Vl00FPiAYRz1ggW2QfBtE3qOeQVk=; b=TCKGtdywZsQ0mUdoNA1VIXMy1S4UFr0Ur7QxJ8scHxxHbnqqyS3zEccbMsxmjBTYF1 m5rPzJFtJuk4Y8f048RqUFJ2pXMI/EOQ8zAqiQ6Akh1+HrXreQP6fO83PnO7auH/J72A W9ugS5yt3wF/4/3yY6ZpFl/Se6GdI4MXMq9oM4+Pjfc7iEajS3aeMqnsYPrH012T1JmA O+kcBd9nMucev4zJwCRO6GxNVUibopNwpiTs7VsqPHd2aRj2/7kn8fqR527gbCQbT8K4 x+8+w37HZ7gyaUzd1KRNEj7YiE8h5f7EgBK85+PltyFgMEZ+ObAF07llCg276oaM2umZ qeiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIlvnpCPbICwDJ4Vl00FPiAYRz1ggW2QfBtE3qOeQVk=; b=N95S2MhLkYQru+a5U6vwPC1YeDyPoKNlqjNF2zhF+vM2xGWrlMFOEhVSF3S9R+Unv2 jX4+o+iGJBH+ZfASXlMG8LjCeu5kSmApjpqKbHe4OtWuwtmejYVx4xQGAobJQxXgqiZe ts888de+dRgbilLs2AeaRSxsxR8FkBLWinjpDC9UekyDEu5qJrW2GYQXMjcXPByytZPK J3VagULo+TXAvvSsj2nj6P6dTCIZgGf5UNe00JBFXRQJaUr8thBbR2eZeQss1J0Vo/8G MpAkwkqK4ztQW1fBHyXSKlVrlWuSCbhD7dJ4x6e6Fv77zrnU3JPa2F3SXRf7HcvFx+wO epLA== X-Gm-Message-State: AOAM533U9RxSKoXtE/fKayTaoVExowa01hy5esHOutMxFY6Su/IwHSWU TiEbToZxVAO6T3BHGGN9/pA9KDnKvEkYUGC4pSQ= X-Google-Smtp-Source: ABdhPJzWieTjQAnrXBUrCrA/glfRXSe+6PTqF2ceabrTCs2gWSFNY6hUn/WuRybe32pJBCyFKUReYtmPNT/trGAAtQE= X-Received: by 2002:a17:90b:818:: with SMTP id bk24mr3566082pjb.228.1623402018625; Fri, 11 Jun 2021 02:00:18 -0700 (PDT) MIME-Version: 1.0 References: <20210610163917.4138412-1-ciorneiioana@gmail.com> In-Reply-To: <20210610163917.4138412-1-ciorneiioana@gmail.com> From: Andy Shevchenko Date: Fri, 11 Jun 2021 12:00:02 +0300 Message-ID: Subject: Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver To: Ioana Ciornei Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Calvin Johnson , Cristi Sovaiala , Florin Laurentiu Chiculita , Madalin Bucur , linux-arm Mailing List , Diana Madalina Craciun , ACPI Devel Maling List , Linux Kernel Mailing List , "linux.cj" , netdev , Laurentiu Tudor , Len Brown , "Rafael J . Wysocki" , Ioana Ciornei Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei wrote: > > From: Ioana Ciornei > > This patch set provides ACPI support to DPAA2 network drivers. > > It also introduces new fwnode based APIs to support phylink and phy > layers > Following functions are defined: > phylink_fwnode_phy_connect() > fwnode_mdiobus_register_phy() > fwnode_get_phy_id() > fwnode_phy_find_device() > device_phy_find_device() > fwnode_get_phy_node() > fwnode_mdio_find_device() > acpi_get_local_address() > > First one helps in connecting phy to phylink instance. > Next three helps in getting phy_id and registering phy to mdiobus > Next two help in finding a phy on a mdiobus. > Next one helps in getting phy_node from a fwnode. > Last one is used to get local address from _ADR object. > > Corresponding OF functions are refactored. In general it looks fine to me. What really worries me is the calls like of_foo -> fwnode_bar -> of_baz. As I have commented in one patch the idea of fwnode APIs is to have a common ground for all resource providers. So, at the end it shouldn't be a chain of calls like above mentioned. Either fix the name (so, the first one will be in fwnode or device namespace) or fix the API that it will be fwnode/device API. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E10C48BE5 for ; Fri, 11 Jun 2021 09:03:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9591613CB for ; Fri, 11 Jun 2021 09:03:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9591613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W779v2I8JnBZLQFhavW7x6jRwiatPgFtkM9TdAsHA3U=; b=4mY4Eii+VKLz2H qEYoSFYEbwxw7PVzkN7eRJURWAPmrfzWcHMfFKxMLITdCPGoYSUR9BoEZr6Gq2YqNNt1hBxkJi/xo B29LKlC4w11SIrhLB5C8EcKgth1czf1bF/LvzlkxfG81FLPZKIeyNET/Bo8THCcXLN/i+djIBDGLh uXaFLmzwiZZ1FxDFKxYfyXgqXpAHZ68pzcZC5pFYB93gJyhaG7ka2Rcy852ItUOQXOR6Yq7ohKglX r1mmgE9aE/1be4skrvrU13ntUbGUeij1EqTwYyqzu/+rkB0Mvism4cPbIVTCmw+ZN/vKngfvEwCs8 Fdvhq/2xdG0YvRn1kS2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrd2Z-004QQz-7r; Fri, 11 Jun 2021 09:01:23 +0000 Received: from mail-pj1-f43.google.com ([209.85.216.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrd2V-004QPe-9B for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 09:01:20 +0000 Received: by mail-pj1-f43.google.com with SMTP id k5so5343404pjj.1 for ; Fri, 11 Jun 2021 02:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIlvnpCPbICwDJ4Vl00FPiAYRz1ggW2QfBtE3qOeQVk=; b=TCKGtdywZsQ0mUdoNA1VIXMy1S4UFr0Ur7QxJ8scHxxHbnqqyS3zEccbMsxmjBTYF1 m5rPzJFtJuk4Y8f048RqUFJ2pXMI/EOQ8zAqiQ6Akh1+HrXreQP6fO83PnO7auH/J72A W9ugS5yt3wF/4/3yY6ZpFl/Se6GdI4MXMq9oM4+Pjfc7iEajS3aeMqnsYPrH012T1JmA O+kcBd9nMucev4zJwCRO6GxNVUibopNwpiTs7VsqPHd2aRj2/7kn8fqR527gbCQbT8K4 x+8+w37HZ7gyaUzd1KRNEj7YiE8h5f7EgBK85+PltyFgMEZ+ObAF07llCg276oaM2umZ qeiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIlvnpCPbICwDJ4Vl00FPiAYRz1ggW2QfBtE3qOeQVk=; b=ph2HpwuY5pkiQg0U6gVhRIUJmBbxXQ+jsdYYBMrYv36bLgIhhRwtwBaw/Ak/lssRDx /X/yMkDBRHAlaLIWvufILbX8lqbxmZ3xRt7TbInsW12taDBNzbeheAKXLdyUrJ1TciRX q+zQhozYP356zqRK9aOgLpFUR7JeVAgcF84jwyxLhP8I/wK3CiTWYg88yMhRkMoRGpJ7 I4L7ambzdYI49a2/i3mVAW8+i3au5h9NNMAkctYee36W7ntIwFpppB9oG5SoyNUpen+M w17jHntQhJTCXcowcT7SvwoBXcXRTjO1ZKiMnQfWe5BKvai3CjPSPCcpShWGrtXOHCPj hSaQ== X-Gm-Message-State: AOAM531t4Ngt/R930Lb3CXW1T3ZNpwix3dG0NN/kLHlbUQGmtQ5aIfML zeQCPWCGd4XTqnwsSCP4QIgUn50qSMWwqVMujgc= X-Google-Smtp-Source: ABdhPJzWieTjQAnrXBUrCrA/glfRXSe+6PTqF2ceabrTCs2gWSFNY6hUn/WuRybe32pJBCyFKUReYtmPNT/trGAAtQE= X-Received: by 2002:a17:90b:818:: with SMTP id bk24mr3566082pjb.228.1623402018625; Fri, 11 Jun 2021 02:00:18 -0700 (PDT) MIME-Version: 1.0 References: <20210610163917.4138412-1-ciorneiioana@gmail.com> In-Reply-To: <20210610163917.4138412-1-ciorneiioana@gmail.com> From: Andy Shevchenko Date: Fri, 11 Jun 2021 12:00:02 +0300 Message-ID: Subject: Re: [PATCH net-next v8 00/15] ACPI support for dpaa2 driver To: Ioana Ciornei Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Calvin Johnson , Cristi Sovaiala , Florin Laurentiu Chiculita , Madalin Bucur , linux-arm Mailing List , Diana Madalina Craciun , ACPI Devel Maling List , Linux Kernel Mailing List , "linux.cj" , netdev , Laurentiu Tudor , Len Brown , "Rafael J . Wysocki" , Ioana Ciornei X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_020119_329987_29313B83 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 10, 2021 at 7:40 PM Ioana Ciornei wrote: > > From: Ioana Ciornei > > This patch set provides ACPI support to DPAA2 network drivers. > > It also introduces new fwnode based APIs to support phylink and phy > layers > Following functions are defined: > phylink_fwnode_phy_connect() > fwnode_mdiobus_register_phy() > fwnode_get_phy_id() > fwnode_phy_find_device() > device_phy_find_device() > fwnode_get_phy_node() > fwnode_mdio_find_device() > acpi_get_local_address() > > First one helps in connecting phy to phylink instance. > Next three helps in getting phy_id and registering phy to mdiobus > Next two help in finding a phy on a mdiobus. > Next one helps in getting phy_node from a fwnode. > Last one is used to get local address from _ADR object. > > Corresponding OF functions are refactored. In general it looks fine to me. What really worries me is the calls like of_foo -> fwnode_bar -> of_baz. As I have commented in one patch the idea of fwnode APIs is to have a common ground for all resource providers. So, at the end it shouldn't be a chain of calls like above mentioned. Either fix the name (so, the first one will be in fwnode or device namespace) or fix the API that it will be fwnode/device API. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel