From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E26C432BE for ; Mon, 30 Aug 2021 10:57:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8A9161107 for ; Mon, 30 Aug 2021 10:57:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236443AbhH3K5y (ORCPT ); Mon, 30 Aug 2021 06:57:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235818AbhH3K5x (ORCPT ); Mon, 30 Aug 2021 06:57:53 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4F08C061575; Mon, 30 Aug 2021 03:56:59 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so13572965pjr.1; Mon, 30 Aug 2021 03:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IuLKz1s8t6PFtB3h5yQO3vsoV8BYc4QlCilxBHWTOcY=; b=gN/rIRJ+8Mk/MKOcw84CamLKnAejx1PZuqVsRV51WgkCvcJS7L9PiWIKt0TnmceP+T LWRDkoPqbMr9zTFv9XJG9Xj6TvqGCnYGa2ohFlCriTb69HjNgWfGichEWUseAQJg8Qsl iStTTO2OwqYvqYUWFGIDNLosinsIhEUxZjbRsO/5KlbtLOoVF5GvI5t+lsvGViaPBnQw G1mpqa0KY8zOeAIG0D/9eXsQNhPiHz0rsAnndZfMmWCv2GlWNdHhtwzjFXWD865dWSqo SaOF8r+DOgfxRSRI67JQUnYEoeorL/SCpBhsnCahpdVRGWchqt58a1hlZ8GGQUVWuvH1 fz1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IuLKz1s8t6PFtB3h5yQO3vsoV8BYc4QlCilxBHWTOcY=; b=pGlxPNvk73Iy/5Q739JMOQScsxoRtFmyCF38I8VaUKTtivk6S5QTV4H3Y/FoboLzq+ moxA69QduikECkXp78SIkb9j0K/EWZNVzuQd1pBAqgc2vY0xSXetwzOpbO1SLiUL7rik eaZ0UYzi+iFeqnVs5TfPfOIiS0dYw89+Knl/CAT83o+OR4hEjbSL52OEcrRXdjsgz9Qo v+cKfvx+entxr+kNe1tul4MyGMQkYQHwwenuGQKrXBQUj6Gkns9++pNiyRkZWJHh89fr nLE2ar8dAzk+trLO1V/mYCjD1y58lgjSr39I8SPu7MnsuGzl66oCIMKudcKQ9P/vzzRB JmMw== X-Gm-Message-State: AOAM532iPJzPNUiG4wcjM1PsPszjNzYe15dl99IGsHnqLqBfqPLVQs0v +Ty97P78F7AJ0wpQWBacmIAVvuzZdYoSsgBM2ak= X-Google-Smtp-Source: ABdhPJw9OgY3Xxn2H4QQ1g1xlibhj/dL2aOLnV1zyaaGrMut4CoMdwiVwchEgR4QZ2kpD0o9m8nYPxIOOJnVw03hs7U= X-Received: by 2002:a17:902:bb81:b0:12d:a7ec:3d85 with SMTP id m1-20020a170902bb8100b0012da7ec3d85mr21312883pls.17.1630321019360; Mon, 30 Aug 2021 03:56:59 -0700 (PDT) MIME-Version: 1.0 References: <20210830104426.487246-1-atafalla@dnyon.com> <20210830104426.487246-2-atafalla@dnyon.com> In-Reply-To: <20210830104426.487246-2-atafalla@dnyon.com> From: Andy Shevchenko Date: Mon, 30 Aug 2021 13:56:23 +0300 Message-ID: Subject: Re: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c To: Alejandro Tafalla Cc: Liam Girdwood , Mark Brown , ALSA Development Mailing List , Rob Herring , Jaroslav Kysela , Takashi Iwai , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 1:48 PM Alejandro Tafalla wrote: > > Drive the reset gpio if defined in the DTS node. ... > + reset_gpio > + = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW); A bit of a strange indentation, shouldn't it be one line? > + if (IS_ERR(reset_gpio)) { > + ret = PTR_ERR(reset_gpio); > + return dev_err_probe(&i2c->dev, ret, > + "failed to request GPIO reset pin"); It simply as return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio), "failed to request GPIO reset pin"); > + } -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68A6C432BE for ; Mon, 30 Aug 2021 10:58:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA38C61101 for ; Mon, 30 Aug 2021 10:58:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BA38C61101 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3AB39170F; Mon, 30 Aug 2021 12:57:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3AB39170F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1630321082; bh=fbESV5ZqI66U5BCJhdRnvvic3uv7lvAUEvO/d42TaTM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bujHWAMDWvkLzA7HHxqOuHGlN0veEj7XVEelFLp3zMYDLkVpZ02vvy+admP7Jco0V nJOdmhqrKFYKjUjUoaTXubWH7GWZ2+ZcGNHIqEvgHvnTqiYw9SUs5eqV8ySYBiUC36 R1eXNVm15zEurv4pTqibPlnUqkTcJooYFvLfZuCM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C80B1F8020D; Mon, 30 Aug 2021 12:57:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D1300F80218; Mon, 30 Aug 2021 12:57:09 +0200 (CEST) Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 43A43F8016E for ; Mon, 30 Aug 2021 12:57:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 43A43F8016E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gN/rIRJ+" Received: by mail-pj1-x1034.google.com with SMTP id w19-20020a17090aaf9300b00191e6d10a19so9706428pjq.1 for ; Mon, 30 Aug 2021 03:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IuLKz1s8t6PFtB3h5yQO3vsoV8BYc4QlCilxBHWTOcY=; b=gN/rIRJ+8Mk/MKOcw84CamLKnAejx1PZuqVsRV51WgkCvcJS7L9PiWIKt0TnmceP+T LWRDkoPqbMr9zTFv9XJG9Xj6TvqGCnYGa2ohFlCriTb69HjNgWfGichEWUseAQJg8Qsl iStTTO2OwqYvqYUWFGIDNLosinsIhEUxZjbRsO/5KlbtLOoVF5GvI5t+lsvGViaPBnQw G1mpqa0KY8zOeAIG0D/9eXsQNhPiHz0rsAnndZfMmWCv2GlWNdHhtwzjFXWD865dWSqo SaOF8r+DOgfxRSRI67JQUnYEoeorL/SCpBhsnCahpdVRGWchqt58a1hlZ8GGQUVWuvH1 fz1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IuLKz1s8t6PFtB3h5yQO3vsoV8BYc4QlCilxBHWTOcY=; b=DFAExkjJw+7Q/hkFr02HEayZJ6cn/eOIGABP5KOaJwtrKaFgTbGV/YgRJiYMIgXBLg VGQXx2ThkeGrdfzvlZyH/ZoITZyUtSU8GSuencctK5jdWHZZ0r6VdzrnZf6tbDe3EoV0 bY7XLKhBsUBAzXkM842gNIHw+WiEdxeZfhTsmlZb3uWp9NshcHwqRQ3/JVzvzC17Ad2G 4oQM2QBoMFtc7vCB6HSSS9GA5oAvKTkS4JOwNB86qIqt2+bmKM+OvRO6gi8+OB603CVE 7025Y41f8/gFDlZEipGjZvrFaD3GzXhYPpHZQ6aJ5bNwedTwPIDUyDwQOhf13qZbZ2nj g6Mg== X-Gm-Message-State: AOAM533+3TVpB5sS4H02GrFLHkTQaHHUKVmXcVOk1zWHdBfBIYpX/jpq vmJp5vRoMefHQPCPnhxs3jClX7ZkkJo2bzSL01w= X-Google-Smtp-Source: ABdhPJw9OgY3Xxn2H4QQ1g1xlibhj/dL2aOLnV1zyaaGrMut4CoMdwiVwchEgR4QZ2kpD0o9m8nYPxIOOJnVw03hs7U= X-Received: by 2002:a17:902:bb81:b0:12d:a7ec:3d85 with SMTP id m1-20020a170902bb8100b0012da7ec3d85mr21312883pls.17.1630321019360; Mon, 30 Aug 2021 03:56:59 -0700 (PDT) MIME-Version: 1.0 References: <20210830104426.487246-1-atafalla@dnyon.com> <20210830104426.487246-2-atafalla@dnyon.com> In-Reply-To: <20210830104426.487246-2-atafalla@dnyon.com> From: Andy Shevchenko Date: Mon, 30 Aug 2021 13:56:23 +0300 Message-ID: Subject: Re: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c To: Alejandro Tafalla Content-Type: text/plain; charset="UTF-8" Cc: devicetree , ALSA Development Mailing List , Linux Kernel Mailing List , Takashi Iwai , Rob Herring , Liam Girdwood , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Aug 30, 2021 at 1:48 PM Alejandro Tafalla wrote: > > Drive the reset gpio if defined in the DTS node. ... > + reset_gpio > + = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW); A bit of a strange indentation, shouldn't it be one line? > + if (IS_ERR(reset_gpio)) { > + ret = PTR_ERR(reset_gpio); > + return dev_err_probe(&i2c->dev, ret, > + "failed to request GPIO reset pin"); It simply as return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio), "failed to request GPIO reset pin"); > + } -- With Best Regards, Andy Shevchenko