From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3016C4321E for ; Tue, 8 Feb 2022 22:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387431AbiBHWbT (ORCPT ); Tue, 8 Feb 2022 17:31:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386341AbiBHUK6 (ORCPT ); Tue, 8 Feb 2022 15:10:58 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 644B8C0613CB; Tue, 8 Feb 2022 12:10:57 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id y3so1049232ejf.2; Tue, 08 Feb 2022 12:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cNeJNqdqiYnVYWualgJIjRFugWIH6ZRZ9ffFOARK/cE=; b=n1BWw2fNSgJK0rswqqpuw4wPGEdEsqQ2XhDNE6fBVE1/Nv3wL7DAAylwKE4cnembKm UeiDSU7dLdQyD5otmjeQhMA4Z4UR/jCQQwT9VnfNm1V2vS1VFXVOgXl/DldLE7ahHKeK EWrS5FF3vHZvisuYmRyMgzABtfZrsz8TfHNeb1Y33TX7M/oQL9wRDGX2VwZVZwXuu+TH EI1E31RadSBEzzYbtYJLF/V8b2+IFZc4g4yZHrtLOoN93f+6c4or4kUH9I4rabqnO1Ul kDEA5VI5/ixj6U5RqJ9NqcG21gsJx/F6DHF76zfhZVnBqT+V3KXpZnuUr5c/i13BoH5p ZDVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cNeJNqdqiYnVYWualgJIjRFugWIH6ZRZ9ffFOARK/cE=; b=eWVZI7dIlnSAp6Kyf7/sDx2VYkN+WasNSZ1BO3/Q0MVCwp5Pn3zsyJC9zBZR0QzYkk ooevCRgM98mIHqNqaIhXvZiv4Xs+gRX8ZJBNP8ALrL9TJW+gk5xXWVjBIn+adwDYWSWO d8g3V7vO5z1MAQRS+3Bposcacy9QYS+umjpPGpd3cX/t6QsrIzEzcya9fOQ7mgT+omBL +WvBMuHLwIAtTHRIEA5gzLBCovVZuGqyaMXncZObXboG46BybA4fGTX1L75K635Yt/w8 hlGiFm9oan/byWA1U0Vf59WSXRF1FvL5Vj0BmWpSDO7i4oHxPAauAPYuPukChR+L1vNd xkZw== X-Gm-Message-State: AOAM531Ivn09MvAbgZ4jrSpQLu7Dv24IyhcXulklT80wfNK4zNMUt2fP z+62tn+ypIjoB1C8Hb586itJEcWKzolAoqi63kD0NvTylnE= X-Google-Smtp-Source: ABdhPJz/29dfIwH1sP0e+2jI+7e4+ZvY6/O4KUyuquNucQ1QIxeS3tdTI9eYGZUhLIMBVu/8y6ESM+lCVFRYcaAq4yw= X-Received: by 2002:a17:906:c14d:: with SMTP id dp13mr5102597ejc.132.1644351055786; Tue, 08 Feb 2022 12:10:55 -0800 (PST) MIME-Version: 1.0 References: <20220130184130.176646-1-terry.bowman@amd.com> <20220130184130.176646-10-terry.bowman@amd.com> <20220208173316.403ec944@endymion.delvare> In-Reply-To: <20220208173316.403ec944@endymion.delvare> From: Andy Shevchenko Date: Tue, 8 Feb 2022 22:10:19 +0200 Message-ID: Subject: Re: [PATCH v4 9/9] i2c: piix4: Enable EFCH MMIO for Family 17h+ To: Jean Delvare Cc: Terry Bowman , Guenter Roeck , linux-watchdog@vger.kernel.org, linux-i2c , Wolfram Sang , "Rafael J. Wysocki" , Linux Kernel Mailing List , Wim Van Sebroeck , Robert Richter , Tom Lendacky , sudheesh.mavila@amd.com, "Shah, Nehal-bakulchandra" , Basavaraj Natikar , Shyam Sundar S K , Mario Limonciello Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 8, 2022 at 6:33 PM Jean Delvare wrote: > On Sun, 30 Jan 2022 12:41:30 -0600, Terry Bowman wrote: ... > > +#define AMD_PCI_SMBUS_REVISION_MMIO 0x51 > > I don't think that was worth a define. You only use the value once, in > a context where the symbolic name doesn't add much value IMHO. I don't remember the code context here, but it would be nice in such a case to convert this definition to a comment (if it's not crystal clear what this magic number is about). -- With Best Regards, Andy Shevchenko