From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Ayman Bagabas <ayman.bagabas@gmail.com>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Hui Wang <hui.wang@canonical.com>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Jaroslav Kysela <perex@perex.cz>,
kailang@realtek.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED
Date: Fri, 2 Nov 2018 20:33:38 +0200 [thread overview]
Message-ID: <CAHp75VfkyqWRrUND=U9Mb+2-HqpEZhpbUYKs5iTSn0mWK+W_sA@mail.gmail.com> (raw)
In-Reply-To: <s5hlg6bfi26.wl-tiwai@suse.de>
On Fri, Nov 2, 2018 at 8:30 PM Takashi Iwai <tiwai@suse.de> wrote:
> On Fri, 02 Nov 2018 19:12:44 +0100,
> Andy Shevchenko wrote:
> >
> > > + if (action == HDA_FIXUP_ACT_PROBE) {
> > > + if (!huawei_wmi_micmute_led_set_func)
> > > + huawei_wmi_micmute_led_set_func = symbol_request(huawei_wmi_micmute_led_set);
> > > + if (!huawei_wmi_micmute_led_set_func) {
> > > + codec_warn(codec, "Failed to find huawei_wmi symbol huawei_wmi_micmute_led_set\n");
> > > + return;
> > > + }
> > > + removefunc = (huawei_wmi_micmute_led_set_func(false) < 0)
> > > + || (snd_hda_gen_add_micmute_led(codec, update_huawei_wmi_micmute_led) < 0);
> > > +
> > > + }
> > > +
> > > + if (huawei_wmi_micmute_led_set_func && (action == HDA_FIXUP_ACT_FREE || removefunc)) {
> > > + symbol_put(huawei_wmi_micmute_led_set);
> > > + huawei_wmi_micmute_led_set_func = NULL;
> > > + }
> > > +}
> >
> > Takashi, is it a way how the rest sound drivers are written? B/c this
> > symbol_request(s) look to me a bit ugly.
>
> It's a workaround for not having a hard dependency. The HD-audio
> codec driver is generic, and we don't want to load the multiple WMI
> drivers always for using a Realtek codec.
>
> Ugly, yes, but simple enough.
Okay, thanks for elaboration.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-02 18:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 4:11 [PATCH v2 0/3] Huawei laptops WMI & sound fixes Ayman Bagabas
2018-11-02 4:11 ` [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-11-02 18:20 ` Andy Shevchenko
2018-11-02 23:10 ` ayman.bagabas
2018-11-05 11:05 ` Takashi Iwai
2018-11-05 11:05 ` Takashi Iwai
2018-11-02 4:11 ` [PATCH v2 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
2018-11-02 18:07 ` Andy Shevchenko
2018-11-02 4:11 ` [PATCH v2 3/3] ALSA: hda: add support for Huawei WMI MicMute LED Ayman Bagabas
2018-11-02 18:12 ` Andy Shevchenko
2018-11-02 18:30 ` Takashi Iwai
2018-11-02 18:30 ` Takashi Iwai
2018-11-02 18:33 ` Andy Shevchenko [this message]
2018-11-02 23:21 ` ayman.bagabas
2018-11-05 14:46 ` Andy Shevchenko
2018-11-02 18:05 ` [PATCH v2 0/3] Huawei laptops WMI & sound fixes Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfkyqWRrUND=U9Mb+2-HqpEZhpbUYKs5iTSn0mWK+W_sA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy@infradead.org \
--cc=ayman.bagabas@gmail.com \
--cc=dvhart@infradead.org \
--cc=hui.wang@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.