From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3E7C43334 for ; Thu, 23 Jun 2022 10:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbiFWKQ2 (ORCPT ); Thu, 23 Jun 2022 06:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230159AbiFWKQ0 (ORCPT ); Thu, 23 Jun 2022 06:16:26 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3090849FA4; Thu, 23 Jun 2022 03:16:26 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id c65so4781615edf.4; Thu, 23 Jun 2022 03:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WAgGmVWVOWwerEi+BAH4Lljnu8y7SnGhYb00GohsXcI=; b=UZAbgb+QBE+NUiOZbaeaQbs37/VcrS4+/t7K3VQuriZ1KcWZX1mfDUcCOiel0wOKlD nlc5OYyFb5l4wWVJCOWB/W8j6VYRg82xPXPLpLSY9k1tcgEVXfe+ezFEzFUjPJuFtlf8 CmuG4ESOEfKhkYcGdxOe8YtTLCutLkkMOXeIqnQv+IS/LChOqkl3P0axOrmtW+MRiVa+ XpafKMx9HsIBDsQD+x/S3+dKVJdM/ihTpsw+JAKLErvxw+x1OPwA86UeQCxvmCiwiF4S QuE6dd/UrPX0yqHgQ3s9JK2Tgs44DamSMFp3YvUSIftAHVS/a8e6s4c8FmciVcZLDSQ4 +cwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WAgGmVWVOWwerEi+BAH4Lljnu8y7SnGhYb00GohsXcI=; b=KoMTe3OWZ29m6pq3zn+m3Xz47xKKr+6shkGaPXssDXWQYQhGd387mY9tt4LKp0acJK z2Hh923QVmxDWdFQylj+Fx+M/FMYsLmoNS/vWOjlKJO1AeQYNJc9GTl+Wf71Ge2dq/W/ SVSGnyFf1YbbzzfafwB/SKxSAZBR+isCnXfg8VlqiM/ET3IKuyTHW2bV9n89vIduUeWS 6S3VrTmVLUheJUUAsgJvfkiApH2wIMBO6oEOE2nrImPd0CjnKCNnhZSpit4/pGObPiyR o3ELRR2XD7FHUO8XFPqFhjmEkbSa5H7TYQ+HAzBcSwRKWQGzpyqPgd8sAW8DS9VRVcv3 ZgZA== X-Gm-Message-State: AJIora/CgQeMBtpgrGiFDHUHEBewNonZknc9wbinaQPIhPsOU6SyTnga FH83GQba+Ll5BvpvfOfk5KUxp+1OEQY560VBJvU= X-Google-Smtp-Source: AGRyM1sSuZjSq7A6HWGZLYY3BlpzlEJnoj0eAD636Y9Xon5vjxM4t5uMTgVMQ7BDVd8jO2E0fYc4iSv4eaJ59vgiG2M= X-Received: by 2002:a50:9f6a:0:b0:435:5804:e07 with SMTP id b97-20020a509f6a000000b0043558040e07mr9791666edf.178.1655979384373; Thu, 23 Jun 2022 03:16:24 -0700 (PDT) MIME-Version: 1.0 References: <20220621124958.3342-1-ilpo.jarvinen@linux.intel.com> <20220621124958.3342-7-ilpo.jarvinen@linux.intel.com> <03467516-3962-4ff2-23d2-2b3a1d647c5a@kernel.org> In-Reply-To: From: Andy Shevchenko Date: Thu, 23 Jun 2022 12:15:42 +0200 Message-ID: Subject: Re: [PATCH v2 6/6] serial: Consolidate BOTH_EMPTY use To: Jiri Slaby Cc: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "linux-serial@vger.kernel.org" , Greg KH , Thomas Bogendoerfer , William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , "David S. Miller" , "linux-mips@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "speakup@linux-speakup.org" , "sparclinux@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2022 at 10:24 AM Jiri Slaby wrote: > On 23. 06. 22, 10:11, Andy Shevchenko wrote: > > * prom_putchar_wait() should be implemented using > > read_poll_timeout_atomic(), incl. failure/timeout handling. > > > > Not sure since it is an early stage and scheduler might not work as > > expected. Conversions to iopoll.h macros bitten us a few times already. > > Except _atomic does not use scheduler :). Sorry for a bit misleading comment, but I chased it down, so this what I had in mind when commenting: be24c6a71ecf ("soc: qcom: rpmh-rsc: Don't use ktime for timeout in write_tcs_reg_sync()") (Yes, it's about _atomic variant) Means we need to use those macros with care. -- With Best Regards, Andy Shevchenko