From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c Date: Mon, 25 Jan 2016 16:22:42 +0200 Message-ID: References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-4-git-send-email-aleksey.makarov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-yk0-f193.google.com ([209.85.160.193]:34204 "EHLO mail-yk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755501AbcAYOWn (ORCPT ); Mon, 25 Jan 2016 09:22:43 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Aleksey Makarov Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List , "linux-serial@vger.kernel.org" , Graeme Gregory , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm , Jiri Slaby , Robert Moore , Lv Zheng , "Rafael J. Wysocki" , Len Brown , devel@acpica.org On Mon, Jan 25, 2016 at 4:21 PM, Andy Shevchenko wrote: > On Mon, Jan 25, 2016 at 1:45 PM, Aleksey Makarov > wrote: >> Add an implementation of acpi_match() to the pl011 driver. >> It allows to check if the console matches one specified with >> ACPI SPCR table. > > I don't know Rafael's opinion on this, but I would split it to extend > ACPI header first with reference to newest revision of Microsoft > document. >> --- a/include/acpi/actbl2.h >> +++ b/include/acpi/actbl2.h >> @@ -371,6 +371,10 @@ struct acpi_dbg2_device { >> >> #define ACPI_DBG2_16550_COMPATIBLE 0x0000 >> #define ACPI_DBG2_16550_SUBSET 0x0001 >> +#define ACPI_DBG2_ARM_PL011 0x0003 >> +#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000e >> +#define ACPI_DBG2_ARM_DCC 0x000f >> +#define ACPI_DBG2_DCM2835 0x0010 ^^^ Exactly because of such typos. Should be BCM -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.shevchenko@gmail.com (Andy Shevchenko) Date: Mon, 25 Jan 2016 16:22:42 +0200 Subject: [PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c In-Reply-To: References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-4-git-send-email-aleksey.makarov@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 25, 2016 at 4:21 PM, Andy Shevchenko wrote: > On Mon, Jan 25, 2016 at 1:45 PM, Aleksey Makarov > wrote: >> Add an implementation of acpi_match() to the pl011 driver. >> It allows to check if the console matches one specified with >> ACPI SPCR table. > > I don't know Rafael's opinion on this, but I would split it to extend > ACPI header first with reference to newest revision of Microsoft > document. >> --- a/include/acpi/actbl2.h >> +++ b/include/acpi/actbl2.h >> @@ -371,6 +371,10 @@ struct acpi_dbg2_device { >> >> #define ACPI_DBG2_16550_COMPATIBLE 0x0000 >> #define ACPI_DBG2_16550_SUBSET 0x0001 >> +#define ACPI_DBG2_ARM_PL011 0x0003 >> +#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000e >> +#define ACPI_DBG2_ARM_DCC 0x000f >> +#define ACPI_DBG2_DCM2835 0x0010 ^^^ Exactly because of such typos. Should be BCM -- With Best Regards, Andy Shevchenko