From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Juergen Borleis <jbe@pengutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Richard Weinberger <richard@nod.at>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH v2] fs: ubifs: set s_uuid in super block to support ima/evm uuid options
Date: Tue, 16 Feb 2021 11:11:08 +0200 [thread overview]
Message-ID: <CAHp75VftQ6y58w+D6=nSwx3DRcLH3iwfx3RT8yv6rgS8O6OWHw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vcha++UUE6hw0n_pBnA24q_uJQekABSSktmjCoinfpSoA@mail.gmail.com>
+Cc: Stephen
Stephen, do you have a check in Linux Next to catch the problem that
Co-developed-by is not being accompanied by a corresponding SoB?
On Tue, Feb 16, 2021 at 11:09 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@pengutronix.de> wrote:
> >
> > From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> >
> > This is required to provide uuid based integrity functionality for:
> > ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option).
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> One issue below has to be addressed nevertheless.
>
> > Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > Co-developed-by: Juergen Borleis <jbe@pengutronix.de>
>
> According to the documentation [1] above has two issues:
> - all Co-developed-by *must* be accompanied with corresponding SoBs
> - commiter must provide his SoB (but it will be implied by the
> previous requirement in this case)
>
> [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
>
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> > fs/ubifs/super.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> > index 138b9426c6c1..a8383ca39a47 100644
> > --- a/fs/ubifs/super.c
> > +++ b/fs/ubifs/super.c
> > @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)
> > goto out_umount;
> > }
> >
> > + import_uuid(&sb->s_uuid, c->uuid);
> > +
> > mutex_unlock(&c->umount_mutex);
> > return 0;
> >
> > --
> > 2.20.1
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Juergen Borleis <jbe@pengutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Richard Weinberger <richard@nod.at>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH v2] fs: ubifs: set s_uuid in super block to support ima/evm uuid options
Date: Tue, 16 Feb 2021 11:11:08 +0200 [thread overview]
Message-ID: <CAHp75VftQ6y58w+D6=nSwx3DRcLH3iwfx3RT8yv6rgS8O6OWHw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vcha++UUE6hw0n_pBnA24q_uJQekABSSktmjCoinfpSoA@mail.gmail.com>
+Cc: Stephen
Stephen, do you have a check in Linux Next to catch the problem that
Co-developed-by is not being accompanied by a corresponding SoB?
On Tue, Feb 16, 2021 at 11:09 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis <jbe@pengutronix.de> wrote:
> >
> > From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> >
> > This is required to provide uuid based integrity functionality for:
> > ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option).
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> One issue below has to be addressed nevertheless.
>
> > Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > Co-developed-by: Juergen Borleis <jbe@pengutronix.de>
>
> According to the documentation [1] above has two issues:
> - all Co-developed-by *must* be accompanied with corresponding SoBs
> - commiter must provide his SoB (but it will be implied by the
> previous requirement in this case)
>
> [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
>
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> > fs/ubifs/super.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> > index 138b9426c6c1..a8383ca39a47 100644
> > --- a/fs/ubifs/super.c
> > +++ b/fs/ubifs/super.c
> > @@ -2230,6 +2230,8 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)
> > goto out_umount;
> > }
> >
> > + import_uuid(&sb->s_uuid, c->uuid);
> > +
> > mutex_unlock(&c->umount_mutex);
> > return 0;
> >
> > --
> > 2.20.1
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-02-16 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 7:23 fs: ubifs: set s_uuid in super block to support ima/evm uuid options Juergen Borleis
2021-02-16 7:23 ` Juergen Borleis
2021-02-16 7:23 ` [PATCH v2] " Juergen Borleis
2021-02-16 7:23 ` Juergen Borleis
2021-02-16 9:09 ` Andy Shevchenko
2021-02-16 9:09 ` Andy Shevchenko
2021-02-16 9:11 ` Andy Shevchenko [this message]
2021-02-16 9:11 ` Andy Shevchenko
2021-02-16 9:54 ` Stephen Rothwell
2021-02-16 9:54 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VftQ6y58w+D6=nSwx3DRcLH3iwfx3RT8yv6rgS8O6OWHw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=jbe@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
--cc=richard@nod.at \
--cc=s.trumtrar@pengutronix.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.