From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Raul E Rangel <rrangel@chromium.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
kramasub@chromium.org, Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: amd: Implement irq_set_wake
Date: Fri, 30 Apr 2021 12:22:09 +0300 [thread overview]
Message-ID: <CAHp75Vfvknn6O2cc4XYUuo4U_C1nguMHjJPxmRQapf8h0QjGFw@mail.gmail.com> (raw)
In-Reply-To: <20210429163341.1.I7631534622233689dd81410525e0dd617b9b2012@changeid>
On Fri, Apr 30, 2021 at 1:34 AM Raul E Rangel <rrangel@chromium.org> wrote:
>
> This allows the OS to control which devices produce wake events.
>
> $ grep enabled /sys/kernel/irq/*/wakeup
> /sys/kernel/irq/24/wakeup:enabled
Is it a bug fix of [1]?
If so, add a BugLink: tag here.
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
[1]:
...
irq_hw_number_t hw = irqd_to_hwirq(d);
> + pin_reg = readl(gpio_dev->base + (d->hwirq)*4);
> + writel(pin_reg, gpio_dev->base + (d->hwirq)*4);
Too many parentheses and missed spaces
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-30 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 22:34 [PATCH] pinctrl: amd: Implement irq_set_wake Raul E Rangel
2021-04-30 9:22 ` Andy Shevchenko [this message]
2021-04-30 9:23 ` Andy Shevchenko
2021-05-03 15:53 ` Raul Rangel
2021-05-19 0:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vfvknn6O2cc4XYUuo4U_C1nguMHjJPxmRQapf8h0QjGFw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=kramasub@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.