From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BE3C433FE for ; Sun, 26 Dec 2021 08:41:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232513AbhLZIld (ORCPT ); Sun, 26 Dec 2021 03:41:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231480AbhLZIlc (ORCPT ); Sun, 26 Dec 2021 03:41:32 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE7BC06173E; Sun, 26 Dec 2021 00:41:32 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id f5so49691516edq.6; Sun, 26 Dec 2021 00:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xi9xYQcsiziUA3jzSL6L0tZcb5wkuBpVzMITBHC5IzU=; b=kDgYIn+KcY0NwBADWR6qAZKTg3iIvG89cZJ3RYy+xLAqjpLHK3uEaCPKZxykMa2O6G KhRL+Qf2kPIm56ZsWrRb3BG64bWQJ7mNzEq7R5r1VNjkklhLvZ2RUnBEspy8oiaKzLty II0XrMLra4qgrGbiX50RtcKxK8Mkyp7mCu/VwQpMVsEI/Gg13dOr6a/c/HNvGpiO3LvY QvxRuYrxS6SlGVdf8JNjzBccrEThqdoVYNFnN+wKfFZs5ud/tKquhrmlthGayMdlRRIX jrd0fwMk2qHEohOu0XcVkY3AbEaoolQ0bv1QF9oCdgO5QqrjpKoMGfZIBsqgyTgcsqhn c9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xi9xYQcsiziUA3jzSL6L0tZcb5wkuBpVzMITBHC5IzU=; b=cMPMG+iq0xZ1uQAcpKXeLOl4VqtM0A+mg3hSHAzc+admFFf8DVkb9L29+uabDuxUhZ JLpEC8YBE3uz4BM3RnitOBKQdHemRjuNumXHfffIb+Q+FDHqZS5sXpi1++/c0QlZbuw/ 6P/RjoGPJArcGIm1vnY3tZ2vFvRXD9RM3qaBZLODw7aacV2QT5JDzBnISDINjrbrKXBt qyW8bIs0syOJKDz31K+ZKG4O/Xq/KWxpdvOn4Fjnjkrhm0Ums5OHCsxGf6EyBo6jKPl1 ZhIpF2syJfLJ7Mqz0Nj1rn/rbDX5F8HjgyB3vKLOKeJRTxKUiXJSHR4yoWIc52mWMuwJ uncA== X-Gm-Message-State: AOAM531rZZsJs558EmprclKeDdUzCET2bU4f8t4YvUo2QKv0OoVplcuS +YymSIjF2gf/v5t9FCPjXdvW9lC30yfI026Cqa4= X-Google-Smtp-Source: ABdhPJwusElNQDAiEWE7i2wUb6uakyx8QU/5+e7Gb+9Kt07j8kfhtcGC4zulrxBd2ayeUscklFt77cV43pDSyYEUs70= X-Received: by 2002:a17:906:a3c6:: with SMTP id ca6mr10083914ejb.639.1640508090800; Sun, 26 Dec 2021 00:41:30 -0800 (PST) MIME-Version: 1.0 References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Andy Shevchenko Date: Sun, 26 Dec 2021 10:40:54 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Prabhakar Mahadev Lad Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Nicolas Saenz Julienne , Chris Brandt , Wolfram Sang , linux-i2c , linux-rpi-kernel , linux-arm Mailing List , Linux-Renesas , Linux Kernel Mailing List , "Lad, Prabhakar" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad wrote: > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar wrote: ... > > > + if (np) { > > > > Same comments as per your other patches, i.e. > > Why is this check here? > > > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case. Shouldn't be fixed in platform_get_irq_optional() to return IRQ by index for all cases? > [0] https://elixir.bootlin.com/linux/v5.16-rc6/source/arch/sh/kernel/cpu/sh4a/setup-sh7724.c#L454 -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62A7EC433F5 for ; Sun, 26 Dec 2021 08:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dLWtw6Kkx+HzNr1CRSCw61tTCqkal8usgH9tJiXOMzU=; b=voqPB9AY3sV8g2 NzkBvkBF2QGrEceOJKgJdCAfVB4/X5hcYPpzeSVQuYTtMUPVHA4AP9jbNndCyfQAJxRETHrmHteJn R/eAHp103RfhL4BhtAP4AkD0qgn3EvWW8fTS7ji0GUAc/XULOtjiEZtOBKWtu9J27zxC8ccFeV2U+ b9O+fqcd6dpcKVYZ/3UIE+OpchZ+AmdttRKvJrjvTsLspiYGPobr8Zch0OGXWeuQqKt4v8UGpEKWm xxMdRBEtA9c3gNcti+u4puUHyGbTFF444CZxoqXxq1Tauu9nGWZVuFacASV/Osy18ERNPQOSrgPVn zAPervtqqd25zkt3wh2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n1P60-00FNhq-I4; Sun, 26 Dec 2021 08:41:36 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n1P5w-00FNgs-CG; Sun, 26 Dec 2021 08:41:33 +0000 Received: by mail-ed1-x52e.google.com with SMTP id y22so49798546edq.2; Sun, 26 Dec 2021 00:41:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xi9xYQcsiziUA3jzSL6L0tZcb5wkuBpVzMITBHC5IzU=; b=kDgYIn+KcY0NwBADWR6qAZKTg3iIvG89cZJ3RYy+xLAqjpLHK3uEaCPKZxykMa2O6G KhRL+Qf2kPIm56ZsWrRb3BG64bWQJ7mNzEq7R5r1VNjkklhLvZ2RUnBEspy8oiaKzLty II0XrMLra4qgrGbiX50RtcKxK8Mkyp7mCu/VwQpMVsEI/Gg13dOr6a/c/HNvGpiO3LvY QvxRuYrxS6SlGVdf8JNjzBccrEThqdoVYNFnN+wKfFZs5ud/tKquhrmlthGayMdlRRIX jrd0fwMk2qHEohOu0XcVkY3AbEaoolQ0bv1QF9oCdgO5QqrjpKoMGfZIBsqgyTgcsqhn c9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xi9xYQcsiziUA3jzSL6L0tZcb5wkuBpVzMITBHC5IzU=; b=KVqeA/mXr9S/YarG3g7vg/TEPIKugYDkTb2APTZ1LMW3LV4CzEkChl6IlhYUS6I9Ub S1EAJNHfXO9AoSFJwX5QPh2E9IHmsbrqhc2uTAK2JK6xDAiX/SCIn23upPSQF9ZxME5v Ht1gkvjWNBs9X4k+jkHO6AaBpW8TCXHEdgHx1O0UUhrXErJtTlhnJTmFWOhAVsmf30S3 pqvO18qaY4bQD3dVe2UjWKt+SdhBRSAN5Wl6szcLFYJ/RnD0pa2VjQokvwdWcFgHTw3o JNyCYcew4hamP3iIOJgZFnaPVTZRL4fscqPWFj9UXcq8l50nblmmUKKkuZVJl2zyTKTR 7qLA== X-Gm-Message-State: AOAM5311mMTvHILcv79AJ8Fdva9+SFtD5UaWj4s98K6Nc8nwJHuyeg2U CaqRU83iD/QtgCxBtL7LZOnBcjSY+tTMxfNX+7g= X-Google-Smtp-Source: ABdhPJwusElNQDAiEWE7i2wUb6uakyx8QU/5+e7Gb+9Kt07j8kfhtcGC4zulrxBd2ayeUscklFt77cV43pDSyYEUs70= X-Received: by 2002:a17:906:a3c6:: with SMTP id ca6mr10083914ejb.639.1640508090800; Sun, 26 Dec 2021 00:41:30 -0800 (PST) MIME-Version: 1.0 References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Andy Shevchenko Date: Sun, 26 Dec 2021 10:40:54 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Prabhakar Mahadev Lad Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Nicolas Saenz Julienne , Chris Brandt , Wolfram Sang , linux-i2c , linux-rpi-kernel , linux-arm Mailing List , Linux-Renesas , Linux Kernel Mailing List , "Lad, Prabhakar" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211226_004132_462171_EB740E85 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad wrote: > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar wrote: ... > > > + if (np) { > > > > Same comments as per your other patches, i.e. > > Why is this check here? > > > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case. Shouldn't be fixed in platform_get_irq_optional() to return IRQ by index for all cases? > [0] https://elixir.bootlin.com/linux/v5.16-rc6/source/arch/sh/kernel/cpu/sh4a/setup-sh7724.c#L454 -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel