From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f194.google.com ([209.85.166.194]:38685 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbeLFS4S (ORCPT ); Thu, 6 Dec 2018 13:56:18 -0500 Received: by mail-it1-f194.google.com with SMTP id h65so3163727ith.3 for ; Thu, 06 Dec 2018 10:56:16 -0800 (PST) MIME-Version: 1.0 References: <20181205091728.29903-1-cmaiolino@redhat.com> In-Reply-To: <20181205091728.29903-1-cmaiolino@redhat.com> From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Thu, 6 Dec 2018 19:56:02 +0100 Message-ID: Subject: Re: [PATCH 00/10 V2] New ->fiemap infrastructure and ->bmap removal To: cmaiolino@redhat.com, Christoph Hellwig Cc: Linux FS-devel Mailing List , Andreas Dilger , sandeen@redhat.com, Dave Chinner Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, Am Mi., 5. Dez. 2018 um 10:18 Uhr schrieb Carlos Maiolino : > This is the second version of the complete series with the goal to remove ->bmap > interface completely, in lieu of FIEMAP. I'm not thrilled by this approach. How about exposing the iomap operations at the vfs layer (for example, in the super block) and implementing bmap on top of that instead? (I realize that xfs has separate iomap operations for xattrs, but that is only used in its fiemap implementation.) Thanks, Andreas