From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Subject: Re: [PATCH v2] nfsd: Disable NFSv2 timestamp workaround for NFSv3+
Date: Sat, 9 May 2015 00:50:38 +0200 [thread overview]
Message-ID: <CAHpGcM+i1ZDJUV4oRVV3q9f2GSiDTYBfmRyzsQzRCeM1ck6EzA@mail.gmail.com> (raw)
In-Reply-To: <1431124677-13388-1-git-send-email-andreas.gruenbacher@gmail.com>
Here's a little test for this:
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <utime.h>
#include <grp.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <stdbool.h>
static int touch(const char *path, mode_t mode, bool current_time)
{
if (current_time)
return utime(path, NULL);
else {
time_t now = time(NULL);
struct utimbuf times = {
.actime = now,
.modtime = now,
};
return utime(path, ×);
}
}
static int su(uid_t uid, gid_t gid)
{
int ret;
ret = seteuid(0);
if (ret != 0)
return ret;
ret = setegid(gid);
if (ret != 0)
return ret;
ret = setgroups(0, NULL);
if (ret != 0)
return ret;
ret = seteuid(uid);
return ret;
}
static void die(const char *str)
{
perror(str);
exit(1);
}
void cleanup(void)
{
su(0, 0);
unlink("foo");
}
int main(void)
{
int ret;
atexit(cleanup);
ret = creat("foo", 0600);
if (ret < 0)
die("foo");
close(ret);
ret = chown("foo", 0, 12345);
if (ret != 0)
die("foo");
ret = su(12345, 12345);
if (ret != 0)
die("su");
errno = 0;
ret = touch("foo", 0660, true);
if (ret == 0)
die("touch should have failed");
ret = su(0, 0);
if (ret != 0)
die("su");
ret = chmod("foo", 0660);
if (ret != 0)
die("foo");
ret = su(12345, 12345);
if (ret != 0)
die("su");
errno = 0;
ret = touch("foo", 0660, true);
if (ret != 0)
die("touch should have succeeded");
ret = touch("foo", 0660, false);
if (ret == 0)
die("touch should fail on NFSv3+");
return 0;
}
next prev parent reply other threads:[~2015-05-08 22:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 6:50 [PATCH] nfsd: Disable NFSv2 timestamp workaround for NFSv3+ Andreas Gruenbacher
2015-05-06 6:56 ` Christoph Hellwig
2015-05-06 10:12 ` Andreas Grünbacher
2015-05-07 7:53 ` Christoph Hellwig
2015-05-07 14:08 ` J. Bruce Fields
2015-05-08 22:37 ` [PATCH v2] " Andreas Gruenbacher
2015-05-08 22:50 ` Andreas Grünbacher [this message]
2015-05-11 12:27 ` Christoph Hellwig
2015-05-12 18:38 ` Andreas Grünbacher
2015-05-11 12:26 ` Christoph Hellwig
2015-05-12 19:17 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHpGcM+i1ZDJUV4oRVV3q9f2GSiDTYBfmRyzsQzRCeM1ck6EzA@mail.gmail.com \
--to=andreas.gruenbacher@gmail.com \
--cc=agruenba@redhat.com \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.