From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2047FC433DF for ; Tue, 7 Jul 2020 21:42:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E697920771 for ; Tue, 7 Jul 2020 21:42:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E44Npy+u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgGGVme (ORCPT ); Tue, 7 Jul 2020 17:42:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbgGGVme (ORCPT ); Tue, 7 Jul 2020 17:42:34 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17E60C061755; Tue, 7 Jul 2020 14:42:34 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id i4so44763266iov.11; Tue, 07 Jul 2020 14:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eEphcFSLy8QcL2YgiuOYJ/038OCI0x9oymTZf0ealxU=; b=E44Npy+uD9w9OdRwhIZI8Eg596xSQB5BuN5tTCsfBVLb3wIB2ftJHf4hYQ1VdIgGzT ILX4A6wUkGdfVD00JELfXSv2arJ0OJ46HvKLA8nVtOHWQ6cUR///emWAakv8t0ax/4Ch xU6ihHXBkiGPNCFB0aaBoNuzU6x8Wpa8PtgGPuhiFEIxx+7+Z661VhObYrAYIgy/HgkZ f2LXtoeD8pjfl3ZgBYy+f6hwfPVTrOI4huglmsTpTaQNhlSc/4Tm8dccT0beKKwDvnKd hR+EopVSR8+8GKVpinFtIMhL3JZBsO29W9sMXcJm4/wWEYeCBbJSe6iw/Ekf0zLnCWpp WAtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eEphcFSLy8QcL2YgiuOYJ/038OCI0x9oymTZf0ealxU=; b=i7kfZuKlY2bDHu8AZaw6D4TEbkVKJg/tNbZY1UaDR7T/aXRwfDhGZaD8XeGNtjFKqz Xp3okzZwl4pDEkmPz3UOJ3PXYLqfF8Rm7PrqEsAV3Wc6kuGwxHBrKF2mgDr+OS/lYhUZ 6W+04AdQXj31oc4doXX/iceswaZ7V79hqTaMo0KxGn8AXfGXE3MU+4S2mhG2XLYqVfd1 Q5vcjb6kXyW5AljA9gTWIjd2XXdS+DjA/BXZENaZCpOn8SKuR2zSwhhKb9JzrjJI5u99 Nx8wvGwSBhvKfgbhF8eLzxjy7L2MZWDrWQUZoRVDj+MEP6IlBp2v2zoWRkv4kgBNpNkR dyjQ== X-Gm-Message-State: AOAM531YW4MT9ryVFh3EYZakziKzZZyNq2AEY/qZTO6Kd4kQiQjHp/ym PsanLSzaBMQ++jVhVSGYDO3WdkbigUi/yvAk3iI= X-Google-Smtp-Source: ABdhPJx6vXCFv0Sq8KiF3sflQwhJCic0rGSxeKwIiWlFas4fu6Fka6BqgyVfZM8yhXkk3dtsXcNLPYkxUjnUr6ICrAg= X-Received: by 2002:a5d:8f01:: with SMTP id f1mr33454675iof.20.1594158153413; Tue, 07 Jul 2020 14:42:33 -0700 (PDT) MIME-Version: 1.0 References: <20200707144457.1603400-1-agruenba@redhat.com> <20200707144457.1603400-2-agruenba@redhat.com> In-Reply-To: From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Tue, 7 Jul 2020 23:42:22 +0200 Message-ID: Subject: Re: [RFC v3 1/2] fs: Add IOCB_NOIO flag for generic_file_read_iter To: Jens Axboe Cc: Andreas Gruenbacher , Linus Torvalds , Matthew Wilcox , Dave Chinner , Linux FS-devel Mailing List , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Di., 7. Juli 2020 um 20:40 Uhr schrieb Jens Axboe : > On 7/7/20 8:44 AM, Andreas Gruenbacher wrote: > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 3f881a892ea7..1ab2ea19e883 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -315,6 +315,7 @@ enum rw_hint { > > #define IOCB_SYNC (1 << 5) > > #define IOCB_WRITE (1 << 6) > > #define IOCB_NOWAIT (1 << 7) > > +#define IOCB_NOIO (1 << 8) > > Just to make this even more trivial in terms of merge conflicts, could > you do 1 << 9 instead? Sure. Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10ABDC433E0 for ; Tue, 7 Jul 2020 21:42:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C279E206DF for ; Tue, 7 Jul 2020 21:42:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E44Npy+u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C279E206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 329906B0082; Tue, 7 Jul 2020 17:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B21B6B0085; Tue, 7 Jul 2020 17:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A3876B0087; Tue, 7 Jul 2020 17:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 022796B0082 for ; Tue, 7 Jul 2020 17:42:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8871D2C79 for ; Tue, 7 Jul 2020 21:42:34 +0000 (UTC) X-FDA: 77012604228.26.gate75_130e33326eb7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 5F8391804A300 for ; Tue, 7 Jul 2020 21:42:34 +0000 (UTC) X-HE-Tag: gate75_130e33326eb7 X-Filterd-Recvd-Size: 3569 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 21:42:33 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id y2so44827797ioy.3 for ; Tue, 07 Jul 2020 14:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eEphcFSLy8QcL2YgiuOYJ/038OCI0x9oymTZf0ealxU=; b=E44Npy+uD9w9OdRwhIZI8Eg596xSQB5BuN5tTCsfBVLb3wIB2ftJHf4hYQ1VdIgGzT ILX4A6wUkGdfVD00JELfXSv2arJ0OJ46HvKLA8nVtOHWQ6cUR///emWAakv8t0ax/4Ch xU6ihHXBkiGPNCFB0aaBoNuzU6x8Wpa8PtgGPuhiFEIxx+7+Z661VhObYrAYIgy/HgkZ f2LXtoeD8pjfl3ZgBYy+f6hwfPVTrOI4huglmsTpTaQNhlSc/4Tm8dccT0beKKwDvnKd hR+EopVSR8+8GKVpinFtIMhL3JZBsO29W9sMXcJm4/wWEYeCBbJSe6iw/Ekf0zLnCWpp WAtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eEphcFSLy8QcL2YgiuOYJ/038OCI0x9oymTZf0ealxU=; b=jVS7mf/7LxoDyyrcdHcGwORrvpAK/vnFcz0MUcmLn3JNwBlq0mfvc+tRhg1MtFFUZb KZAkfHCoExNXa3cWXtijjCugYmFmPWtf1QXThisvTehqWkperG90Up8ecSLLahQTyU7r rj+IxA4Agg6w7MjRCHrVuheh9nPL2hhicR+iJHjtfbgOQ+vWQXAztDwJ6m+JwS1J1lPd mxPwZSd/gO+D2H2w+1/JueYSFoYWxA8XMsV56pqfgvy6z5Y0579SFYwx1sqITUZgBrL0 u8RayV//ZAJqgMsqpo8nBpmptgZc3nmmQKLbgLMDpPDOLuUSKJp2w94lf6i9B9C9W3vW DfTQ== X-Gm-Message-State: AOAM533SG2B5fWhN7/Opw5/GKpCzouVLfC6gRsjA55UBbRaz7A7CGADG LgqKP6NAnaNbsOvYJECbKhlqNDiySvc09Zb71u4= X-Google-Smtp-Source: ABdhPJx6vXCFv0Sq8KiF3sflQwhJCic0rGSxeKwIiWlFas4fu6Fka6BqgyVfZM8yhXkk3dtsXcNLPYkxUjnUr6ICrAg= X-Received: by 2002:a5d:8f01:: with SMTP id f1mr33454675iof.20.1594158153413; Tue, 07 Jul 2020 14:42:33 -0700 (PDT) MIME-Version: 1.0 References: <20200707144457.1603400-1-agruenba@redhat.com> <20200707144457.1603400-2-agruenba@redhat.com> In-Reply-To: From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Tue, 7 Jul 2020 23:42:22 +0200 Message-ID: Subject: Re: [RFC v3 1/2] fs: Add IOCB_NOIO flag for generic_file_read_iter To: Jens Axboe Cc: Andreas Gruenbacher , Linus Torvalds , Matthew Wilcox , Dave Chinner , Linux FS-devel Mailing List , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5F8391804A300 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am Di., 7. Juli 2020 um 20:40 Uhr schrieb Jens Axboe : > On 7/7/20 8:44 AM, Andreas Gruenbacher wrote: > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 3f881a892ea7..1ab2ea19e883 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -315,6 +315,7 @@ enum rw_hint { > > #define IOCB_SYNC (1 << 5) > > #define IOCB_WRITE (1 << 6) > > #define IOCB_NOWAIT (1 << 7) > > +#define IOCB_NOIO (1 << 8) > > Just to make this even more trivial in terms of merge conflicts, could > you do 1 << 9 instead? Sure. Andreas