From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 21/34] xen/common: domctl: Some functions are only used internally Date: Tue, 1 Apr 2014 18:40:51 +0100 Message-ID: References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> <1395766541-23979-22-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9116579816945485711==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WV2gC-0005m0-G6 for xen-devel@lists.xenproject.org; Tue, 01 Apr 2014 17:40:56 +0000 Received: by mail-pa0-f47.google.com with SMTP id lj1so10190663pab.20 for ; Tue, 01 Apr 2014 10:40:51 -0700 (PDT) In-Reply-To: <1395766541-23979-22-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel , Tim Deegan , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============9116579816945485711== Content-Type: multipart/alternative; boundary=bcaec520f69b4abd5a04f5feab26 --bcaec520f69b4abd5a04f5feab26 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Mar 25, 2014 at 4:55 PM, Julien Grall wrote: > The list of function above are only used internally in common/domctl.c. > - bitmap_to_xenctl_bitmap > - xenctl_bitmap_to_bitmap > - nodemask_to_xenctl_bitmap > - xenctl_bitmap_to_nodemask > > Signed-off-by: Julien Grall > Cc: Keir Fraser > Acked-by: Keir Fraser > --- > xen/common/domctl.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index 7cf610a..5342e5d 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -33,9 +33,9 @@ > static DEFINE_SPINLOCK(domctl_lock); > DEFINE_SPINLOCK(vcpu_alloc_lock); > > -int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, > - const unsigned long *bitmap, > - unsigned int nbits) > +static int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, > + const unsigned long *bitmap, > + unsigned int nbits) > { > unsigned int guest_bytes, copy_bytes, i; > uint8_t zero = 0; > @@ -63,9 +63,9 @@ int bitmap_to_xenctl_bitmap(struct xenctl_bitmap > *xenctl_bitmap, > return err; > } > > -int xenctl_bitmap_to_bitmap(unsigned long *bitmap, > - const struct xenctl_bitmap *xenctl_bitmap, > - unsigned int nbits) > +static int xenctl_bitmap_to_bitmap(unsigned long *bitmap, > + const struct xenctl_bitmap > *xenctl_bitmap, > + unsigned int nbits) > { > unsigned int guest_bytes, copy_bytes; > int err = 0; > @@ -118,15 +118,15 @@ int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask, > return err; > } > > -int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap, > - const nodemask_t *nodemask) > +static int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap, > + const nodemask_t *nodemask) > { > return bitmap_to_xenctl_bitmap(xenctl_nodemap, nodes_addr(*nodemask), > MAX_NUMNODES); > } > > -int xenctl_bitmap_to_nodemask(nodemask_t *nodemask, > - const struct xenctl_bitmap *xenctl_nodemap) > +static int xenctl_bitmap_to_nodemask(nodemask_t *nodemask, > + const struct xenctl_bitmap > *xenctl_nodemap) > { > return xenctl_bitmap_to_bitmap(nodes_addr(*nodemask), xenctl_nodemap, > MAX_NUMNODES); > -- > 1.7.10.4 > > --bcaec520f69b4abd5a04f5feab26 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On T= ue, Mar 25, 2014 at 4:55 PM, Julien Grall <julien.grall@linaro.org> wrote:
The list of function above are only used int= ernally in common/domctl.c.
=A0 =A0 - bitmap_to_xenctl_bitmap
=A0 =A0 - xenctl_bitmap_to_bitmap
=A0 =A0 - nodemask_to_xenctl_bitmap
=A0 =A0 - xenctl_bitmap_to_nodemask

Signed-off-by: Julien Grall <= julien.grall@linaro.org>
Cc: Keir Fraser <keir@xen.org>

Acked-by: Keir Fraser <keir@xen.org>
=A0
---
=A0xen/common/domctl.c | =A0 20 ++++++++++----------
=A01 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 7cf610a..5342e5d 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -33,9 +33,9 @@
=A0static DEFINE_SPINLOCK(domctl_lock);
=A0DEFINE_SPINLOCK(vcpu_alloc_lock);

-int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0const unsigned lon= g *bitmap,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0unsigned int nbits= )
+static int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_bitmap, + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const= unsigned long *bitmap,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsig= ned int nbits)
=A0{
=A0 =A0 =A0unsigned int guest_bytes, copy_bytes, i;
=A0 =A0 =A0uint8_t zero =3D 0;
@@ -63,9 +63,9 @@ int bitmap_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_= bitmap,
=A0 =A0 =A0return err;
=A0}

-int xenctl_bitmap_to_bitmap(unsigned long *bitmap,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0const struct xenct= l_bitmap *xenctl_bitmap,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0unsigned int nbits= )
+static int xenctl_bitmap_to_bitmap(unsigned long *bitmap,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 const= struct xenctl_bitmap *xenctl_bitmap,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsig= ned int nbits)
=A0{
=A0 =A0 =A0unsigned int guest_bytes, copy_bytes;
=A0 =A0 =A0int err =3D 0;
@@ -118,15 +118,15 @@ int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask,<= br> =A0 =A0 =A0return err;
=A0}

-int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0const nodemask= _t *nodemask)
+static int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap,=
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 c= onst nodemask_t *nodemask)
=A0{
=A0 =A0 =A0return bitmap_to_xenctl_bitmap(xenctl_nodemap, nodes_addr(*nodem= ask),
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 MAX= _NUMNODES);
=A0}

-int xenctl_bitmap_to_nodemask(nodemask_t *nodemask,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0const struct x= enctl_bitmap *xenctl_nodemap)
+static int xenctl_bitmap_to_nodemask(nodemask_t *nodemask,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 c= onst struct xenctl_bitmap *xenctl_nodemap)
=A0{
=A0 =A0 =A0return xenctl_bitmap_to_bitmap(nodes_addr(*nodemask), xenctl_nod= emap,
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 MAX= _NUMNODES);
--
1.7.10.4


--bcaec520f69b4abd5a04f5feab26-- --===============9116579816945485711== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9116579816945485711==--