From: Jonathan Richardson <jonathan.richardson@broadcom.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Dejin Zheng" <zhengdejin5@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Petr Štetiar" <ynezz@true.cz>, "Ray Jui" <ray.jui@broadcom.com>,
"Scott Branden" <scott.branden@broadcom.com>,
"Stephen Boyd" <swboyd@chromium.org>
Subject: Re: [PATCH] net: broadcom: fix a mistake about ioremap resource
Date: Tue, 5 May 2020 10:44:57 -0700 [thread overview]
Message-ID: <CAHrpVsWbAdf+K1+mToj-5yoj-quFoXwF5D6_aAKufBE2tNSkFA@mail.gmail.com> (raw)
In-Reply-To: <f3208af6-80ad-223f-3490-30561996afff@web.de>
On Tue, May 5, 2020 at 12:20 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > Commit d7a5502b0bb8b ("net: broadcom: convert to
> > devm_platform_ioremap_resource_byname()") will broke this driver.
> > idm_base and nicpm_base were optional, after this change, they are
> > mandatory. it will probe fails with -22 when the dtb doesn't have them
> > defined. so revert part of this commit and make idm_base and nicpm_base
> > as optional.
>
> I hope that other contributors can convince you to improve also this
> commit message considerably.
> Would you like to fix the spelling besides other wording weaknesses?
How about this wording:
Commit d7a5502b0bb8b ("net: broadcom: convert to
devm_platform_ioremap_resource_byname()")
inadvertently made idm_base and nicpm_base mandatory. These are
optional properties.
probe will fail when they're not defined. The commit is partially
reverted so that they are
obtained by platform_get_resource_byname() as before. amac_base can
still be obtained
by devm_platform_ioremap_resource_byname().
next prev parent reply other threads:[~2020-05-05 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 7:19 [PATCH] net: broadcom: fix a mistake about ioremap resource Markus Elfring
2020-05-05 17:44 ` Jonathan Richardson [this message]
2020-05-07 11:16 ` Markus Elfring
2020-05-07 11:16 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHrpVsWbAdf+K1+mToj-5yoj-quFoXwF5D6_aAKufBE2tNSkFA@mail.gmail.com \
--to=jonathan.richardson@broadcom.com \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=swboyd@chromium.org \
--cc=ynezz@true.cz \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.