All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eyal Birger <eyal.birger@gmail.com>
To: David Ahern <dsahern@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] vrf: fix vrf driver unloading
Date: Thu, 26 May 2022 10:35:09 +0300	[thread overview]
Message-ID: <CAHsH6Gs1V3kD7SytSkUA+sjMCfkOB1OMQ_xNQse8+PJg6b_ASQ@mail.gmail.com> (raw)
In-Reply-To: <df95ef08-4b8f-1b23-9a8e-ae9ad0538a9d@kernel.org>

On Thu, May 26, 2022 at 12:12 AM David Ahern <dsahern@kernel.org> wrote:
>
> On 5/25/22 2:46 PM, Eyal Birger wrote:
> > The commit referenced in the "Fixes" tag has removed the vrf driver
> > cleanup function leading to a "Device or resource busy" error when
> > trying to rmmod vrf.
> >
> > Fix by re-introducing the cleanup function with the relevant changes.
> >
> > Fixes: 9ab179d83b4e ("net: vrf: Fix dst reference counting")
> > Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
> >
> > ----
> >
> > Note: the commit message in 9ab179d83b4e did not document it
> > and it is not apparent to me why the ability to rmmod the driver is
> > linked to that change, but maybe there's some hidden reason.
>
> dst output handler references VRF functions. You can not remove the
> module until all dst references have been dropped. Since there is no way
> to know and the rmmod command can not just hang waiting for dst entries
> to be dropped the module can not be unloaded. The same is true for IPv6
> as module; it can not be removed and I believe for the same reason.
>
I thought it was related to such cleanup, but couldn't see why the device
unregistration wouldn't void the dsts.

Probably better be safe than sorry :)

Thanks for the clarification.
Eyal.

      reply	other threads:[~2022-05-26  7:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 20:46 [PATCH net] vrf: fix vrf driver unloading Eyal Birger
2022-05-25 21:12 ` David Ahern
2022-05-26  7:35   ` Eyal Birger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHsH6Gs1V3kD7SytSkUA+sjMCfkOB1OMQ_xNQse8+PJg6b_ASQ@mail.gmail.com \
    --to=eyal.birger@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.