All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Dawson <spdawson@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libusb: disable on avr32
Date: Sat, 17 Nov 2012 22:11:00 +0000	[thread overview]
Message-ID: <CAHt8ZCNvE-f7N=7n3XCoWsv2YK0qSK5D67f0zqF-Pae5AC3RDA@mail.gmail.com> (raw)
In-Reply-To: <87ehjsrksw.fsf@dell.be.48ers.dk>

Hi Peter; thanks for the comments.

On 17 November 2012 21:17, Peter Korsgaard <jacmet@uclibc.org> wrote:
>  spdawson> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
>  spdawson> index 985939e..a8a9e14 100644
>  spdawson> --- a/package/efl/libedbus/Config.in
>  spdawson> +++ b/package/efl/libedbus/Config.in
>  spdawson> @@ -15,6 +15,7 @@ if BR2_PACKAGE_LIBEDBUS
>
>  spdawson>  config BR2_PACKAGE_LIBEDBUS_BLUEZ
>  spdawson>      bool "bluez support"
>  spdawson> +    depends on !BR2_avr32 # libusb
>  spdawson>      select BR2_PACKAGE_BLUEZ_UTILS
>
> But bluez doesn't depend on libusb, only the BR2_PACKAGE_BLUEZ_UTILS_USB
> suboption (which should depend on !BR2_avr32).

Well, bluez-utils already depends as a whole on !BR2_avr32, so I don't
need to add that dependency to the BR2_PACKAGE_BLUEZ_UTILS_USB
suboption. However, I think the correct dependency information for the
BR2_PACKAGE_LIBEDBUS_BLUEZ suboption should probably be as follows.

  depends on !BR2_avr32 && BR2_USE_WCHAR # bluez-utils

That expresses all dependencies of bluez-utils (except for
BR2_TOOLCHAIN_HAS_THREADS, which is already an overall dependency of
BR2_PACKAGE_LIBEDBUS). Does that sound alright?

>  spdawson>  config BR2_PACKAGE_SCONESERVER_BLUETOOTH
>  spdawson>      bool "bluetooth"
>  spdawson> +    depends on !BR2_avr32 && BR2_USE_WCHAR && \
>  spdawson> +            BR2_TOOLCHAIN_HAS_THREADS # bluez-utils
>  spdawson>      select BR2_PACKAGE_BLUEZ_UTILS
>
> Same here.

If I'm right above, then this can stay as it is.

Simon.

      reply	other threads:[~2012-11-17 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17 21:07 [Buildroot] [PATCH v2] libusb: disable on avr32 spdawson at gmail.com
2012-11-17 21:17 ` Peter Korsgaard
2012-11-17 22:11   ` Simon Dawson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHt8ZCNvE-f7N=7n3XCoWsv2YK0qSK5D67f0zqF-Pae5AC3RDA@mail.gmail.com' \
    --to=spdawson@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.