From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mx.groups.io with SMTP id smtpd.web08.83882.1629465708261567758 for ; Fri, 20 Aug 2021 06:21:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PRRPWVry; spf=pass (domain: gmail.com, ip: 209.85.208.181, mailfrom: andrey.z@gmail.com) Received: by mail-lj1-f181.google.com with SMTP id y7so17347546ljp.3 for ; Fri, 20 Aug 2021 06:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LbUMHD0+lA8XF0GAl5eMPiq4Ua3OmbcIUqtuCihI5Z8=; b=PRRPWVryPsQVQpwkdh/TAdUEMOk1GkB1toemuCIUH0WbTsl6VhA5nVJ6Ml0PtoPHPr rsXIBoNcgMeKaM9tA1cn/XwbzRAYxKK9q7RigDEX7GYiTKxqJ7cS+dw30s/F7+/E5aya zqogcqNgo7whWoJao70lqcBufKXObtuhL2CRMZfk2FJz1CqwF6kVs/bo6L0EMyUQeJBB jj8lTirsTBKexVfxjxF8DcAtXCHP27AVGhFQxCxqVGzT868TtJvl/LW7RynBYEbNjp71 EfLkHkLHUgHdR/Q1lZbxIIHxPhvqoaefxvf2FkALPczzWoWE91KrwUKSUCninoXq5mzH cxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LbUMHD0+lA8XF0GAl5eMPiq4Ua3OmbcIUqtuCihI5Z8=; b=l3z/VxY+//X4GHDpUAM5oFaOyWqJmjF7ZY9yHOlXCZtw17l+L0KQuZyBUaM/opmMem IgjF+MkpLsSYBnpKzuLX2K0Vr/CjsV9fwVlGzeRrYr/gPVRh1ydPdwPOwmofI3oPbmsp llN4p1XFPUwbULQQZoFISJoGvzG4mM+Hm6m9ZP7EN3lQi7Eiq8EbSqNRTz3qfEwTMwTO WnRPMzrbtqO5ShsIEEsxhwjYSMO+4KjcYwQZ5GNhp+xNOz1Bn7FPTDqRtFHKn0m3/MjS pur5I3FzCFxXkH6+kr2f0yDSgMLiFYoDbTns3Gi1k/YN/Hh00ZoaAlVlUxwha8+kAVSc P/pg== X-Gm-Message-State: AOAM530i6yzLHUcqVn+Ajtc1eSS4k0Su8Uf5YHQ3MwY1rVEo0jKM9+RJ O0bfUoTmKuT8kB8aoFNq6XCJNaNkXjqH8BMCpk4= X-Google-Smtp-Source: ABdhPJxvQWBG/s4IUa0jVfEONskFizocXS3snLI52/Mj3ptQaNr1Nt+UU79jpSIlYsKTqgvfMlGQCYhhurM/CPu8x5Y= X-Received: by 2002:a2e:97cf:: with SMTP id m15mr6265439ljj.125.1629465706411; Fri, 20 Aug 2021 06:21:46 -0700 (PDT) MIME-Version: 1.0 References: <91f494738fb9c63499fae982fb7b09cb29c3afed.1629213685.git.bruce.ashfield@gmail.com> In-Reply-To: From: "Andrey Zhizhikin" Date: Fri, 20 Aug 2021 15:21:26 +0200 Message-ID: Subject: Re: [OE-core] [PATCH 2/4] lttng-modules: update to 2.13.0 To: Bruce Ashfield Cc: Richard Purdie , OE Core mailing list Content-Type: text/plain; charset="UTF-8" On Fri, Aug 20, 2021 at 2:57 PM Bruce Ashfield wrote: > > On Fri, Aug 20, 2021 at 7:13 AM Andrey Zhizhikin wrote: > > > > Hello Bruce, > > > > On Tue, Aug 17, 2021 at 5:27 PM Bruce Ashfield wrote: > > > > > > From: Bruce Ashfield > > > > > > Updating to 2.13.0, so we can pick up the latest -stable and > > > support for 5.14+ kernels. > > > > > > We refresh one patch for new context, and update the LICENSE > > > checksum due to commit 2df37e95fa4303 [Cleanup: Move headers from > > > toplevel to include/lttng/]. which impacted the LICENSE file (but > > > licensing is the same). > > > > I'm seeing a build failure with this new LTTng and CONFIG_TRACEPOINTS > > not enabled on the kernel 5.13.12. The failure comes from the Kbuild, > > which does not demote the missing trace point config option from error > > to warning. There is a patch file already in the layer, but it is only > > appended to the 'class-devupstream' and is missing in the SRC_URI. > > Hmmm. I ported the original patch, but yes, that Kbuild patch is also > needed (and it is my own patch no less). > > I was just updating the devupstream version yesterday, and ran across > that patch. > > None of the oe-core qemu* BSPs I test against have a disabled > tracepoint configuration, so I didn't run into that. I'd try to enable it locally on my end, just to see if LTTng would build with trace points enabled in the kernel config. > > I have the bumped devupstream version and the ported patch done > locally, I can send it out shortly, but it sounds like you've already > done that, so I can sit on that change. Please go ahead and send out your version, I'll be figuring out those build errors on my end, and it might take some time... > > > > > I was going to submit the patch to recipe to have it included, but > > testing the build stage with this patch included I'm seeing a lot of > > other errors then, something like: > > > > lttng-modules-2.13.0/src/lttng-tracepoint.c:227:36: error: 'struct > > module' has no member named 'num_tracepoints' > > -- or -- > > src/probes/../../include/instrumentation/events/rpc.h:208:36: error: > > implicit declaration of function 'rpc_qname' > > [-Werror=implicit-function-declaration] > > > > and the list goes on... :/ > > > > Have you seen this during testing of this new version? Any advise on > > where to look next? > > Not really. I end up updating lttng frequently, due to my constant > work on new kernel versions, but I'm not a lttng expert by any > definition. Same here, I just saw the build failure and started to poke around to see what could be the root cause of it. Missing KBuild patch was an easy find, but those compiler errors are not... > > The smoke tests passed when I ran the tests, I'll poke around a bit > and see if I can come up with any ideas (since clearly, our kernel > configurations are quite different, given that I never did run into > that patch not being in devupstream). > > Bruce > > > > > > > > > MODULES_MODULE_SYMVERS_LOCATION must also be specified in this > > > release, as the lttng build has moved the module target to a > > > 'src' subdirectory. > > > > > > Signed-off-by: Bruce Ashfield > > > --- > > > ...fail-if-CONFIG_TRACEPOINTS-is-not-en.patch | 32 ++++++------------- > > > ...ules_2.12.6.bb => lttng-modules_2.13.0.bb} | 6 ++-- > > > 2 files changed, 14 insertions(+), 24 deletions(-) > > > rename meta/recipes-kernel/lttng/{lttng-modules_2.12.6.bb => lttng-modules_2.13.0.bb} (88%) > > > > > > > > > > > > -- > > Regards, > > Andrey. > > > > -- > - Thou shalt not follow the NULL pointer, for chaos and madness await > thee at its end > - "Use the force Harry" - Gandalf, Star Trek II -- Regards, Andrey.