All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrey Zhizhikin" <andrey.z@gmail.com>
To: Sam Van Den Berge <sam.van.den.berge@gmail.com>
Cc: meta-freescale@lists.yoctoproject.org
Subject: Re: [meta-freescale] Cannot run "devtool mofidy linux-fslc" in Dunfell branch
Date: Wed, 17 Feb 2021 14:50:32 +0100	[thread overview]
Message-ID: <CAHtQpK4StSV8MUugQELRJk-mVU+a1XGa+J8970=9=eHd0DSV2Q@mail.gmail.com> (raw)
In-Reply-To: <CAJPofokjZw6TojVKJh57nPqghXat+VXWxA-g5npzQy1g0=Ha7Q@mail.gmail.com>

Hello Sam,

On Tue, Feb 16, 2021 at 4:00 PM Sam Van Den Berge
<sam.van.den.berge@gmail.com> wrote:
>
> On Tue, Feb 16, 2021 at 12:13 PM Andrey Zhizhikin <andrey.z@gmail.com> wrote:
> >
> > Hello Sam,
> >
> > On Tue, Feb 16, 2021 at 12:05 PM Sam Van Den Berge
> > <sam.van.den.berge@gmail.com> wrote:
> > >
> > > On Mon, Feb 15, 2021 at 11:10 PM Andrey Zhizhikin <andrey.z@gmail.com> wrote:
> > > >
> > > > Hello Sam,
> > > >
> > > > On Mon, Feb 15, 2021 at 9:35 PM <sam.van.den.berge@gmail.com> wrote:
> > > > >
> > > > > I also have the exact same error with linux-fslc 5.10.12.
> > > >
> > > > Can you try to change SRCBRANCH in
> > > > recipes-kernel/linux/linux-fslc_5.10.bb to KBRANCH? I've just tried it
> > > > out and it should solve the problem.
> > > >
> > > > I have a patch for this and made a PR to address the issue, please
> > > > have a look at https://github.com/Freescale/meta-freescale/pull/652. I
> > > > would appreciate if you test it locally on your end and report here if
> > > > that solves your devtool errors.
> > >
> > > Unfortunately it's not solved in my case. Depending on the path that
> > > gets executed in
> > > devtool/standard.py, I do think your patch does solve the issue in some cases.
> >
> > Since linux-fslc[-imx] recipes are inheriting kernel-yocto class, it
> > is needed that the KBRANCH to be defined as it can be seen in
> > scripts/lib/devtool/standard.py on line 822.
> >
> > Which particular error do you see when you apply the patch from PR?
> > Do you have any appends to the kernel recipe?
> > Which machine are you trying to build and which distro?
> >
>
> We have one small append to the kernel recipe but it's something with a dts. No
> additional kernel configs or whatsoever. Machine is imx6q and distro
> is an internal one.
>
> I modified devtool a little bit so that it prints the variables from
> line 822 and this is
> what I get:
>
> kernelVersion=5.10.12
> kbranch=5.10.x+fslc
> staging_kerVer=
> staging_kbranch=
>
> so in my case the if statement at line 822 is not True. I think this
> is because we
> do not clone the git repo but have extracted a tar.gz and we use that
> as the source.
> Not sure though...

Can you try to use linux-fslc from the git repository instead of
tarball? If it is proven to be working - then the problem might be in
the implementation of devtool itself and should be taken upstream for
further investigations.

>
> As a result of the False if-statement,  _extract_source will be executed.
> Then at line 607 it will start executing the configure task. At the
> point the execution
> reaches the do_preconfigure() from fsl-kernel-localversion.bbclass
> while the file
> defconfig is not in ${WORKDIR} but in the ${WORKDIR}/../oe-local-files folder.
> As a result, the following command in the do_preconfigure() will fail:
>
> sed -e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config'
>
> This is the error I get:
> DEBUG: Executing shell function do_preconfigure
> ..../linux-fslc/5.10.12+gitAUTOINC+ed3accb10c-r0/devtooltmp-otiy_odb/temp/run.do_preconfigure.3336084:
> line 160: ...../devtooltmp-otiy_odb/workdir/defconfig: No such file or directory
> WARNING: ..../devtooltmp-otiy_odb/temp/run.do_preconfigure.3336084:160
> exit 1 from
> 'sed -e "${CONF_SED_SCRIPT}" <
> ..../devtooltmp-otiy_odb/workdir/defconfig' >>
> '....devtooltmp-otiy_odb/workdir/build/.config''
>
> The problem really is that devtool copies Non-patch files to an
> oe-local-files folder,
> in contrast to just running bitbake which puts both patch and
> non-patch files in the
> ${WORKDIR}.
>
> > --
> > Regards,
> > Andrey.



-- 
Regards,
Andrey.

      reply	other threads:[~2021-02-17 13:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Groupsio.2.8T6j.1596182415784285232.EDu6@lists.yoctoproject.org>
2020-10-27  8:24 ` [meta-freescale] Cannot run "devtool mofidy linux-fslc" in Dunfell branch Ks89
2020-10-27  8:46   ` bartvanderlaan
2021-02-15 20:35     ` sam.van.den.berge
2021-02-15 22:10       ` [meta-freescale] " Andrey Zhizhikin
2021-02-16 11:05         ` svdb
2021-02-16 11:13           ` Andrey Zhizhikin
2021-02-16 15:00             ` svdb
2021-02-17 13:50               ` Andrey Zhizhikin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHtQpK4StSV8MUugQELRJk-mVU+a1XGa+J8970=9=eHd0DSV2Q@mail.gmail.com' \
    --to=andrey.z@gmail.com \
    --cc=meta-freescale@lists.yoctoproject.org \
    --cc=sam.van.den.berge@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.