From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mx.groups.io with SMTP id smtpd.web09.7625.1613569846157738023 for ; Wed, 17 Feb 2021 05:50:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aVn0qcdI; spf=pass (domain: gmail.com, ip: 209.85.167.47, mailfrom: andrey.z@gmail.com) Received: by mail-lf1-f47.google.com with SMTP id v5so21445989lft.13 for ; Wed, 17 Feb 2021 05:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rtrf52CNixZWsIxrsfAvAQSVr90Ebz5I4hkAcQbz0DI=; b=aVn0qcdIMsidkiO9g9pETJYJh1sQPN9H5xLPfHyzzDl/SX+34ENnrTvC8+BCd7OFjk JpY56yHGBjUY8fJrlwsPz/7udrM3pkJT3ffEJ++roO2MAkSFsm9h7lTCPDAASf+D/0LM MdJ0HxpSGpiL0KCfKsHJp5d7nO8fCiU6TaVFz5S7dNcKiHC5uwOJ5z9HSwR1IJ7inq11 b2TTf5LcuXyogYpxa3S8YeEv7ImxMvVNdyAgMfO7Pj8c1ARVxAeFuI/6J55iQjCrCu3k F0YhMY5cZADdHYgnvD4UiWU0shN3kbstR0tuXdlpnKACLZ2e2vwbQWVDDFnQTQI1gKJX gNlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rtrf52CNixZWsIxrsfAvAQSVr90Ebz5I4hkAcQbz0DI=; b=m2jsa5bdzewJKRUM531FXB9rOWWw2tM4EMJzogZcV+5i5pl7OClzhDDnr/5ejP0jgT r5Pmr1sdlohi7Cscs8v2uGfpAesbMHUrClKVSWAHg6UrLFc+VTJfHZWYqft6DRWqJNnk yz9W2lnOZ9ru3wFTYX/sddppQd2G92lE+1N02hct2xYSKu4G34NIRbq1biZFkjHNehVf 2bYyr1LVS3lB8zBLtIplEfuyZPtaKhChgOFIVMbYhrqUbA4vBgQu9o/iti/RpY0xi58L pHNLStooy1tfyIb7/9u+ImAgrhd29sPocwLu+HQDpo4lH+yulJqyjH+EfzdUQNvmypp8 A4DA== X-Gm-Message-State: AOAM531nGEyNlkUcNOllU3LG8DRNwytHIQG3A80YOIvMvkZLogfyz6CD gKwQM8WT/rjFH8KGfLs9eKUwuq6PsJgPb34lDeM= X-Google-Smtp-Source: ABdhPJzEZuvbJ4OXVGBFoDgl2oZaUn0MbBXpyNuz9WIZy+mHU4kdW2nKi6NmnXdOdtBG/yrhHUTdhEbCigoUMfqYf8M= X-Received: by 2002:a05:6512:287:: with SMTP id j7mr14298719lfp.304.1613569844252; Wed, 17 Feb 2021 05:50:44 -0800 (PST) MIME-Version: 1.0 References: <28924.1603788360363021085@lists.yoctoproject.org> <18462.1613421333255881579@lists.yoctoproject.org> In-Reply-To: From: "Andrey Zhizhikin" Date: Wed, 17 Feb 2021 14:50:32 +0100 Message-ID: Subject: Re: [meta-freescale] Cannot run "devtool mofidy linux-fslc" in Dunfell branch To: Sam Van Den Berge Cc: meta-freescale@lists.yoctoproject.org Content-Type: text/plain; charset="UTF-8" Hello Sam, On Tue, Feb 16, 2021 at 4:00 PM Sam Van Den Berge wrote: > > On Tue, Feb 16, 2021 at 12:13 PM Andrey Zhizhikin wrote: > > > > Hello Sam, > > > > On Tue, Feb 16, 2021 at 12:05 PM Sam Van Den Berge > > wrote: > > > > > > On Mon, Feb 15, 2021 at 11:10 PM Andrey Zhizhikin wrote: > > > > > > > > Hello Sam, > > > > > > > > On Mon, Feb 15, 2021 at 9:35 PM wrote: > > > > > > > > > > I also have the exact same error with linux-fslc 5.10.12. > > > > > > > > Can you try to change SRCBRANCH in > > > > recipes-kernel/linux/linux-fslc_5.10.bb to KBRANCH? I've just tried it > > > > out and it should solve the problem. > > > > > > > > I have a patch for this and made a PR to address the issue, please > > > > have a look at https://github.com/Freescale/meta-freescale/pull/652. I > > > > would appreciate if you test it locally on your end and report here if > > > > that solves your devtool errors. > > > > > > Unfortunately it's not solved in my case. Depending on the path that > > > gets executed in > > > devtool/standard.py, I do think your patch does solve the issue in some cases. > > > > Since linux-fslc[-imx] recipes are inheriting kernel-yocto class, it > > is needed that the KBRANCH to be defined as it can be seen in > > scripts/lib/devtool/standard.py on line 822. > > > > Which particular error do you see when you apply the patch from PR? > > Do you have any appends to the kernel recipe? > > Which machine are you trying to build and which distro? > > > > We have one small append to the kernel recipe but it's something with a dts. No > additional kernel configs or whatsoever. Machine is imx6q and distro > is an internal one. > > I modified devtool a little bit so that it prints the variables from > line 822 and this is > what I get: > > kernelVersion=5.10.12 > kbranch=5.10.x+fslc > staging_kerVer= > staging_kbranch= > > so in my case the if statement at line 822 is not True. I think this > is because we > do not clone the git repo but have extracted a tar.gz and we use that > as the source. > Not sure though... Can you try to use linux-fslc from the git repository instead of tarball? If it is proven to be working - then the problem might be in the implementation of devtool itself and should be taken upstream for further investigations. > > As a result of the False if-statement, _extract_source will be executed. > Then at line 607 it will start executing the configure task. At the > point the execution > reaches the do_preconfigure() from fsl-kernel-localversion.bbclass > while the file > defconfig is not in ${WORKDIR} but in the ${WORKDIR}/../oe-local-files folder. > As a result, the following command in the do_preconfigure() will fail: > > sed -e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config' > > This is the error I get: > DEBUG: Executing shell function do_preconfigure > ..../linux-fslc/5.10.12+gitAUTOINC+ed3accb10c-r0/devtooltmp-otiy_odb/temp/run.do_preconfigure.3336084: > line 160: ...../devtooltmp-otiy_odb/workdir/defconfig: No such file or directory > WARNING: ..../devtooltmp-otiy_odb/temp/run.do_preconfigure.3336084:160 > exit 1 from > 'sed -e "${CONF_SED_SCRIPT}" < > ..../devtooltmp-otiy_odb/workdir/defconfig' >> > '....devtooltmp-otiy_odb/workdir/build/.config'' > > The problem really is that devtool copies Non-patch files to an > oe-local-files folder, > in contrast to just running bitbake which puts both patch and > non-patch files in the > ${WORKDIR}. > > > -- > > Regards, > > Andrey. -- Regards, Andrey.