Re: [OE-core][PATCH] perl: add integer module required for kernel >= 5.14

["Andrey Zhizhikin" <andrey.z@gmail.com>]

Hello Richard,

On Mon, Aug 30, 2021 at 10:30 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Mon, 2021-08-30 at 20:05 +0000, Andrey Zhizhikin wrote:
> > Kernel commit 12dd461ebd19 ("crypto: arm64 - generate *.S by Perl at
> > build time instead of shipping them") uses perl to generate assembler
> > files for crypto functionality, which relies on the integer.pm module to
> > be provided.
> >
> > Add this module to FILES and export it for build system.
> >
> > Signed-off-by: Andrey Zhizhikin <andrey.z@gmail.com>
> > Cc: Bruce Ashfield <bruce.ashfield@gmail.com>
> > Cc: Alexander Kanavin <alex.kanavin@gmail.com>
> > ---
> >  meta/recipes-devtools/perl/perl_5.34.0.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb
> > index ab19a8d0be0..7a07b3f4911 100644
> > --- a/meta/recipes-devtools/perl/perl_5.34.0.bb
> > +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb
> > @@ -248,6 +248,7 @@ FILES:${PN} = "${bindir}/perl ${bindir}/perl.real ${bindir}/perl${PV} ${libdir}/
> >                 ${libdir}/perl5/${PV}/strict.pm \
> >                 ${libdir}/perl5/${PV}/warnings.pm \
> >                 ${libdir}/perl5/${PV}/warnings \
> > +               ${libdir}/perl5/${PV}/integer.pm \
> >                 ${libdir}/perl5/${PV}/vars.pm \
> >                 ${libdir}/perl5/site_perl \
> >                 ${libdir}/perl5/${PV}/ExtUtils/MANIFEST.SKIP \
>
> Doesn't that mean something is missing an RDEPENDS on perl-module-integer rather
> than adding to the main perl package?

Good point! Now that I look at it - this does look a bit too intrusive
(even though it did serve the purpose).

I'm just not sure if I can craft it to RDEPENDS in kernel class instead...

This is definitely required by newer kernel builds (>= 5.14), but I'm
no expert in how those dependencies are set in kernel class. Would
need to look a bit deeper there.

>
> Cheers,
>
> Richard
>

--
Regards,
Andrey.