From: "Andrey Zhizhikin" <andrey.z@gmail.com>
To: hongxu <hongxu.jia@windriver.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>,
"Mittal, Anuj" <anuj.mittal@intel.com>
Subject: Re: [OE-core] [hardknott][PATCH] Revert "sdk: fix relocate symlink failed"
Date: Tue, 7 Sep 2021 12:39:43 +0200 [thread overview]
Message-ID: <CAHtQpK7+qYwK8qa9-NwCg0FyVjsq1DsqfRwFW-3Ck8zbrQF-bA@mail.gmail.com> (raw)
In-Reply-To: <20210907062554.852167-1-hongxu.jia@windriver.com>
Hello Hongxu,
On Tue, Sep 7, 2021 at 8:26 AM hongxu <hongxu.jia@windriver.com> wrote:
>
> The commit [7e71acd265 sdk: fix relocate symlink failed] is used to fix
> regression issue caused by commit [bc4ee54535 sdk: Decouple default install
> path from built in path], but hardknott does not contain commit bc4ee54535,
> so commit 7e71acd265 should not be in hardknott neither, otherwise it caused
> other regression issue.
>
> This reverts commit 7e71acd265637d54d5bf149ea36cefa581f60992.
This has been already discussed for [dunfell], see [1].
The actual proposal was to take the second commit rather than
reverting the first one, which Steve did (see [2]).
Can the same approach be applied to [hardknott]?
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
> meta/files/toolchain-shar-relocate.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/files/toolchain-shar-relocate.sh b/meta/files/toolchain-shar-relocate.sh
> index ba873373e2..5433741296 100644
> --- a/meta/files/toolchain-shar-relocate.sh
> +++ b/meta/files/toolchain-shar-relocate.sh
> @@ -72,7 +72,7 @@ fi
>
> # change all symlinks pointing to @SDKPATH@
> for l in $($SUDO_EXEC find $native_sysroot -type l); do
> - $SUDO_EXEC ln -sfn $(readlink $l|$SUDO_EXEC sed -e "s:$SDK_BUILD_PATH:$target_sdk_dir:") $l
> + $SUDO_EXEC ln -sfn $(readlink $l|$SUDO_EXEC sed -e "s:$DEFAULT_INSTALL_DIR:$target_sdk_dir:") $l
> if [ $? -ne 0 ]; then
> echo "Failed to setup symlinks. Relocate script failed. Abort!"
> exit 1
> --
> 2.27.0
>
>
>
>
Link: [1]: https://lists.openembedded.org/g/openembedded-core/topic/85311771#155603
Link: [2]: https://lists.openembedded.org/g/openembedded-core/message/155670
--
Regards,
Andrey.
next prev parent reply other threads:[~2021-09-07 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 6:25 [hardknott][PATCH] Revert "sdk: fix relocate symlink failed" hongxu
2021-09-07 10:39 ` Andrey Zhizhikin [this message]
2021-09-08 1:21 ` [OE-core] " hongxu
[not found] ` <16A2841257B7E642.24606@lists.openembedded.org>
2021-09-07 10:41 ` Andrey Zhizhikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHtQpK7+qYwK8qa9-NwCg0FyVjsq1DsqfRwFW-3Ck8zbrQF-bA@mail.gmail.com \
--to=andrey.z@gmail.com \
--cc=anuj.mittal@intel.com \
--cc=hongxu.jia@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.