ah, good catch.

I didn't realize that was the case. It looks like it is up to Nuvoton to
upstream it.

https://github.com/Nuvoton-Israel/linux/blob/NPCM-5.10-OpenBMC/drivers/hwmon/npcm750-pwm-fan.c#L800

Or maybe I can just make the change for them? Not sure.

Willy Tu

On Wed, May 26, 2021 at 6:51 PM Joel Stanley <joel@jms.id.au> wrote:

> On Wed, 26 May 2021 at 15:48, Willy Tu <wltu@google.com> wrote:
> >
> > ping
> >
> > On Fri, Apr 23, 2021 at 5:38 PM Willy Tu <wltu@google.com> wrote:
> >>
> >> gsj platform sometimes also see low fan speed issue that can be partly
> >> prevented with this fan filter.
>
> This property is not supported by the kernel, so it will not do
> anything. Do you intend to submit driver support?
>
> >>
> >> Signed-off-by: Willy Tu <wltu@google.com>
> >> ---
> >>  arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> >> index 3ff116aaacb3..86facfc08c6e 100644
> >> --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> >> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> >> @@ -408,18 +408,21 @@ fan@0 {
> >>                 reg = <0x00>;
> >>                 fan-tach-ch = /bits/ 8 <0x00 0x01>;
> >>                 cooling-levels = <127 255>;
> >> +               fan_filter_en;
> >>         };
> >>
> >>         fan@1 {
> >>                 reg = <0x01>;
> >>                 fan-tach-ch = /bits/ 8 <0x02 0x03>;
> >>                 cooling-levels = /bits/ 8 <127 255>;
> >> +               fan_filter_en;
> >>         };
> >>
> >>         fan@2 {
> >>                 reg = <0x02>;
> >>                 fan-tach-ch = /bits/ 8 <0x04 0x05>;
> >>                 cooling-levels = /bits/ 8 <127 255>;
> >> +               fan_filter_en;
> >>         };
> >>  };
> >>
> >> --
> >> 2.31.1.498.g6c1eba8ee3d-goog
> >>
>