From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF49C433FE for ; Thu, 7 Oct 2021 20:47:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E02D360FDC for ; Thu, 7 Oct 2021 20:47:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E02D360FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:40258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYaIa-0004oh-0V for qemu-devel@archiver.kernel.org; Thu, 07 Oct 2021 16:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYaDV-0005kk-0u for qemu-devel@nongnu.org; Thu, 07 Oct 2021 16:42:13 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:38798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYaDP-00066c-Pe for qemu-devel@nongnu.org; Thu, 07 Oct 2021 16:42:12 -0400 Received: by mail-wr1-x433.google.com with SMTP id u18so22913610wrg.5 for ; Thu, 07 Oct 2021 13:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2CI6QWAbwKftk3YSwKnzvDfthaIwjF1vy8WLPgztgyA=; b=URYWx04zVHHXrVmBavQDciQafOrqgPVLKCufgSYOpbcXjvM87wX6FDeA3Udew4RiSg 6FGZ30Apj9US5svDxL/eIdgeDmHqfE8zxfxHGOMVg2IDzY1w63MjnXHch8adgaTInLb1 COuJoTaoDoVr9P6ZFLbusboNc3ubzsc7luatz3DtlvrMrfDy/jcljKPCmA7b014TLyXB Qx2vZ4lfyoUwVaHMjSYtK+d0KpiOVb8q5ZkjNckiEcPn5pqGmNVXLds6psapDSLJIJxq /67fz5HLnDi/jMgaz4U3WV6Fy3W93Gbyq8VOVzSc5umZjNaqrNhAm7tLZVpqzSabPXrk 8NoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2CI6QWAbwKftk3YSwKnzvDfthaIwjF1vy8WLPgztgyA=; b=ExKwzXqPflFxUyXHlofo8Pbd8upAfcHGxYcVBVsFZKSW48IsKECWh83DlYTKGEuNUy IaN/v8lTzWMZr7Yo6KHFbLEcaEjyD1b3lDJq2ON9mi533m9wcT5bDnk4dcyIYjX4EenT xR4pIMH7WREqGewumyIeX+sOBDnEuPtXjQFGHxDSU8Kf9AkaxnsUPoKflDqETsmHGHnP J/hXgNll5rlO4Ij5Rt6gabmbnpdYgfiIysQRsziqkQtewyG4lKJzFMeXqMuEqvD1Xrdd jXkRQR7xMBSjwrwBDXao3ZZfjgKpVdINm7Wc3ryR29NTVUwVUP4Mf6l+o0EVlbkRaLyj 1UNQ== X-Gm-Message-State: AOAM531GlF/xhK8w05P6VAs6YSrApdjb87ra34hcCx9xOA7laE/T0sbX VVqo5Gp8rfVkZ4aTCepaGptNMv4qbCyzSwQZtD0= X-Google-Smtp-Source: ABdhPJzjz6ROt28HU3zIhjsfVp+FoPFahK2OY6RVRWejb2PJIW/Yg2aitvUmcy8fwgDxgDy9N/uihoKC+EEax2mNMrQ= X-Received: by 2002:a1c:9dd1:: with SMTP id g200mr11411240wme.42.1633639326564; Thu, 07 Oct 2021 13:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20211007130630.632028-1-pbonzini@redhat.com> <20211007130829.632254-6-pbonzini@redhat.com> In-Reply-To: <20211007130829.632254-6-pbonzini@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 8 Oct 2021 00:41:51 +0400 Message-ID: Subject: Re: [PATCH 11/24] configure, meson: get HOST_WORDS_BIGENDIAN via the machine object To: Paolo Bonzini Content-Type: multipart/alternative; boundary="000000000000c0465405cdc94bb4" Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=marcandre.lureau@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000c0465405cdc94bb4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 7, 2021 at 5:14 PM Paolo Bonzini wrote: > No need to pass it in config-host.mak. > > Signed-off-by: Paolo Bonzini > Or we could eventually use G_BYTE_ORDER, I guess. Reviewed-by: Marc-Andr=C3=A9 Lureau --- > configure | 4 ---- > meson.build | 3 ++- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/configure b/configure > index f91b8e1f0d..35e25bb960 100755 > --- a/configure > +++ b/configure > @@ -347,7 +347,6 @@ tsan=3D"no" > fortify_source=3D"$default_feature" > strip_opt=3D"yes" > tcg_interpreter=3D"false" > -bigendian=3D"no" > mingw32=3D"no" > gcov=3D"no" > EXESUF=3D"" > @@ -4262,9 +4261,6 @@ fi > if test "$strip_opt" =3D "yes" ; then > echo "STRIP=3D${strip}" >> $config_host_mak > fi > -if test "$bigendian" =3D "yes" ; then > - echo "HOST_WORDS_BIGENDIAN=3Dy" >> $config_host_mak > -fi > if test "$mingw32" =3D "yes" ; then > echo "CONFIG_WIN32=3Dy" >> $config_host_mak > if test "$guest_agent_with_vss" =3D "yes" ; then > diff --git a/meson.build b/meson.build > index 6842402a60..9bb443387a 100644 > --- a/meson.build > +++ b/meson.build > @@ -1465,6 +1465,7 @@ config_host_data.set('QEMU_VERSION_MICRO', > meson.project_version().split('.')[2] > > config_host_data.set_quoted('CONFIG_HOST_DSOSUF', host_dsosuf) > config_host_data.set('HAVE_HOST_BLOCK_DEVICE', have_host_block_device) > +config_host_data.set('HOST_WORDS_BIGENDIAN', host_machine.endian() =3D= =3D > 'big') > > # has_header > config_host_data.set('CONFIG_EPOLL', cc.has_header('sys/epoll.h')) > @@ -1625,7 +1626,7 @@ foreach k, v: config_host > config_host_data.set('HOST_' + v.to_upper(), 1) > elif strings.contains(k) > config_host_data.set_quoted(k, v) > - elif k.startswith('CONFIG_') or k.startswith('HAVE_') or > k.startswith('HOST_') > + elif k.startswith('CONFIG_') or k.startswith('HAVE_') > config_host_data.set(k, v =3D=3D 'y' ? 1 : v) > endif > endforeach > -- > 2.31.1 > > > > --=20 Marc-Andr=C3=A9 Lureau --000000000000c0465405cdc94bb4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Oct 7, 2021 at 5:14 PM Paolo = Bonzini <pbonzi= ni@redhat.com> wrote:
No need to pass it in config-host.mak.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

<= div>Or we could eventually use G_BYTE_ORDER, I guess.

Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com><= /div>


--
Marc-Andr= =C3=A9 Lureau
--000000000000c0465405cdc94bb4--