On Fri, Oct 30, 2020 at 2:14 AM Eduardo Habkost <ehabkost@redhat.com> wrote:

> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>



> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
>  include/hw/qdev-properties.h |  2 +-
>  hw/core/qdev-properties.c    | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 530286e869..7f8e4daade 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -34,7 +34,7 @@ struct PropertyInfo {
>      const QEnumLookup *enum_table;
>      int (*print)(Object *obj, Property *prop, char *dest, size_t len);
>      void (*set_default_value)(ObjectProperty *op, const Property *prop);
> -    void (*create)(ObjectClass *oc, Property *prop);
> +    ObjectProperty *(*create)(ObjectClass *oc, Property *prop);
>      ObjectPropertyAccessor *get;
>      ObjectPropertyAccessor *set;
>      ObjectPropertyRelease *release;
> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
> index 195bfed6e1..89e292dc25 100644
> --- a/hw/core/qdev-properties.c
> +++ b/hw/core/qdev-properties.c
> @@ -872,12 +872,12 @@ const PropertyInfo qdev_prop_size = {
>
>  /* --- object link property --- */
>
> -static void create_link_property(ObjectClass *oc, Property *prop)
> +static ObjectProperty *create_link_property(ObjectClass *oc, Property
> *prop)
>  {
> -    object_class_property_add_link(oc, prop->name, prop->link_type,
> -                                   prop->offset,
> -
>  qdev_prop_allow_set_link_before_realize,
> -                                   OBJ_PROP_LINK_STRONG);
> +    return object_class_property_add_link(oc, prop->name, prop->link_type,
> +                                          prop->offset,
> +
> qdev_prop_allow_set_link_before_realize,
> +                                          OBJ_PROP_LINK_STRONG);
>  }
>
>  const PropertyInfo qdev_prop_link = {
> --
> 2.28.0
>
>
>

-- 
Marc-André Lureau