From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E8AC4361B for ; Thu, 17 Dec 2020 10:23:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2274323741 for ; Thu, 17 Dec 2020 10:23:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2274323741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpqRM-0006F6-U3 for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 05:23:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpqQ8-0005Ph-PE for qemu-devel@nongnu.org; Thu, 17 Dec 2020 05:22:04 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:40045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpqQ4-00052M-Cg for qemu-devel@nongnu.org; Thu, 17 Dec 2020 05:22:04 -0500 Received: by mail-ed1-x536.google.com with SMTP id h16so28060417edt.7 for ; Thu, 17 Dec 2020 02:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pz0oUKq4y/tjKV79kRJJLIT87ZKsu2ZWyTrbotlggps=; b=TAFPlLyy/3meqgf+BoWdECl+XtHdAV6+Zv2xb/rv0eL95Jz82GR3UeyXT+p24BLmEc /T6dnhYIfevwE+khyrYvKue1WpPAdixsMmB2dGHEHR+WJeXGHSbUF1Yugnsj1nhO8ZRh 2dMYrinD3k2aZAAGfc3dHfjInGupqBPtFRWck8UXywuBK1VK9oPAh7038Ycik2vkfWbe iCQXXD7RNrqDZ48EGHQ9rPzjEp/fGh0fq7dfhFKFR8KGwIKkrUPn+WciI7r8kBdU6GgP YiwVhh/1EUUX6frXzCagKJVnd4U7BqclsRyntf0gR8oMVCooa7jk3+SjnMoxtu+u5EIp US2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pz0oUKq4y/tjKV79kRJJLIT87ZKsu2ZWyTrbotlggps=; b=JrcOgF+4hu7tYSKRr30M4JeV1b9/BZl00wYmAwAdT50uokgFz9Xyl+kQ/9IKkqM1aJ mGalWf2pkRjI94ajkvbVbBG/rk55XILaN7VQOk1natOyOcpH/ypVITRhAXgKUJx2GmQY NHhIvjxAIuZ2BIrBK3VrN0J7iaaw5FTibMgAnG1S4GXlPFmkMmGJojfPvdOCtwFTtyE1 yave7KRpdS/acDvkeEkaXq64yqaX03PJGeW8w2ToGZmdBPH0wlmb9wra8rLhRY4Qojn9 tfbyUK6Gglb/aVFGDZeal5luIBY4R8bKRzZa8NJYJtn70C2WUvmpp2JeH412ERVoLcai UABA== X-Gm-Message-State: AOAM533ls9n/+4CBYcujtVqoixhAjIuvjM7KfqL0trzNZUIzDzSmtdBf GyZPMKssqvhgOVea1PjKQ6qrSDz19x+4mggXdPs= X-Google-Smtp-Source: ABdhPJyFO/KbVVWAeExHrDqzuct0WCxjczgnUYB2NJ0jwa/ovcnr5PDW5KLg8P/QI/WEFUy8li+VgB2VrfTFsdfePcI= X-Received: by 2002:a50:e846:: with SMTP id k6mr38421424edn.245.1608200517752; Thu, 17 Dec 2020 02:21:57 -0800 (PST) MIME-Version: 1.0 References: <20201217085005.10644-1-pbonzini@redhat.com> <20201217085005.10644-3-pbonzini@redhat.com> In-Reply-To: <20201217085005.10644-3-pbonzini@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Thu, 17 Dec 2020 14:21:46 +0400 Message-ID: Subject: Re: [PATCH 2/4] configure: remove variable bogus_os To: Paolo Bonzini Content-Type: multipart/alternative; boundary="000000000000969f8805b6a65c41" Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000969f8805b6a65c41 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Dec 17, 2020 at 12:50 PM Paolo Bonzini wrote: > The condition can be tested also from $targetos, clean up. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-Andr=C3=A9 Lureau --- > configure | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/configure b/configure > index 085a5ad7ff..18af8207d9 100755 > --- a/configure > +++ b/configure > @@ -467,7 +467,6 @@ gettext=3D"auto" > fuse=3D"auto" > fuse_lseek=3D"auto" > > -bogus_os=3D"no" > malloc_trim=3D"auto" > > # parse CC options second > @@ -620,7 +619,6 @@ else > # might be going to just print the --help text, or it might > # be the result of a missing compiler. > targetos=3D'bogus' > - bogus_os=3D'yes' > fi > > # Some host OSes need non-standard checks for which CPU to use. > @@ -2016,7 +2014,7 @@ if test -z "$werror" ; then > fi > fi > > -if test "$bogus_os" =3D "yes"; then > +if test "$targetos" =3D "bogus"; then > # Now that we know that we're not printing the help and that > # the compiler works (so the results of the check_defines we used > # to identify the OS are reliable), if we didn't recognize the > -- > 2.29.2 > > > > --=20 Marc-Andr=C3=A9 Lureau --000000000000969f8805b6a65c41 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Dec 17, 2020 at 12:50 PM Paol= o Bonzini <pbonzini@redhat.com> wrote:
The= condition can be tested also from $targetos, clean up.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

<= div>Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>=C2=A0
---
=C2=A0configure | 4 +---
=C2=A01 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/configure b/configure
index 085a5ad7ff..18af8207d9 100755
--- a/configure
+++ b/configure
@@ -467,7 +467,6 @@ gettext=3D"auto"
=C2=A0fuse=3D"auto"
=C2=A0fuse_lseek=3D"auto"

-bogus_os=3D"no"
=C2=A0malloc_trim=3D"auto"

=C2=A0# parse CC options second
@@ -620,7 +619,6 @@ else
=C2=A0 =C2=A0# might be going to just print the --help text, or it might =C2=A0 =C2=A0# be the result of a missing compiler.
=C2=A0 =C2=A0targetos=3D'bogus'
-=C2=A0 bogus_os=3D'yes'
=C2=A0fi

=C2=A0# Some host OSes need non-standard checks for which CPU to use.
@@ -2016,7 +2014,7 @@ if test -z "$werror" ; then
=C2=A0 =C2=A0 =C2=A0fi
=C2=A0fi

-if test "$bogus_os" =3D "yes"; then
+if test "$targetos" =3D "bogus"; then
=C2=A0 =C2=A0 =C2=A0# Now that we know that we're not printing the help= and that
=C2=A0 =C2=A0 =C2=A0# the compiler works (so the results of the check_defin= es we used
=C2=A0 =C2=A0 =C2=A0# to identify the OS are reliable), if we didn't re= cognize the
--
2.29.2





--
Marc-Andr=C3=A9 Lureau
--000000000000969f8805b6a65c41--