From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1aGSFT-000825-Vs
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:06:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1aGSFS-0000TY-KS
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:06:07 -0500
MIME-Version: 1.0
In-Reply-To: <567ACC0C.5080608@redhat.com>
References: <1450717720-9627-1-git-send-email-eblake@redhat.com>
	<1450717720-9627-16-git-send-email-eblake@redhat.com>
	<567ACC0C.5080608@redhat.com>
Date: Tue, 5 Jan 2016 15:06:06 +0100
Message-ID: <CAJ+F1C+KehtroC1BdmaAaCe2EHLBHoyNyZOX6hENgWVt4ywOrg@mail.gmail.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v8 15/35] qom: Swap 'name' next to visitor
	in ObjectPropertyAccessor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>, Eduardo Habkost <ehabkost@redhat.com>, "open list:nvme" <qemu-block@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>, Jiri Slaby <jslaby@suse.cz>, Jason Wang <jasowang@redhat.com>, QEMU <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Keith Busch <keith.busch@intel.com>, Gonglei <arei.gonglei@huawei.com>, "open list:sPAPR pseries" <qemu-ppc@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, John Snow <jsnow@redhat.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

Hi

On Wed, Dec 23, 2015 at 5:30 PM, Eric Blake <eblake@redhat.com> wrote:
> On 12/21/2015 10:08 AM, Eric Blake wrote:
>> Similar to the previous patch, it's nice to have all functions
>> n the tree that involve a visitor and a name for conversion to
>
> s/^n/in/

I was about to say that,

with that
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

>
>> or from QAPI to consistently stick the 'name' parameter next
>> to the Visitor parameter.
>>
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>



--=20
Marc-Andr=C3=A9 Lureau